Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi b1e9ef93f2 Bug 35129: Return 400 if _per_page=0 passed
This patch adds a safe guard for when consumers pass _per_page=0 to
endpoints. This condition is checked for on a centralized place and
avoid reaching the controller in such scenarios that would provoke a
division by zero exception.

To test:
1. Apply the regression tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/pagination.t
=> FAIL: We expect a 400, but get a 500 instead
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! No more explosions for this!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 308bb0830c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2024-05-23 11:22:39 +02:00
acqui Bug 36053: Correct input name for item replacement fields 2024-04-18 09:22:03 +02:00
admin Bug 36447: Circ rules slow to load when many itemtypes and categories 2024-04-17 17:22:53 +02:00
api Bug 36329: Miscelaneous spec fixes 2024-03-21 11:07:57 +01:00
authorities Bug 30554: Use XSLT (if enabled) in authority search cataloguing plugin 2024-05-23 10:24:48 +02:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2024-01-03 15:48:28 +01:00
C4 Bug 34972: Remove GetOtherReserves 2024-05-22 14:44:24 +02:00
catalogue Bug 36563: Turn into array only if required 2024-05-22 14:35:48 +02:00
cataloguing Bug 24879: Add check_cookie_auth when missing 2024-03-27 07:54:16 +01:00
circ Bug 36376: (QA follow-up) Tidy 2024-05-23 11:14:20 +02:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves
debian Bug 36149: Unset userenv from middleware 2024-04-24 07:36:20 +02:00
docs Bug 35504: Split list of ERM Topic experts 2024-01-15 15:23:22 +01:00
erm
errors
etc Bug 35621: Map ÿ to y for searching (Non-ICU) 2024-05-23 10:22:10 +02:00
ill Bug 35930: Add guards for plugins_enabled 2024-02-15 10:51:57 +01:00
installer Bug 35610: DBRev 23.11.05.002 2024-05-23 10:55:09 +02:00
Koha Bug 35129: Return 400 if _per_page=0 passed 2024-05-23 11:22:39 +02:00
koha-tmpl Bug 36341: (follow-up) Fix missing Date_from_syspref 2024-05-23 11:20:40 +02:00
labels Bug 36511: Some scripts missing a dependency following Bug 24879 2024-04-11 15:57:36 +02:00
lib/CGI/Session/Serialize
members Bug 36376: (QA follow-up) Tidy 2024-05-23 11:14:20 +02:00
misc Bug 31286: Embed see-from headings into bibliographic records export 2024-05-23 10:39:39 +02:00
offline_circ Bug 34529: Offline circulation should be able to accept userid as well as cardnumber 2023-11-06 11:34:44 -03:00
opac Bug 36532: Protect opac-dismiss-message.pl from malicious usages 2024-04-24 07:36:20 +02:00
patron_lists Bug 34977: (QA follow-up) Tidy code 2023-11-08 11:41:33 -03:00
patroncards
plugins Bug 25672: Fix double output_html_with_http_headers 2023-10-31 11:02:45 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 31988: Remove reports/itemtypes.plugin 2024-03-27 07:54:16 +01:00
reserve Bug 34972: (QA follow-up) Remove some ModReserveCancelAll imports 2024-05-22 14:44:24 +02:00
reviews
rotating_collections
serials Bug 36511: Some scripts missing a dependency following Bug 24879 2024-04-11 15:57:36 +02:00
services
skel
suggestion Bug 35916: Purchase suggestions bibliographic filter should be a "contains" search 2024-03-11 15:30:25 +01:00
svc Bug 35942: OPAC user can enroll several times to the same club 2024-02-19 14:41:11 +01:00
t Bug 35129: Regression tests 2024-05-23 11:22:39 +02:00
tags
tools Bug 32029: Automatic item modifications by age add biblio table 2024-03-11 11:16:47 +01:00
virtualshelves Bug 35547: Show public "staff only" lists in addbybiblionumber.pl 2024-01-03 16:36:51 +01:00
xt Bug 24879: Exclude koha_perl_deps.pl 2024-03-27 07:54:16 +01:00
.editorconfig
.eslintrc.json
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
.stylelintrc.json
about.pl Bug 36134: Read complete Elasticsearch configuration in about.pl 2024-03-11 11:20:07 +01:00
app.psgi Bug 36149: Add userenv middleware to app.psgi 2024-04-24 07:36:20 +02:00
build-resources.PL
changelanguage.pl
cpanfile Bug 34064: Add SQL::Translator dependency to cpanfile 2023-10-10 10:54:04 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2024-01-03 14:16:31 +01:00
help.pl
INSTALL
Koha.pm Bug 35610: DBRev 23.11.05.002 2024-05-23 10:55:09 +02:00
kohaversion.pl
LICENSE
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-20 17:22:02 -03:00
Makefile.PL Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module 2024-01-17 10:06:28 +01:00
MANIFEST.SKIP
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js Bug 30708: Vue app 2023-10-18 15:41:40 -03:00
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo