Koha/reports
Jonathan Druart 2237e0f871 Bug 5404: C4::Koha - remove subfield_is_koha_internal_p
The commit b5ecefd485
Date:   Mon Feb 3 18:46:00 2003 +0000

had a funny description:
Added function to check if a MARC subfield name is "koha-internal"
(instead of checking it for 'lib' and 'tag' everywhere); temporarily
added to Koha.pm

"Temporarily", since 2003, everything is relative, isn't it? :)

The thing is that GetMarcStructure returns hash like

field_200 => {
    subfield_a => {
        %attributes_of_subfield_a
    },
    %attributes_of_field_200
}

The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'.
We don't want to loop on these values when looping on subfields.
Since there are just { k => v } with v is a scalar (string), it's easier
to test if we are processing a subfield testing the reference.

At some places, we don't need to test that, we are looping on values
from MARC::Field->subfields which are always valid subfields.

Test plan:
1/ Edit items using the batch item mod tool
2/ display and edit items via the cataloguing module.

You should not see any changes between before and after the patch
applied.

Tech notes:
We need to check what we are processing when we loop on 'subfields' from
GetMarcStructure, not from MARC::Field->subfields.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-07 17:30:09 +00:00
..
acquisitions_stats.pl Bug 15250: Fix Perl error on acqisition stats page 2015-12-04 14:24:55 +00:00
bor_issues_top.pl Bug 14965: Remove C4::Dates from 'lists' in folder reports 2015-11-05 09:56:52 -03:00
borrowers_out.pl Bug 14965: Remove C4::Dates from 'lists' in folder reports 2015-11-05 09:56:52 -03:00
borrowers_stats.pl Bug 15373: More changes of Zip to ZIP on intranet 2015-12-30 16:30:35 +00:00
cat_issues_top.pl Bug 10154 Add Call number in the filter of most circulated items 2015-12-31 16:16:10 +00:00
catalogue_out.pl Bug 14100: (follow-up) Language overlay for item types 2015-10-27 12:34:06 -03:00
catalogue_stats.pl Bug 7683: Relabel "acquired date" and "removed date" 2016-01-27 06:37:29 +00:00
dictionary.pl Bug 2669: Change checkboxes to radio buttons on dictionary 2016-01-27 02:42:46 +00:00
guided_reports.pl Bug 5404: C4::Koha - remove subfield_is_koha_internal_p 2016-03-07 17:30:09 +00:00
issues_avg_stats.pl Bug 14100: (follow-up) Language overlay for item types 2015-10-27 12:34:06 -03:00
issues_by_borrower_category.plugin
issues_stats.pl Bug 14100: (follow-up) Language overlay for item types 2015-10-27 12:34:06 -03:00
itemslost.pl Bug 14965: Remove C4::Dates from 'lists' in folder reports 2015-11-05 09:56:52 -03:00
itemtypes.plugin Bug 14100: (follow-up) Language overlay for item types 2015-10-27 12:34:06 -03:00
manager.pl Bug 9006: Remove AUTOLOAD in C4::Context 2015-07-20 10:11:41 -03:00
reports-home.pl
reserves_stats.pl Bug 14100: (follow-up) Language overlay for item types 2015-10-27 12:34:06 -03:00
serials_stats.pl Bug 14961: Remove C4::Dates from files reports/*_stats.pl 2015-10-26 11:19:36 -03:00
stats.print.pl
stats.screen.pl