Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/members
History
Kyle M Hall fb4025b67b Bug 10277 - Add C4::Context->IsSuperLibrarian() 
The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.

Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged

Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on second patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-12-30 15:47:23 +00:00
..
boraccount.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
default_messageprefs.pl Fix FSF address in directory members/ 2010-03-16 20:17:55 -04:00
deletemem.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
files.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
guarantor_search.pl bug_6253: Unified member Search() 2011-10-19 16:23:02 +13:00
mancredit.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
maninvoice.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
member-flags.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
member-password.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
member-picupload.pl Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests 2012-04-10 13:44:53 +02:00
member.pl Bug 10380: Change prototype for output_pref() routine 2013-10-17 23:34:26 +00:00
memberentry.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
members-home.pl Bug 7067 [Follow-up: templates] allow patron self registration via the opac 2012-12-14 08:08:59 -05:00
members-update-do.pl Bug 7067 - OPAC Borrower Self Registration 2012-12-14 08:08:59 -05:00
members-update.pl Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
mod_debarment.pl Bug 2720: (follow-up) change license version to GPLv3+ 2013-10-31 01:56:10 +00:00
moremember.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
notices.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
patronimage.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
pay.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
paycollect.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
printfeercpt.pl Bug 10954: ensure that payment receipt displays the payment made 2013-10-22 05:48:33 +00:00
printinvoice.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
printslip.pl Bug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference 2012-07-06 18:23:39 +02:00
purchase-suggestions.pl Bug 9261: (follow-up) QA improvements and GPL version change 2013-11-15 00:24:24 +00:00
readingrec.pl Bug 11009: (follow-up) tweak wording and remove potential log noise 2013-12-10 20:20:37 +00:00
routing-lists.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
setstatus.pl Bug 9406: ensure confirmation of patron renewal is displayed 2013-03-30 21:22:00 -04:00
statistics.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
update-child.pl Bug 10453: fix unintended password reset when updating child to adult 2013-12-26 15:29:40 +00:00