Pasi Kallinen 84855d75c1 Bug 23048: Hide non-pickup branches from hold modification select ... When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches, unless the branch is marked as a pick-up branch for already existing hold. The reason for showing a non-pickup branch for the holds created before the branch was marked as non-pickup: If the non-pickup branch wasn't shown, the branch in those holds would get set to the first branch in the select if the hold was modified. Test plan: 1) Create a hold for a patron, to be picked up from a certain branch. 2) Edit the branch and another branch so they are no longer pickup locations. 3) Go to members/moremember.pl for that patron, check the Holds-tab Pickup library -drop down. It lists both of the non-pickup branches. 4) Go to reserve/request.pl for that biblio. The hold-table Pickup library -drop down lists both of the non-pickup branches. 5) Apply patch. 6) Repeat 3 & 4, drop down no longer lists the non-pickup branch, but should still list the branch where the hold was marked to be picked from. Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>		2019-07-19 13:49:38 +01:00
..
catalogue	Bug 22424: (follow-up) Show blank value for empty status	2019-04-30 13:39:44 +00:00
csv_headers	Bug 22424: (follow-up) Show blank value for empty status	2019-04-30 13:39:44 +00:00
mana	Bug 22746: Fix typos in add mana comment modals again	2019-05-23 14:54:02 +00:00
modals
str	Bug 22904: Untranslatable strings in members-menu.js	2019-05-30 10:06:18 +00:00
virtualshelves/merge
about-team.inc	Bug 21626: (follow-up) Template corrections for arrayref	2019-05-17 14:46:10 +00:00
accounts.inc	Bug 22563: (follow-up) Items LOST should not be RETURNED	2019-07-15 11:28:01 +01:00
acquisitions-add-to-basket.inc
acquisitions-menu.inc	Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone	2019-04-11 13:34:10 +00:00
acquisitions-search.inc
acquisitions-toolbar.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
additem.js.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
additional-fields-display.inc	Bug 15774: (follow-up) Add html filters	2019-03-07 20:37:05 +00:00
additional-fields-entry.inc	Bug 15774: (follow-up) Add html filters	2019-03-07 20:37:05 +00:00
admin-items-search-field-form.inc
admin-menu.inc	Bug 21411: (QA follow-up) Fix permission checks on admin page and menu	2019-05-10 18:59:39 +00:00
adv-search.inc
auth-finder-search.inc
authorities-search-results.inc
authorities-search.inc
authorities-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
authorities.inc
authorities_js.inc
av-build-dropbox.inc
biblio-default-view.inc
biblio-view-menu.inc
blocked-fines.inc	Bug 21757: Clenup of moremember.pl and its templates	2019-04-29 12:12:40 +00:00
blocking_errors.inc	Bug 22616: Updating error text messages	2019-04-17 12:25:24 +00:00
borrower_debarments.inc
branch-selector.inc
browser-strings.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
budgets-active-currency.inc
budgets-admin-search.inc
budgets-admin-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
calendar.inc
cat-menu.inc
cat-search.inc	Bug 19046: Make seach pulldown to retain index selection	2019-03-11 10:28:09 +00:00
cat-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
catalog-strings.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
cataloging-search.inc
cateditor-ui.inc	Bug 17178: Add virtual keyboard to advanced cataloguing editor	2019-06-28 15:54:33 +01:00
cateditor-widgets-marc21.inc	Bug 23045: TextMarc errors on blank lines	2019-07-01 14:52:37 +01:00
category-out-of-age-limit.inc	Bug 17492: (QA follow-up) Correct template variable	2019-07-01 15:20:31 +01:00
chart.inc
checkin-search.inc
checkouts-table-footer.inc	Bug 7088: Allow renew on hold items with due date	2019-05-09 14:40:49 +00:00
checkouts-table.inc	Bug 7088: (follow-up) Add pref to checkbox	2019-05-09 14:40:49 +00:00
circ-menu.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
circ-nav.inc	Bug 10300: (follow-up) add controls on transfers page	2019-04-26 11:49:08 +00:00
circ-patron-search-results.inc
circ-search.inc
cities-admin-search.inc
columns_settings.inc	Bug 22811: Add button to clear DataTables filtering	2019-05-09 19:30:05 +00:00
contracts-admin-search.inc
country-list.inc
currencies-admin-search.inc
datatables.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
date-format.inc
delimiter_text.inc
doc-head-close-receipt.inc
doc-head-close.inc
doc-head-open.inc
empty_line.inc
facets.inc	Bug 14419: (QA follow-up) Restore the link styling	2019-07-04 09:23:22 +01:00
filter-orders.inc	Bug 21308: Results from order search do not show the search parameters	2019-04-19 14:13:53 +00:00
form-blocks.inc
format_price.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
greybox.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
guided-reports-view.inc
header.inc	Bug 22765: Add class beside loggedinusername to indicate if logged in user is a superlibrarian	2019-04-26 12:20:12 +00:00
holds_table.inc	Bug 23048: Hide non-pickup branches from hold modification select	2019-07-19 13:49:38 +01:00
home-search.inc
html_helpers.inc
i18n.inc
ill-list-table-strings.inc	Bug 18589: (follow-up) Fix QA tool failures	2019-03-22 20:21:47 +00:00
ill-list-table.inc	Bug 18589: (follow-up) Fix QA tool failures	2019-03-22 20:21:47 +00:00
ill-toolbar.inc	Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests	2019-06-03 18:56:29 +01:00
installer-doc-head-close.inc	Bug 22451: Use Asset everywhere	2019-04-16 13:17:32 +00:00
installer-intranet-bottom.inc	Bug 22451: Use Asset everywhere	2019-04-16 13:17:32 +00:00
installer-strings.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
intranet-bottom.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
intranetstylesheet.inc
js_includes.inc	Bug 21784: Clean up js_includes.inc	2019-04-24 11:00:19 +00:00
keyboard_shortcuts.inc	Bug 17178: Add virtual keyboard to advanced cataloguing editor	2019-06-28 15:54:33 +01:00
labels-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
langmenu-staff-top.inc
last-borrower.inc
letters-search.inc
member-alt-address-style-de.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-address-style-fr.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-address-style-us.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-contact-style-de.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-contact-style-fr.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-contact-style-us.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-display-address-style-de.inc
member-display-address-style-fr.inc
member-display-address-style-us.inc
member-display-alt-address-style-de.inc
member-display-alt-address-style-fr.inc
member-display-alt-address-style-us.inc
member-main-address-style-de.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-main-address-style-fr.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-main-address-style-us.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
members-toolbar.inc	Bug 22904: Untranslatable strings in members-menu.js	2019-05-30 10:06:18 +00:00
merge-record-strings.inc
merge-record.inc
messaging-preference-form.inc
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc	Bug 22935: Improve style of Bootstrap pagination	2019-06-24 15:41:07 +01:00
password_check.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
patron-article-requests.inc
patron-search-box.inc
patron-search.inc
patron-title.inc
patron-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
patroncards-errors.inc
patroncards-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
patrons-admin-search.inc
permissions.inc	Bug 23109: Improve description of staffaccess permission	2019-06-24 17:14:36 +01:00
popup-bottom.inc
prefs-admin-search.inc
prefs-menu.inc
quotes-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
quotes-upload-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
reports-menu.inc
reports-toolbar.inc	Bug 22746: Fix typos in add mana comment modals again	2019-05-23 14:54:02 +00:00
resort_form.inc
rotating-collections-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
search_indexes.inc	Bug 19046: (QA follow-up) Remove doubled up 'Title as phrase'	2019-03-11 10:28:09 +00:00
select2.inc	Bug 22451: Use Asset everywhere	2019-04-16 13:17:32 +00:00
serials-menu.inc	Bug 22851: Style navigation links in serials modules like same links in other modules	2019-06-19 13:15:48 +01:00
serials-search.inc
serials-toolbar.inc	Bug 23065: Rename "New subscription" button when default to current serial	2019-06-13 12:28:00 +01:00
slip-print.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
stockrotation-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
strings.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc
timepicker.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
tools-item-action.inc
tools-menu.inc	Bug 11642: (follow-up) Improve Batch patron deletion and anonymization GUI to make consequences clearer	2019-07-15 12:43:03 +01:00
tools-nomatch-action.inc
tools-overlay-action.inc
validator-strings.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
vendor-menu.inc
virtualshelves-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
waiting_holds.inc	Bug 23192: (RM follow-up) Add missing filters to waiting_holds.inc	2019-07-15 13:57:12 +01:00
wysiwyg-systempreferences.inc
xslt-handler.inc
z3950-admin-search.inc
z3950_search.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00