Kyle M Hall
b8da5462b0
If items are assigned to multiple courses, the "edit" links for a course item may pass the wrong course id. This is really a cosmetic issue. It appears that in Template Toolkit, if you reuse an existing variable name in a foreach loop, it will not create a new temporary variable but will instead re-use the existing variable leaving assigned at the end to the last assignment, just as it would in Perl code. This is not a problem when all items are assigned to one and only one course, but can cause issues when we loop through the other courses an item may be on. This is solved easily by renaming the variable used in the foreach loop to another unused name. Test Plan: 1) Apply this patch 2) Try the edit and delete links for an item on reserve for a course 3) No changes in behavior should be noted Signed-off-by: Tom Misilo <misilot@fit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> |
||
|---|---|---|
| .. | ||
| intranet-tmpl | ||
| opac-tmpl | ||
| favicon.ico | ||
| index.html | ||
| intranet.html | ||
| opac.html | ||
| templates.readme | ||