Koha/Koha/Checkouts.pm
Tomas Cohen Arazi 137b845f23 Bug 23207: Automatic checkin items should never be overdue
This patch makes Koha::Checkouts->automatic_checkin pass the date_due as
return date to AddReturn.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Checkouts.t
=> FAIL: The feature is not working properly
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-22 14:37:14 +02:00

115 lines
2.5 KiB
Perl

package Koha::Checkouts;
# Copyright ByWater Solutions 2015
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Carp;
use C4::Context;
use C4::Circulation;
use Koha::Checkout;
use Koha::Database;
use Koha::DateUtils;
use base qw(Koha::Objects);
=head1 NAME
Koha::Checkouts - Koha Checkout object set class
=head1 API
=head2 Class Methods
=cut
=head3 calculate_dropbox_date
my $dt = Koha::Checkouts::calculate_dropbox_date();
=cut
sub calculate_dropbox_date {
my $userenv = C4::Context->userenv;
my $branchcode = $userenv->{branch} // q{};
my $daysmode = Koha::CirculationRules->get_effective_daysmode(
{
categorycode => undef,
itemtype => undef,
branchcode => $branchcode,
}
);
my $calendar = Koha::Calendar->new( branchcode => $branchcode, days_mode => $daysmode );
my $today = dt_from_string;
my $dropbox_date = $calendar->addDuration( $today, -1 );
return $dropbox_date;
}
=head3 automatic_checkin
my $automatic_checkins = Koha::Checkouts->automatic_checkin()
Checks in every due issue which itemtype has automatic_checkin enabled
=cut
sub automatic_checkin {
my ($self, $params) = @_;
my $current_date = dt_from_string;
my $dtf = Koha::Database->new->schema->storage->datetime_parser;
my $due_checkouts = $self->search(
{ date_due => { '<=' => $dtf->format_datetime($current_date) } },
{ prefetch => 'item'}
);
while ( my $checkout = $due_checkouts->next ) {
if ( $checkout->item->itemtype->automatic_checkin ) {
C4::Circulation::AddReturn( $checkout->item->barcode,
$checkout->branchcode, undef, dt_from_string($checkout->date_due) );
}
}
}
=head3 type
=cut
sub _type {
return 'Issue';
}
=head3 object_class
=cut
sub object_class {
return 'Koha::Checkout';
}
=head1 AUTHOR
Kyle M Hall <kyle@bywatersolutions.com>
=cut
1;