Koha/t/db_dependent/Circulation
Jonathan Druart 1af5b8a7d7 Bug 26132: Remove raw sql query
Making use of Koha::Checkouts make the code much more readable here.
It fixes 2 flaws:
 * $type was not quote escaped
 * the effective itemtype was not used which could lead to wrong
 calculation (for instance item-level_itypes is set but the item does
 not have the itype defined)

However there is something to note, we are going to make things a bit
less effective as we are now fetching the items to get their effective
itemtype (vs a SUM done at DB level)

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-13 10:15:33 +02:00
..
IssuingRules Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Branch.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
CalcDateDue.t Bug 25723: Update cache flushing calls 2020-07-20 17:45:31 +02:00
CalcFine.t Bug 18936: More fixes 2020-02-04 09:56:26 +00:00
CheckIfIssuedToPatron.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
CheckValidBarcode.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
dateexpiry.t Bug 19943: Fix dateexpiry.t - create the biblioitem entry 2018-03-23 13:24:15 -03:00
GetHardDueDate.t Bug 17845: Remove some missed references to branchprinter 2020-03-10 15:18:28 +00:00
GetPendingOnSiteCheckouts.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
GetTopIssues.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
IsItemIssued.t Bug 23463: Fix IsItemIssued.t 2020-03-23 09:26:34 +00:00
issue.t Bug 25724: Unit tests 2020-07-27 17:05:06 +02:00
MarkIssueReturned.t Bug 24413: (follow-up) Add tests 2020-05-25 15:58:14 +02:00
NoIssuesChargeGuarantees.t Bug 24408: Do not compare floats with precision in tests 2020-01-13 13:42:45 +00:00
OfflineOperation.t Bug 17845: Remove some missed references to branchprinter 2020-03-10 15:18:28 +00:00
ReturnClaims.t Bug 18936: Fix some more tests 2020-02-04 09:56:27 +00:00
Returns.t Bug 8338: (QA follow-up) Fix test for backdated return 2020-07-21 12:21:28 +02:00
StoreLastBorrower.t Bug 14591: Update unit tests 2019-03-15 12:14:03 +00:00
SwitchOnSiteCheckouts.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
TooMany.t Bug 26132: Remove raw sql query 2020-08-13 10:15:33 +02:00
transferbook.t Bug 24299: Add Unit test for 'reason' in transferbook 2020-03-20 15:54:58 +00:00
transfers.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00