f726558510
Refactor the most performance critical subroutines in Circulation.pm to take objects instead of unblessed ones to reduce unnecessary unblessings and generally clean up the code. To test: 1) Ensure the following tests all pass: t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/ILSDI_Services.t t/db_dependent/Illrequests.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/api/v1/return_claims.t t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Reserves.t t/db_dependent/HoldsQueue.t t/db_dependent/selenium/regressions.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Plugins/Recall_hooks.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Circulation/_CalculateAndUpdateFine.t Sponsored-by: Gothenburg University Library Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
94 lines
3 KiB
Perl
Executable file
94 lines
3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use Test::More tests => 3;
|
|
use MARC::Record;
|
|
|
|
use Koha::Libraries;
|
|
use Koha::Patrons;
|
|
use C4::Context;
|
|
use C4::Items;
|
|
use C4::Biblio;
|
|
use C4::Reserves qw( AddReserve ModReserve ModReserveAffect );
|
|
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
my $builder = t::lib::TestBuilder->new;
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
$dbh->do("DELETE FROM reserves");
|
|
$dbh->do("DELETE FROM old_reserves");
|
|
|
|
my $branchcode = $builder->build( { source => 'Branch' } )->{branchcode};
|
|
my $itemtype = $builder->build(
|
|
{ source => 'Itemtype', value => { notforloan => undef } } )->{itemtype};
|
|
|
|
t::lib::Mocks::mock_userenv({ flags => 1, userid => '1', branchcode => $branchcode });
|
|
|
|
my $borrowers_count = 3;
|
|
|
|
my $biblio = $builder->build_sample_biblio();
|
|
my $item_barcode = 'my_barcode';
|
|
my $itemnumber = Koha::Item->new(
|
|
{
|
|
biblionumber => $biblio->biblionumber,
|
|
homebranch => $branchcode,
|
|
holdingbranch => $branchcode,
|
|
barcode => $item_barcode,
|
|
itype => $itemtype
|
|
},
|
|
)->store->itemnumber;
|
|
|
|
# Create some borrowers
|
|
my $patron_category = $builder->build({ source => 'Category' });
|
|
my @borrowernumbers;
|
|
foreach my $i ( 1 .. $borrowers_count ) {
|
|
my $borrowernumber = Koha::Patron->new({
|
|
firstname => 'my firstname',
|
|
surname => 'my surname ' . $i,
|
|
categorycode => $patron_category->{categorycode},
|
|
branchcode => $branchcode,
|
|
})->store->borrowernumber;
|
|
push @borrowernumbers, $borrowernumber;
|
|
}
|
|
|
|
# Create five item level holds
|
|
foreach my $borrowernumber (@borrowernumbers) {
|
|
AddReserve(
|
|
{
|
|
branchcode => $branchcode,
|
|
borrowernumber => $borrowernumber,
|
|
biblionumber => $biblio->biblionumber,
|
|
}
|
|
);
|
|
}
|
|
|
|
ModReserveAffect( $itemnumber, $borrowernumbers[0] );
|
|
my $patron = Koha::Patrons->find( $borrowernumbers[1] );
|
|
C4::Circulation::AddIssue( $patron, $item_barcode, undef, 'revert' );
|
|
|
|
my $priorities = $dbh->selectall_arrayref(
|
|
"SELECT priority FROM reserves ORDER BY priority ASC");
|
|
ok( scalar @$priorities == 2, 'Only 2 holds remain in the reserves table' );
|
|
ok( $priorities->[0]->[0] == 1, 'First hold has a priority of 1' );
|
|
ok( $priorities->[1]->[0] == 2, 'Second hold has a priority of 2' );
|
|
|
|
$schema->storage->txn_rollback;
|