Owen Leonard
bb505d77f4
This follow-up makes drastic changes to the templates in order to bring them into compliance with established patterns and markup guidelines. Only minor changes are made to perl scripts. Changes: - Add a toolbar include for displaying new, edit, transfer, and delete buttons. - Improve title and breadcrumbs with collection titles and better specificity. - Correct page structure which was inconsistent with the markup of similarly-structured pages. - Correct styling of error and informational messages. - Added detailed error messages for a couple of conditions which were not defined in the template. - Add link to the detail page of titles which are in a collection using the view defined in the IntranetBiblioDefaultView preference. - Add a link to remove an item from a collection directly without having to scan the barcode. - Add client-side validation to collection creation form. - In RotatingCollections.pm, add biblionumber to the list of columns returned by GetItemsInCollection. - In rotating_collections/*.pl, remove obsolete declaration of system preference variables. To test, perform all the operations associated with Rotating Collections: - Add a new collection - Edit an existing collection - Add items to a collection - Remove items from a collection (via barcode and link) - Test the behavior of all new toolbar buttons - Verify that titles and breadcrumbs look correct and links work correctly. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
117 lines
3.3 KiB
Perl
Executable file
117 lines
3.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along with
|
|
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
|
|
# Suite 330, Boston, MA 02111-1307 USA
|
|
#
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI;
|
|
|
|
use C4::Output;
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
|
|
use C4::RotatingCollections;
|
|
|
|
my $query = new CGI;
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "rotating_collections/editCollections.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { tools => 'rotating_collections' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $action = $query->param('action');
|
|
$template->param( action => $action );
|
|
|
|
# Create new Collection
|
|
if ( $action eq 'create' ) {
|
|
my $title = $query->param('title');
|
|
my $description = $query->param('description');
|
|
|
|
my ( $createdSuccessfully, $errorCode, $errorMessage ) =
|
|
CreateCollection( $title, $description );
|
|
|
|
$template->param(
|
|
previousActionCreate => 1,
|
|
createdTitle => $title,
|
|
);
|
|
|
|
if ($createdSuccessfully) {
|
|
$template->param( createSuccess => 1 );
|
|
}
|
|
else {
|
|
$template->param( createFailure => 1 );
|
|
$template->param( failureMessage => $errorMessage );
|
|
}
|
|
}
|
|
|
|
## Delete a club or service
|
|
elsif ( $action eq 'delete' ) {
|
|
my $colId = $query->param('colId');
|
|
my ( $success, $errorCode, $errorMessage ) = DeleteCollection($colId);
|
|
|
|
$template->param( previousActionDelete => 1 );
|
|
if ($success) {
|
|
$template->param( deleteSuccess => 1 );
|
|
}
|
|
else {
|
|
$template->param( deleteFailure => 1 );
|
|
$template->param( failureMessage => $errorMessage );
|
|
}
|
|
}
|
|
|
|
## Edit a club or service: grab data, put in form.
|
|
elsif ( $action eq 'edit' ) {
|
|
my ( $colId, $colTitle, $colDesc, $colBranchcode ) = GetCollection( $query->param('colId') );
|
|
|
|
$template->param(
|
|
previousActionEdit => 1,
|
|
editColId => $colId,
|
|
editColTitle => $colTitle,
|
|
editColDescription => $colDesc,
|
|
);
|
|
}
|
|
|
|
# Update a Club or Service
|
|
elsif ( $action eq 'update' ) {
|
|
my $colId = $query->param('colId');
|
|
my $title = $query->param('title');
|
|
my $description = $query->param('description');
|
|
|
|
my ( $createdSuccessfully, $errorCode, $errorMessage ) =
|
|
UpdateCollection( $colId, $title, $description );
|
|
|
|
$template->param(
|
|
previousActionUpdate => 1,
|
|
updatedTitle => $title,
|
|
);
|
|
|
|
if ($createdSuccessfully) {
|
|
$template->param( updateSuccess => 1 );
|
|
}
|
|
else {
|
|
$template->param( updateFailure => 1 );
|
|
$template->param( failureMessage => $errorMessage );
|
|
}
|
|
}
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|