Koha/tools/access_files.pl
Tomas Cohen Arazi 10d12f999f
Bug 33341: Address some perlcritic errors in 5.36
Some old-style code is making our tests fail when run in Debian Testing.

This patch addresses this.

To test:
1. Launch bookworm KTD:
   $ KOHA_IMAGE=master-bookworm ktd up -d
2. Run:
   $ ktd --shell
  k$ prove t/00-testcritic.t
=> FAIL: It fails!
3. Apply the patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-03-28 14:50:33 +02:00

121 lines
3.9 KiB
Perl
Executable file

#!/usr/bin/perl
# Frédérick Capovilla, 2011 - Libéo
#
# Show a list of all the files in the directory specified by the option
# "access_dir" in koha-conf.xml so they can be downloaded by users with the
# "access_files" permission.
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use C4::Auth qw( get_template_and_user );
use CGI;
use C4::Context;
use C4::Output qw( output_html_with_http_headers );
use File::stat qw( stat );
use Digest::MD5 qw( md5_hex );
use Encode qw( decode );
my $input = CGI->new;
my $file_id = $input->param("id");
my $access_dirs = C4::Context->config('access_dirs');
my @directories;
if ($access_dirs){
if (ref $access_dirs->{access_dir} ){
@directories = @{$access_dirs->{access_dir}};
} else {
@directories =($access_dirs->{access_dir});
}
} else {
@directories = ();
}
my ($template, $borrowernumber, $cookie)
= get_template_and_user({template_name => "tools/access_files.tt",
query => $input,
type => "intranet",
flagsrequired => { tools => 'access_files' },
});
unless(@directories) {
$template->param(error_no_dir => 1);
}
else {
#Get the files list
my @files_list;
foreach my $dir(@directories){
my $dir_h;
opendir($dir_h, $dir);
foreach my $filename (readdir($dir_h)) {
my $full_path = "$dir/$filename";
my $id = md5_hex($full_path);
next if ($filename =~ /^\./ or -d $full_path);
# Make sure the filename is unicode-friendly
my $decoded_filename = decode('utf8', $filename);
my $st = stat("$dir/$decoded_filename");
my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) =localtime($st->mtime);
my $dt=DateTime->new(year => $year + 1900,
month => $mon + 1,
day => $mday,
hour => $hour,
minute => $min,
);
push(@files_list, {name => $decoded_filename,
access_dir => $dir,
date =>$dt,
size => $st->size,
id => $id});
}
closedir($dir_h);
}
my %files_hash = map { $_->{id} => $_ } @files_list;
# If we received a file_id and it is valid, send the file to the browser
if(defined $file_id and exists $files_hash{$file_id} ){
my $filename = $files_hash{$file_id}->{name};
my $dir = $files_hash{$file_id}->{access_dir};
binmode STDOUT;
# Open the selected file and send it to the browser
print $input->header(-type => 'application/x-download',
-name => "$filename",
-Content_length => -s "$dir/$filename",
-attachment => "$filename");
my $fh;
open $fh, "<:encoding(UTF-8)", "$dir/$filename";
binmode $fh;
my $buf;
while(read($fh, $buf, 65536)) {
print $buf;
}
close $fh;
exit(0);
}
else{
# Send the file list to the template
$template->param(files_loop => \@files_list);
}
}
output_html_with_http_headers $input, $cookie, $template->output;