Koha/admin/columns_settings.pl
Jonathan Druart 46f7239b08 Bug 27673: Replace YAML with YAML::XS
From tht YAML pod:

"""
This module has been released to CPAN as YAML::Old, and soon YAML.pm will be changed to just be a frontend interface module for all the various Perl YAML implementation modules, including YAML::Old.

If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time. It requires that you have a C compiler, since it is written in C.
"""

See also
https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35

Test plan:
Try some place where YAML::XS is not used and confirm that it works
correctly

QA note: This patch removes some uses of YAML that were not useful

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-02-16 14:54:50 +01:00

79 lines
2.5 KiB
Perl
Executable file

#!/usr/bin/perl
use Modern::Perl;
use CGI;
use C4::Auth;
use C4::Context;
use C4::Output;
use C4::Utils::DataTables::TablesSettings qw( get_modules );
my $input = CGI->new;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "admin/columns_settings.tt",
query => $input,
type => "intranet",
flagsrequired => { parameters => 'manage_column_config' },
debug => 1,
}
);
my $action = $input->param('action') // 'list';
if ( $action eq 'save' ) {
my $module = $input->param('module');
my @columnids = $input->multi_param("columnid");
my @columns;
for my $columnid (@columnids) {
next unless $columnid =~ m|^([^#]*)#([^#]*)#(.*)$|;
my $is_hidden = $input->param( $columnid . '_hidden' ) // 0;
my $cannot_be_toggled =
$input->param( $columnid . '_cannot_be_toggled' ) // 0;
push @columns,
{
module => $module,
page => $1,
tablename => $2,
columnname => $3,
is_hidden => $is_hidden,
cannot_be_toggled => $cannot_be_toggled,
};
}
C4::Utils::DataTables::TablesSettings::update_columns(
{
columns => \@columns,
}
);
my @table_ids = $input->multi_param('table_id');
for my $table_id (@table_ids) {
next unless $table_id =~ m|^([^#]*)#(.*)$|;
my $default_display_length = $input->param( $table_id . '_default_display_length' );
my $default_sort_order = $input->param( $table_id . '_default_sort_order' );
if ( defined $default_display_length && $default_display_length ne ""
&& defined $default_sort_order && $default_sort_order ne "" ) {
C4::Utils::DataTables::TablesSettings::update_table_settings(
{
module => $module,
page => $1,
tablename => $2,
default_display_length => $default_display_length,
default_sort_order => $default_sort_order,
}
);
}
}
$action = 'list';
}
if ( $action eq 'list' ) {
my $modules = C4::Utils::DataTables::TablesSettings::get_modules;
$template->param(
panel => ( $input->param('panel') || 0 ),
modules => $modules,
);
}
output_html_with_http_headers $input, $cookie, $template->output;