3e84279d3e
The scripts for managing both bib and authority frameworks are now expecting
an op 'cud-delete_confirm' but delete_confirm isn't cud, it's just a GET of a
page asking if you are sure. The scripts just need to expect the op they are
actually getting, delete_confirm.
Test plan:
1. Administration - MARC bibliographic framework - New framework
2. Give the framework any code and description and Submit
3. Actions menu for your new framework - Delete
4. Note the message says 'Confirm deletion of framework '' ()?" rather than
having the code and description included.
5. Click Yes, note that deleting failed
6. Administration - Authority types - New authority type
7. Give the authority type any type and description and Submit
8. Actions menu for your authority type - Delete
9. Note the message again says '' () rather than 'desc' (FOO)
10. Click yes, note that deleting failed
11. Finally! Apply patch, reset_all
12. Repeat steps 1-10, this time noting that you get 'desc' (FOO) rather than
'' (), and that deleting works.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit c81b201dc9
)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
128 lines
4.6 KiB
Perl
Executable file
128 lines
4.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
# Copyright 2002 Paul Poulain
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Context;
|
|
use C4::Auth qw( get_template_and_user );
|
|
use C4::Output qw( output_html_with_http_headers );
|
|
use Koha::Biblios;
|
|
use Koha::BiblioFramework;
|
|
use Koha::BiblioFrameworks;
|
|
use Koha::Caches;
|
|
|
|
my $input = CGI->new;
|
|
my $frameworkcode = $input->param('frameworkcode') || q||;
|
|
my $op = $input->param('op') || q|list|;
|
|
my $cache = Koha::Caches->get_instance();
|
|
my @messages;
|
|
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{ template_name => "admin/biblio_framework.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
flagsrequired => { parameters => 'manage_marc_frameworks' },
|
|
}
|
|
);
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
if ( $op eq 'add_form' ) {
|
|
my $framework;
|
|
if ($frameworkcode) {
|
|
$framework = Koha::BiblioFrameworks->find($frameworkcode);
|
|
}
|
|
$template->param( framework => $framework );
|
|
} elsif ( $op eq 'cud-add_validate' ) {
|
|
my $frameworkcode = $input->param('frameworkcode');
|
|
my $frameworktext = $input->param('frameworktext');
|
|
my $is_a_modif = $input->param('is_a_modif');
|
|
|
|
if ($is_a_modif) {
|
|
my $framework = Koha::BiblioFrameworks->find($frameworkcode);
|
|
$framework->frameworktext($frameworktext);
|
|
eval { $framework->store; };
|
|
if ($@) {
|
|
push @messages, { type => 'error', code => 'error_on_update' };
|
|
} else {
|
|
push @messages, { type => 'message', code => 'success_on_update' };
|
|
}
|
|
} else {
|
|
my $framework = Koha::BiblioFramework->new(
|
|
{ frameworkcode => $frameworkcode,
|
|
frameworktext => $frameworktext,
|
|
}
|
|
);
|
|
eval { $framework->store; };
|
|
if ($@) {
|
|
push @messages, { type => 'error', code => 'error_on_insert' };
|
|
} else {
|
|
push @messages, { type => 'message', code => 'success_on_insert' };
|
|
}
|
|
}
|
|
$cache->clear_from_cache("MarcStructure-0-$frameworkcode");
|
|
$cache->clear_from_cache("MarcStructure-1-$frameworkcode");
|
|
$cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
|
|
$cache->clear_from_cache("MarcCodedFields-$frameworkcode");
|
|
$op = 'list';
|
|
} elsif ( $op eq 'delete_confirm' ) {
|
|
my $framework = Koha::BiblioFrameworks->find($frameworkcode);
|
|
my $count = Koha::Biblios->search( { frameworkcode => $frameworkcode, } )->count;
|
|
|
|
$template->param(
|
|
framework => $framework,
|
|
biblios_use_this_framework => $count,
|
|
);
|
|
} elsif ( $op eq 'cud-delete_confirmed' ) {
|
|
my $framework = Koha::BiblioFrameworks->find($frameworkcode);
|
|
my $deleted = eval { $framework->delete; };
|
|
|
|
if ( $@ or not $deleted ) {
|
|
push @messages, { type => 'error', code => 'error_on_delete' };
|
|
} else {
|
|
eval {
|
|
my $dbh = C4::Context->dbh;
|
|
$dbh->do( q|DELETE FROM marc_tag_structure WHERE frameworkcode=?|, undef, $frameworkcode );
|
|
$dbh->do( q|DELETE FROM marc_subfield_structure WHERE frameworkcode=?|, undef, $frameworkcode );
|
|
};
|
|
if ($@) {
|
|
push @messages, { type => 'error', code => 'error_on_delete_fk' };
|
|
} else {
|
|
push @messages, { type => 'message', code => 'success_on_delete' };
|
|
}
|
|
}
|
|
$cache->clear_from_cache("MarcStructure-0-$frameworkcode");
|
|
$cache->clear_from_cache("MarcStructure-1-$frameworkcode");
|
|
$cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
|
|
$cache->clear_from_cache("MarcCodedFields-$frameworkcode");
|
|
$op = 'list';
|
|
}
|
|
|
|
if ( $op eq 'list' ) {
|
|
my $frameworks = Koha::BiblioFrameworks->search( {}, { order_by => ['frameworktext'], } );
|
|
$template->param( frameworks => $frameworks, );
|
|
}
|
|
|
|
$template->param(
|
|
messages => \@messages,
|
|
op => $op,
|
|
);
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
|