cb01b25330
Includes:
* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up next developments
* SytemPreferences:
Mana Activation:
- add a value "no, let me think about it", that is the default value.
- as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
- Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default)
* Interface :
- On mana-search, rows are now sorted by date of last import, then by number of users
- Windows redesigned to improve the user experience
* New Feature : report a mistake.
- people can now report an invalid data (wrong, obsolete,...)
- if a data is reported as invalid many time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain the new feature)
- When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists
* API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
- no hardcoding for resources in the code of api (api needs to be called with a ressourcename)
* New feature : SQL report sharing
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana-KB
- New feature: search report in Mana-KB with keywords
- New feature: load reports from Mana-KB
Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example)
<!-- URL of the mana KB server -->
<!-- alternative value http://mana-test.koha-community.org to query the test server -->
<mana_config>https://mana-kb.koha-community.org</mana_config>
3 - Check Mana syspref and AutoShareWithMana syspref are not activated
4 - Search the syspref ManaToken and follow the instructions
5 - subscriptions
- Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled)
- Share this serial with Mana-KB (on the serial individual's page there must be a Share button)
- Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use
6 - SQL Report
- Create a new SQL report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list.
7 - Report mistakes.
- On any table containing Mana-KB search results, you can report a mistake and add a comment.
8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message.
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
46 lines
1.5 KiB
JavaScript
46 lines
1.5 KiB
JavaScript
/* global MSG_CLOSE_SUBSCRIPTION MSG_REOPEN_SUBSCRIPTION CONFIRM_DELETE_SUBSCRIPTION subscriptionid */
|
|
|
|
function confirm_close() {
|
|
var is_confirmed = confirm( MSG_CLOSE_SUBSCRIPTION );
|
|
if (is_confirmed) {
|
|
window.location="subscription-detail.pl?subscriptionid=" + subscriptionid + "&op=close";
|
|
}
|
|
}
|
|
function confirm_reopen() {
|
|
var is_confirmed = confirm( MSG_REOPEN_SUBSCRIPTION );
|
|
if (is_confirmed) {
|
|
window.location="subscription-detail.pl?subscriptionid=" + subscriptionid + "&op=reopen";
|
|
}
|
|
}
|
|
|
|
function confirm_deletion() {
|
|
var is_confirmed = confirm( CONFIRM_DELETE_SUBSCRIPTION );
|
|
if (is_confirmed) {
|
|
window.location="subscription-detail.pl?subscriptionid=" + subscriptionid + "&op=del";
|
|
}
|
|
}
|
|
function popup(subscriptionid) {
|
|
newin=window.open("subscription-renew.pl?mode=popup&subscriptionid="+subscriptionid,'popup','width=590,height=440,toolbar=false,scrollbars=yes');
|
|
}
|
|
|
|
$(document).ready(function() {
|
|
$("#deletesub").click(function(){
|
|
confirm_deletion();
|
|
return false;
|
|
});
|
|
$("#reopen").click(function(){
|
|
confirm_reopen();
|
|
return false;
|
|
});
|
|
$("#close").click(function(){
|
|
confirm_close();
|
|
return false;
|
|
});
|
|
$("#renew").click(function(){
|
|
popup( subscriptionid );
|
|
return false;
|
|
});
|
|
$("#mana-subscription-share").click(function() {
|
|
window.location="subscription-detail.pl?subscriptionid=" + subscriptionid + "&op=share";
|
|
});
|
|
});
|