Koha/t/db_dependent
Jonathan Druart be4f624b32 Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible
Here we go, you will notice at the dependency list that this one is a
bit different.
In our former syntax we have 2 custom tags <checkedout> and <overdue>.
These tags were allowed to permit loop on the checked out items and the
overdue items.

In this patch, we will use the "loops" parameter, introduced by bug
17971, to pass the list of checkouts and overdues to the template.

Note that Kyle suggested another approach on bug 15283: all the
checkouts were send into the same array and each element of this
array calls the is_from_today method, to know if the checkout is an
overdue.
I don't think we should rely on the Koha API, that's why I suggest to
pass 2 differents object list, 1 which contains the checkouts and
another one with the overdues.
Note that we do rely on the Koha API, we call the Koha::Checkout->item
and Koha::Item->biblio to propose an equivalent TT notice. But I think
we can accept that.

Test plan:
Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the
same notices you generated with the historical syntax.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=17969

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-01 17:06:55 -03:00
..
Acquisition Bug 19024 Fix some infelicities of phrasing in test messages 2017-09-01 13:02:24 -03:00
api/v1 Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth
Authorities Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Biblio Bug 18951: Adjust Isbd.t 2017-07-24 13:37:18 -03:00
Circulation Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds 2017-09-01 17:05:17 -03:00
Creators
data
Exporter Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
Items Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds 2017-09-01 17:05:17 -03:00
Koha Bug 19004: Patrons.t should create its own data for enrollment fees. 2017-09-01 13:02:26 -03:00
Labels Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
LDAP
Letters Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible 2017-09-01 17:06:55 -03:00
Members Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
OAI Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Patron Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record
Reports Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
Reserves Bug 19025: Move GetReserveInfo to Koha::Holds 2017-08-30 15:06:10 -03:00
Search Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup 2017-07-26 14:36:34 -03:00
selenium Bug 18982: Remove data in the correct order 2017-07-26 13:50:44 -03:00
Serials Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
SIP Bug 18812 - SIP Patron status does not respect OverduesBlockCirc 2017-09-01 13:00:05 -03:00
Template/Plugin Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
www Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
XSLT_Handler
00-strict.t Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl 2017-05-08 09:22:27 -04:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Acquisition.t Bug 18260: Koha::Biblio - Remove GetBiblio 2017-07-10 13:03:38 -03:00
AdditionalField.t
Amazon.t
ArticleRequests.t Bug 18766: Remove itemtype-related warnings from ArticleRequests.t 2017-06-09 10:50:53 -03:00
AudioAlerts.t
Auth.t Bug 18976: Fix t/db_dependent/Auth.t cleanup 2017-07-26 14:36:34 -03:00
Auth_with_cas.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Bookseller.t Bug 19130: Remove ->search() overloading and adjust tests 2017-08-25 11:53:43 -03:00
Breeding.t
Budgets.t Bug 18941 - Unit tests 2017-08-10 16:25:34 -03:00
Calendar.t Bug 12063 - Fix QA failures 2017-05-09 08:59:39 -04:00
Charset.t
check_sysprefs.t
Circulation.t Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace 2017-09-01 17:05:17 -03:00
ClassSource.t
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
Context.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Contract.t
CourseReserves.t
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
DecreaseLoanHighHolds.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds.t Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace 2017-09-01 17:05:17 -03:00
HoldsQueue.t Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm 2017-07-24 14:12:27 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-08-15 12:17:42 -03:00
Installer.t
Items.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Elasticsearch_Indexer.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Languages.t
Letters.t Bug 17969: Refactor the way <<items.content>> is generated 2017-08-30 15:06:25 -03:00
Linker_FirstMatch.t
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-08-25 12:12:04 -03:00
MungeMarcPrice.t
NewsChannels.t
Overdues.t
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Plugins.t
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
Reserves.t Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds 2017-09-01 17:05:17 -03:00
rollingloans.t Bug 17829: Execute rollingloans tests in a transaction 2017-07-26 16:39:17 -03:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-05 13:41:47 -03:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication 2017-06-05 17:52:48 -03:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 9857: Fix failing tests 2017-09-01 16:22:02 -03:00
Suggestions.t Bug 18420: Use TestBuilder to create a patron category in Suggestions.t 2017-04-21 10:49:25 -04:00
sysprefs.t
Tags.t
Templates.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
TestBuilder.t Bug 18182: Tests all Koha::Objects-based modules 2017-04-21 00:10:50 +00:00
Upload.t Bug 18300: [QA Follow-up] Fix return value inconsistency 2017-04-21 00:11:40 +00:00
UsageStats.t
Virtualshelves.t Bug 18672: [QA Follow-up] Simplify without sleep 2017-07-17 13:19:43 -03:00
XISBN.t
XSLT_Handler.t Bug 17807: Add format parameter to XSLT_Handler->transform 2017-08-30 15:06:40 -03:00
zebra_config.pl