Andreas Roussos be81f156b8 Bug 32447: Fix DataTable filtering when hidden columns are in place ... The bibliographic record's details page in the Staff interface includes a 'Holdings' table at the bottom with information for each item attached to the record. When activating the filters in this table, there is no input field for the barcode column but just bold text. This broke in v22.11.00, the related commit being 018a981b9b from Bug 29282 where two new hidden columns were added to that table. We can fix this by taking advantage of the existing code in koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc (introduced by commit dfb7af91af from Bug 23307) which allows us to create and hook our own custom columnsInit() function in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt to redraw the DataTable filters upon page load if a column is marked as 'is_hidden: 1' in admin/columns_settings.yml, or if a column is added/removed via the "⚙ Columns" button (both are handled by the DataTables column-visibility.dt event). Redrawing the filters via the above method also fixes the issue described in Bug 32448. Test plan: 1) Confirm the erratic DataTable behaviour outlined above 2) Apply this patch and reload all JS assets (hit CTRL-F5) 3) Confirm that you now see the correct input text field for the 'Barcode' column 4) Confirm that you can search for barcodes or in any other column successfully 5) Try toggling the visibility of the columns and making as many search variations as possible -- it should all now work without any glitches! For extra credit ;-) you can also test the 'Other holdings' table by setting the SeparateHoldings SysPref to 'Separate'. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>		2023-03-31 19:19:27 +02:00
..
background_jobs	Bug 32933: Use val() instead of attr("value") when getting field values with jQuery	2023-02-21 09:11:17 -03:00
catalogue	Bug 33070: Remove use of can_edit_items	2023-03-17 09:59:02 -03:00
csv_headers
mana
modals	Bug 31028: (follow-up) Consistently style help-block	2023-03-06 11:23:17 -03:00
str	Bug 30642: (follow-up) Change sql and adapt for translations	2023-02-10 11:07:58 -03:00
virtualshelves/merge
about-team.inc
accounts.inc
acquisitions-add-to-basket.inc
acquisitions-menu.inc
acquisitions-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
acquisitions-toolbar.inc
additional-fields-display.inc
additional-fields-entry.inc
admin-items-search-field-form.inc
admin-menu.inc
adv-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
auth-finder-search.inc
auth-two-factor.inc
authorities-search-results.inc
authorities-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
authorities-toolbar.inc
authorities.inc
authorities_js.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
authority-detail-modal.inc
av-build-dropbox.inc
biblio-title-head.inc
biblio-title.inc	Bug 31028: Update patron and biblio includes to remove whitespace	2023-03-06 11:23:17 -03:00
biblio-view-menu.inc
blocked-fines.inc
blocking_errors.inc
branch-selector.inc
budget_planning.inc
budgets-active-currency.inc
budgets-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
budgets-admin-toolbar.inc
calendar.inc
cat-menu.inc	Bug 31028: Add ability to report concerns from the staff interface	2023-03-06 11:23:17 -03:00
cat-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
cat-toolbar.inc	Bug 31028: Add ability to report concerns from the staff interface	2023-03-06 11:23:17 -03:00
catalog-strings.inc
cataloging-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
catalogue-search-box.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
cateditor-ui.inc	Bug 19361: (QA follow-up) Make sure "Not an authorised value" appears in the pull down	2023-03-20 09:39:55 -03:00
cateditor-widgets-marc21.inc
category-out-of-age-limit.inc
chart.inc
checkin-search-box.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
checkin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
checkouts-table-footer.inc
checkouts-table.inc
circ-menu.inc	Bug 32976: Add permission check on Add/Edit controls for patron images	2023-03-31 18:45:59 +02:00
circ-nav.inc	Bug 30624: Add loggedinlibrary permission and DB update	2023-03-13 15:22:59 -03:00
circ-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
cities-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
clubs-table.inc
columns_settings.inc	Bug 32447: Fix DataTable filtering when hidden columns are in place	2023-03-31 19:19:27 +02:00
contracts-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
country-list.inc
currencies-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
datatables.inc
date-format.inc
delimiter_text.inc
desks-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
doc-head-close-receipt.inc
doc-head-close.inc
doc-head-open.inc
empty_line.inc
erm-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
facets.inc
filter-orders.inc
form-blocks.inc
format_price.inc
greybox.inc
guided-reports-view.inc
header.inc	Bug 30624: Add loggedinlibrary permission and DB update	2023-03-13 15:22:59 -03:00
holds_table.inc	Bug 25856: Add suspend class to tr's of suspended holds	2023-03-17 09:59:03 -03:00
home-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
html_helpers.inc	Bug 19361: (QA follow-up) Make sure "Not an authorised value" appears in the pull down	2023-03-20 09:39:55 -03:00
i18n.inc
ill-availability-table.inc
ill-list-table-strings.inc	Bug 32525: Standardize labels on list of ILL requests and ILL request details page	2023-02-24 16:59:16 -03:00
ill-list-table.inc	Bug 32576: Move page-section outside of table include	2023-03-02 09:37:42 -03:00
ill-toolbar.inc
installer-doc-head-close.inc
installer-intranet-bottom.inc
installer-strings.inc
intranet-bottom.inc
intranetstylesheet.inc
job_progress.inc
js-biblio-format.inc
js-date-format.inc	Bug 30310: Fix date_to_rfc3339	2023-01-31 10:19:46 -03:00
js-patron-format-address.inc
js-patron-format.inc
js-patron-get-age.inc
js_includes.inc
keyboard_shortcuts.inc
labels-toolbar.inc
langmenu-staff-top.inc
last-borrower.inc
letters-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
member-alt-address-style.inc
member-alt-contact-style.inc
member-display-address-style.inc
member-display-alt-address-style.inc
member-main-address-style.inc
member-search-box.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
members-toolbar.inc
merge-record.inc	Bug 33278: Correct JS for activating default tab on various pages	2023-03-27 11:51:00 +02:00
messaging-preference-form.inc	Bug 32492: (follow-up) Add missing HTML filters	2023-03-06 14:45:23 -03:00
modal-claims.inc
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc
password_check.inc
patron-age.inc
patron-article-requests.inc	Bug 32679: Use different CSS classes for titles of article requests in staff interface	2023-03-06 14:45:24 -03:00
patron-restrictions-tab.inc
patron-return-claims.inc
patron-search-box.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
patron-search-header.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
patron-search.inc	Bug 32675: Fix guarantor selection when simple quote present	2023-03-10 10:16:37 -03:00
patron-title.inc	Bug 33266: Fix missing space in patron title	2023-03-20 09:39:52 -03:00
patron-toolbar.inc
patron_messages.inc	Bug 32373: Show patron restriction date	2023-03-31 12:34:13 +02:00
patroncards-errors.inc
patroncards-toolbar.inc
patronfields.inc	Bug 32770: Restore phone	2023-02-22 15:05:24 -03:00
patrons-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
permissions.inc	Bug 30624: Add loggedinlibrary permission and DB update	2023-03-13 15:22:59 -03:00
popup-bottom.inc
pos-menu.inc
prefs-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
prefs-menu.inc	Bug 32546: Move ILL system preferences into their own tab in administration	2023-02-03 10:30:17 -03:00
recalls.inc
relatives-issues-table.inc
renew-search-box.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
renew_results.inc
renew_strings.inc
reports-menu.inc
reports-toolbar.inc
resort_form.inc
restriction-types.inc
rotating-collections-toolbar.inc
search_indexes.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
select2.inc
serials-advsearch.inc	Bug 32771: Standardize structure around action fieldsets in serials	2023-03-31 12:30:37 +02:00
serials-menu.inc
serials-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
serials-toolbar.inc
shortcut.inc
slip-print.inc
stockrotation-toolbar.inc
sub-header.inc
subscriptions-search.inc	Bug 32771: Standardize structure around action fieldsets in serials	2023-03-31 12:30:37 +02:00
subtype_limits.inc
subtypes_unimarc.inc
suggestions-add-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
tools-item-action.inc
tools-menu.inc
tools-nomatch-action.inc
tools-overlay-action.inc
transaction_types.inc
transfer_reasons.inc
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc
waiting_holds.inc	Bug 32503: Use first cancellation for date ordering	2023-02-27 11:37:12 -03:00
wysiwyg-systempreferences.inc
xslt-handler.inc
z3950-admin-search.inc	Bug 32683: Convert header search tabs to Bootstrap	2023-03-10 12:04:08 -03:00
z3950_search.inc