Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent/Circulation
History
Jonathan Druart 02e2a4261c Bug 17679: C4::Circulation - Remove unused GetItemIssues 
Ready for an archaeology course?

C4::Circulation::GetItemIssues is only used once, from
catalogue/issuehistory.pl
This call has been added by
  commit 95d6452462
    Adding some more information on issuehistory.
which says "Adding itemnumber to issuehistory.pl API so that one could search
for issuehistory of a specific item."
So it added the ability to see the item issue history but did not
provide a way to access it via the interface.
It's ok so far but this subroutine is broken since
  commit aa114f5349
    Bug 5549 : Only use DateTime for issues table
because of this change:
-    my $today = C4::Dates->today('iso');
+    my $today = DateTime->now( time_zome => C4::Context->tz);

I let you catch the typo ;)
And since this commit the subroutine explodes with "The following
parameter was passed in the call to DateTime::from_epoch but was not
listed in the validation options: time_zome"

Since it has never been raised by someone and that the feature is
hidden, I'd recommend to simply remove it.

Note that the "Checked out from" column would have been wrong even if we
fixed all the previous issue.

Test plan:
Just dig into the code and confirm what this commit message tells

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Looks fine for me.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-12-28 13:52:24 +00:00
..
IssuingRules Bug 17599: Move C4::Circulation::GetIssuingRule to Koha::IssuingRules->get_effective_issuing_rule 2016-11-15 15:41:43 +00:00
AnonymiseIssueHistory.t
Branch.t Bug 17599: Move C4::Circulation::GetIssuingRule to Koha::IssuingRules->get_effective_issuing_rule 2016-11-15 15:41:43 +00:00
CalcDateDue.t
CalcFine.t
CheckIfIssuedToPatron.t Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings 2016-11-18 14:02:49 +00:00
CheckValidBarcode.t
dateexpiry.t
GetHardDueDate.t Bug 17599: Move C4::Circulation::GetIssuingRule to Koha::IssuingRules->get_effective_issuing_rule 2016-11-15 15:41:43 +00:00
GetPendingOnSiteCheckouts.t Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues 2016-12-23 11:46:20 +00:00
GetTopIssues.t
IsItemIssued.t Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings 2016-11-18 14:02:49 +00:00
issue.t Bug 17679: C4::Circulation - Remove unused GetItemIssues 2016-12-28 13:52:24 +00:00
MarkIssueReturned.t Bug 17430: Make MarkIssueReturned.t create its own data 2016-10-17 22:55:37 +00:00
NoIssuesChargeGuarantees.t Bug 17633: Do not call set_preference from tests 2016-11-16 15:31:01 +00:00
OfflineOperation.t
Returns.t Bug 17633: (QA followup) Remove unneeded warnings 2016-11-16 15:31:01 +00:00
SwitchOnSiteCheckouts.t Bug 15758: (QA followup) Remove leftover reference to C4::Branch 2016-09-09 14:46:22 +00:00
TooMany.t Bug 17599: Make the tests pass 2016-11-15 15:54:24 +00:00
transfers.t Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings 2016-11-18 14:02:49 +00:00