Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
Liz Rea c2015c7103 Bug 6841 - A member with cataloging permissions cannot change branches (when independent branches is set on) 
This patch does a couple of things.

1. Changes permission over all to set branch printer (change branch/Set Library) from "circulation" privileges to "view catalogue" permissions. Reasoning: anyone who has privileges to view catalogue could reasonably be expected to perhaps need to change the set branch, but you might have people who don't have circulate permissions who need to change the branch, centralized cataloguing, for example. Those people would never circ and wouldn't need circ privileges, but *would* need to be able to change the set branch.
2. Changes the template flags to see the "Set Library" link with independent branches set from "manage users" to "manage users or edit catalogue." Reasoning: even with indy branches on, there might be reasons for catalogers to be able to change the set branch (that reason was the impetus for this patch in the first place).

To test:
Create a user with only "View Catalogue" Permissions (no circulate permissions), that user should be able to change set library with Independent branches OFF.

With independent branches on, give a user edit catalogue permissions. That user should be able to change set library.

I want to add that this patch was specifically written in response to chris_n's bug report. It may not be practical for these changes to be in mainline, but I haven't thought of any reasons why it would be explicitly bad. That doesn't mean there aren't some, though.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-09-14 21:44:03 +12:00
..
virtualshelves/merge Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
acquisitions-add-to-basket.inc Bug 5072 : Template changes 2011-08-04 13:53:34 +12:00
acquisitions-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
acquisitions-search.inc Bug 6721 - improve searching in the acquisitions system 2011-08-26 11:34:27 +12:00
acquisitions-toolbar.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
additem-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
admin-menu.inc BUG6389 Administration menu like Tools menu 2011-06-10 14:33:59 +12:00
auth-finder-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
authorities-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
authorities-toolbar.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
background-job.inc Bug 6084: Follow up - fix more translation markers 2011-04-07 21:46:47 +12:00
biblio-default-view.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
biblio-view-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
budgetperiods-admin.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
budgets-active-currency.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
budgets-admin-search.inc Fix for Bug 6458 - incorrect parsing result in translation processing 2011-09-14 10:09:04 +12:00
budgets-admin-toolbar.inc Bug 6158: Permissions scoped wrong for T::T 2011-04-12 09:16:27 +12:00
calendar.inc Bug 6203 : Fix for numbering pattern not showing 2011-04-20 14:35:52 +12:00
cat-menu.inc Warning: Big Commit. Fixing Virtual Shelves 2007-12-23 14:31:14 -06:00
cat-search.inc Bug 5009 : Turning off autocomplete 2011-08-02 12:24:45 +12:00
cat-toolbar.inc Bug 6325 Bib detail - z39.50 button functionality should be under "Edit" menu 2011-08-01 13:48:02 +12:00
cataloging-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
cataloging-toolbar.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
checkin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
checkouts-table-footer.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
circ-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
circ-menu.tt Bug 3498 [ENH] Allow Partial Payment of Fines 2011-09-13 08:40:49 +12:00
circ-search.inc Bug 5009 : Turning off autocomplete 2011-08-02 12:24:45 +12:00
circ-toolbar.inc Fix for Bug 6501 - missing scroll bar when updating child 2011-06-20 11:51:22 +12:00
cities-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
contracts-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
currencies-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
date-format.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
dictionary-toolbar.inc Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing") 2008-10-22 13:34:36 -05:00
doc-head-close-receipt.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
doc-head-close.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
doc-head-open.inc Fix for Bug 6186 - Change to DOCTYPE declaration causing validation errors 2011-04-15 10:15:32 +12:00
error-messages.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
facets.inc Fix for Bug 6743 - displayFacetCount not working 2011-08-18 20:51:47 +12:00
favicon.ico
file-upload.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
greybox.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
guided-reports-view.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
header.inc Bug 6841 - A member with cataloging permissions cannot change branches (when independent branches is set on) 2011-09-14 21:44:03 +12:00
help-bottom.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
help-top.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
hold-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
installer-doc-head-close.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
intranet-bottom.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
labels-batches-toolbar.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
labels-menu.inc [14/40] Work on batch management interface. 2009-09-01 15:50:05 -04:00
labels-new-toolbar.inc [9/40] Work on template interface. 2009-09-01 15:48:50 -04:00
labels-toolbar.inc [31/40] Misc bugfixes and cosmetic cleanup. 2009-09-01 15:53:18 -04:00
letters-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
mainmenu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
members-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
members-toolbar.inc Fix for Bug 6501 - missing scroll bar when updating child 2011-06-20 11:51:22 +12:00
messaging-preference-form.inc Fix for Bug 6726 - When SMS is enabled the messaging table is misaligned 2011-08-23 15:14:50 +12:00
page-numbers.inc Fix for Bug 6216, Search results pagination links broken 2011-04-21 09:15:40 +12:00
patron-search-box.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
patron-search.inc Bug 5009 : Turning off autocomplete 2011-08-02 12:24:45 +12:00
patron-toolbar.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
patroncards-batches-toolbar.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
patroncards-menu.inc bug 4101 patroncards changed to patron card creator 2010-02-03 15:10:05 -05:00
patroncards-toolbar.inc [18/30] Patron Card Creator toolbar 2010-01-11 18:21:14 -05:00
patrons-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
popup-bottom.inc
prefs-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
prefs-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
printers-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
reports-menu.inc Follow Up Bug 5869 Fix String Errors 2011-03-17 14:33:11 +13:00
resort_form.inc Bug 6662: Remove Dewey Specific References in Sort 2011-08-27 07:50:43 +12:00
roadtype-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
search_indexes.inc comma fix 2011-04-13 08:34:15 +12:00
serials-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
serials-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
serials-toolbar.inc Bug 6305: Subscriptions can not be edited 2011-07-06 08:32:04 +12:00
stopwords-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
subtypes_unimarc.inc Translation end. 2007-12-20 18:36:40 -06:00
suggestions-add-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
sysprefs-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
tools-item-action.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
tools-menu.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
tools-nomatch-action.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
tools-overlay-action.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
virtualshelves-toolbar.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
z3950-admin-search.inc Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00