Jonathan Druart
b64e6be1c4
From C4::Koha::GetAuthorisedValues # TODO: the "selected" feature should be replaced by a utility function # somewhere else, it doesn't belong in here. For starters it makes # caching much more complicated. Or just let the UI logic handle it, it's # what it's for. Indeed, it's not a job for a subroutine, the template should take care of that. Note that a perf gain could be won with this patch \o/ Test plan: - Edit an itemtype and check the value of the "Search category" dropdown list - Edit a patron attribute type and check the value of the "Class" dropdown list - Detail for a catalogue record, the Status column should be correctly populated if items are damaged and/or lost - Item details for a catalogue record, the lost, damaged and withdrawn value should be correctly displayed - Edit a patron, the "street type" should be correctly selected - Create a patron attribute type linked to an authorised value list. - Edit a patron, set a value for this attribute, edit it again. The correct value should be selected. - Search for subscriptions. The 'Location' dropdown list should behave correctly (select the entry you have choosen before, etc.) - Edit a subscription, the location dropdown list should select the correct value. - Edit and view a suggestion with a 'reason for suggestion' set (you should have at least 1 OPAC_SUG AV defined) Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
431 lines
15 KiB
Perl
Executable file
431 lines
15 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
# Parts Copyright 2010 Biblibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 NAME
|
|
|
|
serials-edit.pl
|
|
|
|
=head1 Parameters
|
|
|
|
=over 4
|
|
|
|
=item op
|
|
op can be :
|
|
* modsubscriptionhistory :to modify the subscription history
|
|
* serialchangestatus :to modify the status of this subscription
|
|
|
|
=item subscriptionid
|
|
|
|
=item user
|
|
|
|
=item histstartdate
|
|
|
|
=item enddate
|
|
|
|
=item recievedlist
|
|
|
|
=item missinglist
|
|
|
|
=item opacnote
|
|
|
|
=item librariannote
|
|
|
|
=item serialid
|
|
|
|
=item serialseq
|
|
|
|
=item planneddate
|
|
|
|
=item notes
|
|
|
|
=item status
|
|
|
|
=back
|
|
|
|
=cut
|
|
|
|
use strict;
|
|
use warnings;
|
|
use CGI qw ( -utf8 );
|
|
use Encode qw( decode is_utf8 );
|
|
use C4::Auth;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Koha;
|
|
use C4::Output;
|
|
use C4::Context;
|
|
use C4::Serials;
|
|
use C4::Search qw/enabled_staff_search_views/;
|
|
use Koha::DateUtils;
|
|
|
|
use List::MoreUtils qw/uniq/;
|
|
|
|
my $query = CGI->new();
|
|
my $dbh = C4::Context->dbh;
|
|
my @serialids = $query->param('serialid');
|
|
my @serialseqs = $query->param('serialseq');
|
|
my @planneddates = $query->param('planneddate');
|
|
my @publisheddates = $query->param('publisheddate');
|
|
my @publisheddatetexts = $query->param('publisheddatetext');
|
|
my @status = $query->param('status');
|
|
my @notes = $query->param('notes');
|
|
my @subscriptionids = $query->param('subscriptionid');
|
|
my $op = $query->param('op');
|
|
if ( scalar(@subscriptionids) == 1 && index( $subscriptionids[0], q|,| ) > 0 ) {
|
|
@subscriptionids = split( /,/, $subscriptionids[0] );
|
|
}
|
|
my @errors;
|
|
my @errseq;
|
|
|
|
# If user comes from subscription details
|
|
unless (@serialids) {
|
|
my $serstatus = $query->param('serstatus');
|
|
my @statuses = split ',', $serstatus;
|
|
if ($serstatus) {
|
|
foreach my $subscriptionid (@subscriptionids) {
|
|
my @tmpser = GetSerials2( $subscriptionid, \@statuses );
|
|
push @serialids, map { $_->{serialid} } @tmpser;
|
|
}
|
|
}
|
|
}
|
|
|
|
unless ( @serialids ) {
|
|
my $string =
|
|
'serials-collection.pl?subscriptionid=' . join ',', uniq @subscriptionids;
|
|
$string =~ s/,$//;
|
|
|
|
print $query->redirect($string);
|
|
}
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => 'serials/serials-edit.tt',
|
|
query => $query,
|
|
type => 'intranet',
|
|
authnotrequired => 0,
|
|
flagsrequired => { serials => 'receive_serials' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my @serialdatalist;
|
|
my %processedserialid;
|
|
|
|
my $today = output_pref( { dt => dt_from_string, dateonly => 1 } );
|
|
|
|
foreach my $serialid (@serialids) {
|
|
|
|
#filtering serialid for duplication
|
|
#NEW serial should appear only once and are created afterwards
|
|
if ( $serialid
|
|
&& $serialid =~ /^[0-9]+$/
|
|
&& !$processedserialid{$serialid} )
|
|
{
|
|
my $serinfo = GetSerialInformation($serialid); #TODO duplicates work done by GetSerials2 above
|
|
|
|
for my $d ( qw( publisheddate planneddate )){
|
|
if ( $serinfo->{$d} =~m/^00/ ) {
|
|
$serinfo->{$d} = q{};
|
|
}
|
|
else {
|
|
$serinfo->{$d} = output_pref( { dt => dt_from_string( $serinfo->{$d} ), dateonly => 1 } );
|
|
}
|
|
}
|
|
$serinfo->{arriveddate} = $today;
|
|
|
|
$serinfo->{'editdisable'} = (
|
|
(
|
|
HasSubscriptionExpired( $serinfo->{subscriptionid} )
|
|
&& $serinfo->{'status1'}
|
|
)
|
|
|| $serinfo->{'cannotedit'}
|
|
);
|
|
$serinfo->{editdisable} = 0 if C4::Auth::haspermission( C4::Context->userenv->{id}, { serials => 'receive_serials' } );
|
|
$serinfo->{editdisable} ||= ($serinfo->{status8} and $serinfo->{closed});
|
|
push @serialdatalist, $serinfo;
|
|
$processedserialid{$serialid} = 1;
|
|
}
|
|
}
|
|
my $biblio = GetBiblioData( $serialdatalist[0]->{'biblionumber'} );
|
|
|
|
my @newserialloop;
|
|
my @subscriptionloop;
|
|
|
|
# check, for each subscription edited, that we have an empty item line if applicable for the subscription
|
|
my %processedsubscriptionid;
|
|
foreach my $subscriptionid (@subscriptionids) {
|
|
|
|
#Do not process subscriptionid twice if it was already processed.
|
|
if ( $subscriptionid && !$processedsubscriptionid{$subscriptionid} )
|
|
{
|
|
my $cell;
|
|
if ( $serialdatalist[0]->{'serialsadditems'} ) {
|
|
|
|
#Create New empty item
|
|
$cell =
|
|
PrepareItemrecordDisplay( $serialdatalist[0]->{'biblionumber'},
|
|
'', GetSubscription($subscriptionid) );
|
|
$cell->{serialsadditems} = 1;
|
|
}
|
|
$cell->{'subscriptionid'} = $subscriptionid;
|
|
$cell->{biblionumber} = $serialdatalist[0]->{'biblionumber'};
|
|
$cell->{'itemid'} = 'NNEW';
|
|
$cell->{'serialid'} = 'NEW';
|
|
$cell->{'issuesatonce'} = 1;
|
|
$cell->{arriveddate} = $today;
|
|
|
|
push @newserialloop, $cell;
|
|
push @subscriptionloop,
|
|
{
|
|
'subscriptionid' => $subscriptionid,
|
|
'abouttoexpire' => abouttoexpire($subscriptionid),
|
|
'subscriptionexpired' => HasSubscriptionExpired($subscriptionid),
|
|
};
|
|
$processedsubscriptionid{$subscriptionid} = 1;
|
|
}
|
|
}
|
|
$template->param( newserialloop => \@newserialloop );
|
|
$template->param( subscriptions => \@subscriptionloop );
|
|
|
|
if ( $op and $op eq 'serialchangestatus' ) {
|
|
|
|
# Convert serialseqs to UTF-8 to prevent encoding problems
|
|
foreach my $seq (@serialseqs) {
|
|
$seq = Encode::decode('UTF-8', $seq) unless Encode::is_utf8($seq);
|
|
}
|
|
|
|
my $newserial;
|
|
for ( my $i = 0 ; $i <= $#serialids ; $i++ ) {
|
|
my ($plan_date, $pub_date);
|
|
|
|
if (defined $planneddates[$i] && $planneddates[$i] ne 'XXX') {
|
|
$plan_date = eval { output_pref( { dt => dt_from_string( $planneddates[$i] ), dateonly => 1, dateformat => 'iso' } ); };
|
|
}
|
|
if (defined $publisheddates[$i] && $publisheddates[$i] ne 'XXX') {
|
|
$pub_date = eval { output_pref( { dt => dt_from_string( $publisheddates[$i] ), dateonly => 1, dateformat => 'iso' } ); };
|
|
}
|
|
|
|
if ( $serialids[$i] && $serialids[$i] eq 'NEW' ) {
|
|
if ( $serialseqs[$i] ) {
|
|
|
|
#IF newserial was provided a name Then we have to create a newSerial
|
|
### FIXME if NewIssue is modified to use subscription biblionumber, then biblionumber would not be useful.
|
|
$newserial = NewIssue(
|
|
$serialseqs[$i],
|
|
$subscriptionids[0],
|
|
$serialdatalist[0]->{'biblionumber'},
|
|
$status[$i],
|
|
$plan_date,
|
|
$pub_date,
|
|
$publisheddatetexts[$i],
|
|
$notes[$i]
|
|
);
|
|
}
|
|
}
|
|
elsif ( $serialids[$i] ) {
|
|
ModSerialStatus(
|
|
$serialids[$i],
|
|
$serialseqs[$i],
|
|
$plan_date,
|
|
$pub_date,
|
|
$publisheddatetexts[$i],
|
|
$status[$i],
|
|
$notes[$i]
|
|
);
|
|
}
|
|
}
|
|
my @moditems = $query->param('moditem');
|
|
if ( scalar(@moditems) ) {
|
|
my @tags = $query->param('tag');
|
|
my @subfields = $query->param('subfield');
|
|
my @field_values = $query->param('field_value');
|
|
my @serials = $query->param('serial');
|
|
my @bibnums = $query->param('bibnum');
|
|
my @itemid = $query->param('itemid');
|
|
my @ind_tag = $query->param('ind_tag');
|
|
my @indicator = $query->param('indicator');
|
|
|
|
#Rebuilding ALL the data for items into a hash
|
|
# parting them on $itemid.
|
|
my %itemhash;
|
|
my $countdistinct;
|
|
my $range = scalar(@itemid);
|
|
for ( my $i = 0 ; $i < $range ; $i++ ) {
|
|
unless ( $itemhash{ $itemid[$i] } ) {
|
|
if ( $serials[$countdistinct]
|
|
&& $serials[$countdistinct] ne "NEW" )
|
|
{
|
|
$itemhash{ $itemid[$i] }->{'serial'} =
|
|
$serials[$countdistinct];
|
|
}
|
|
else {
|
|
$itemhash{ $itemid[$i] }->{'serial'} = $newserial;
|
|
}
|
|
$itemhash{ $itemid[$i] }->{'bibnum'} = $bibnums[$countdistinct];
|
|
$countdistinct++;
|
|
}
|
|
push @{ $itemhash{ $itemid[$i] }->{'tags'} }, $tags[$i];
|
|
push @{ $itemhash{ $itemid[$i] }->{'subfields'} }, $subfields[$i];
|
|
push @{ $itemhash{ $itemid[$i] }->{'field_values'} },
|
|
$field_values[$i];
|
|
push @{ $itemhash{ $itemid[$i] }->{'ind_tag'} }, $ind_tag[$i];
|
|
push @{ $itemhash{ $itemid[$i] }->{'indicator'} }, $indicator[$i];
|
|
}
|
|
foreach my $item ( keys %itemhash ) {
|
|
|
|
# Verify Itemization is "Valid", i.e. serial status is Arrived or Missing
|
|
my $index = -1;
|
|
for ( my $i = 0 ; $i < scalar(@serialids) ; $i++ ) {
|
|
if (
|
|
$itemhash{$item}->{serial} eq $serialids[$i]
|
|
|| ( $itemhash{$item}->{serial} == $newserial
|
|
&& $serialids[$i] eq 'NEW' )
|
|
) {
|
|
$index = $i
|
|
}
|
|
}
|
|
if ( $index >= 0 && $status[$index] == 2 ) {
|
|
my $xml = TransformHtmlToXml(
|
|
$itemhash{$item}->{'tags'},
|
|
$itemhash{$item}->{'subfields'},
|
|
$itemhash{$item}->{'field_values'},
|
|
$itemhash{$item}->{'indicator'},
|
|
$itemhash{$item}->{'ind_tag'}
|
|
);
|
|
|
|
# warn $xml;
|
|
my $bib_record = MARC::Record::new_from_xml( $xml, 'UTF-8' );
|
|
if ( $item =~ /^N/ ) {
|
|
|
|
#New Item
|
|
|
|
# if autoBarcode is set to 'incremental', calculate barcode...
|
|
my ( $barcodetagfield, $barcodetagsubfield ) =
|
|
GetMarcFromKohaField(
|
|
'items.barcode',
|
|
GetFrameworkCode(
|
|
$serialdatalist[0]->{'biblionumber'}
|
|
)
|
|
);
|
|
if ( C4::Context->preference('autoBarcode') eq
|
|
'incremental' )
|
|
{
|
|
if (
|
|
!(
|
|
$bib_record->field($barcodetagfield)
|
|
&& $bib_record->field($barcodetagfield)->subfield($barcodetagsubfield)
|
|
)
|
|
)
|
|
{
|
|
my $sth_barcode = $dbh->prepare(
|
|
'select max(abs(barcode)) from items');
|
|
$sth_barcode->execute;
|
|
my ($newbarcode) = $sth_barcode->fetchrow;
|
|
|
|
# OK, we have the new barcode, add the entry in MARC record # FIXME -> should be using barcode plugin here.
|
|
$bib_record->field($barcodetagfield)
|
|
->update( $barcodetagsubfield => ++$newbarcode );
|
|
}
|
|
}
|
|
|
|
# check for item barcode # being unique
|
|
my $exists;
|
|
if (
|
|
$bib_record->subfield(
|
|
$barcodetagfield, $barcodetagsubfield
|
|
)
|
|
)
|
|
{
|
|
$exists = GetItemnumberFromBarcode(
|
|
$bib_record->subfield(
|
|
$barcodetagfield, $barcodetagsubfield
|
|
)
|
|
);
|
|
}
|
|
|
|
# push @errors,"barcode_not_unique" if($exists);
|
|
# if barcode exists, don't create, but report The problem.
|
|
if ($exists) {
|
|
push @errors, 'barcode_not_unique';
|
|
push @errseq, { serialseq => $serialseqs[$index] };
|
|
}
|
|
else {
|
|
my ( $biblionumber, $bibitemnum, $itemnumber ) =
|
|
AddItemFromMarc( $bib_record,
|
|
$itemhash{$item}->{bibnum} );
|
|
AddItem2Serial( $itemhash{$item}->{serial},
|
|
$itemnumber );
|
|
}
|
|
}
|
|
else {
|
|
|
|
#modify item
|
|
my ( $oldbiblionumber, $oldbibnum, $itemnumber ) =
|
|
ModItemFromMarc( $bib_record,
|
|
$itemhash{$item}->{'bibnum'}, $item );
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
if ( @errors ) {
|
|
$template->param( Errors => 1 );
|
|
if ( @errseq ) {
|
|
$template->param( barcode_not_unique => 1, errseq => \@errseq );
|
|
}
|
|
}
|
|
else {
|
|
my $redirect = 'serials-collection.pl?';
|
|
$redirect .= join( '&', map { 'subscriptionid=' . $_ } @subscriptionids );
|
|
print $query->redirect($redirect);
|
|
}
|
|
}
|
|
my $location = $serialdatalist[0]->{'location'};
|
|
my $default_bib_view = get_default_view();
|
|
|
|
$template->param(
|
|
serialsadditems => $serialdatalist[0]->{'serialsadditems'},
|
|
callnumber => $serialdatalist[0]->{'callnumber'},
|
|
internalnotes => $serialdatalist[0]->{'internalnotes'},
|
|
bibliotitle => $biblio->{'title'},
|
|
biblionumber => $serialdatalist[0]->{'biblionumber'},
|
|
serialslist => \@serialdatalist,
|
|
default_bib_view => $default_bib_view,
|
|
location => $location,
|
|
(uc(C4::Context->preference("marcflavour"))) => 1
|
|
|
|
);
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|
|
|
|
sub get_default_view {
|
|
my $defaultview = C4::Context->preference('IntranetBiblioDefaultView');
|
|
my %views = C4::Search::enabled_staff_search_views();
|
|
if ( $defaultview eq 'isbd' && $views{can_view_ISBD} ) {
|
|
return 'ISBDdetail';
|
|
}
|
|
elsif ( $defaultview eq 'marc' && $views{can_view_MARC} ) {
|
|
return 'MARCdetail';
|
|
}
|
|
elsif ( $defaultview eq 'labeled_marc' && $views{can_view_labeledMARC} ) {
|
|
return 'labeledMARCdetail';
|
|
}
|
|
return 'detail';
|
|
}
|