Main Koha release repository https://koha-community.org
Find a file
Kyle M Hall c2f1106f2e
Bug 24802: Updating holds can cause suspensions to apply to wrong hold
On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to!

Test Plan:
1) Place two holds on a record
2) Check in an item and trap it for the first hold
3) Now that one hold is waiting and the other is not, attempt to set
   a suspension date using the "Update hold(s)" button
4) Note your hold does not get suspended!
5) Apply this patch
6) Restart all the things!
7) Repeat steps 1-3
8) Your hold should now be suspended!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-03-06 09:56:40 +00:00
acqui Bug 21746: Remove NO_LIBRARY_SET 2020-03-02 10:20:42 +00:00
admin Bug 21746: Remove NO_LIBRARY_SET 2020-03-02 10:20:42 +00:00
api/v1 Bug 22615: Add endpoint for getting one ill backend 2020-03-05 13:03:40 +00:00
authorities Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
basket Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
C4 Bug 24719: Remove use of CGI object in C4::Context::set_remote_address() 2020-03-06 09:53:08 +00:00
catalogue Bug 21746: Remove NO_LIBRARY_SET 2020-03-02 10:20:42 +00:00
cataloguing Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
circ Bug 21746: Remove NO_LIBRARY_SET 2020-03-02 10:20:42 +00:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 23975: (QA follow-up) Add another plugin source 2020-03-03 09:22:39 +00:00
docs Koha 19.12 - Dobbie is a free elf... 2019-12-02 17:13:15 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 23975: (QA follow-up) Add another plugin source 2020-03-03 09:22:39 +00:00
ill Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
installer Bug 24369: DBRev 19.12.00.036 2020-03-05 13:01:54 +00:00
Koha Bug 22615: Fix perlcritic 2020-03-05 13:03:46 +00:00
koha-tmpl Bug 24802: Updating holds can cause suspensions to apply to wrong hold 2020-03-06 09:56:40 +00:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 24081: Add discount action to boraccount 2020-03-04 14:46:22 +00:00
misc Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
offline_circ Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
opac Bug 24545: Fix newly added files 2020-02-24 13:31:27 +00:00
patron_lists
patroncards Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
plugins Bug 23975: (follow-up) Don't rely on save_to being present 2020-03-03 09:19:04 +00:00
pos Bug 24492: (RM follow-up) Redirect to correct page after cashup 2020-03-05 14:16:58 +00:00
reports Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
reserve Bug 24802: Updating holds can cause suspensions to apply to wrong hold 2020-03-06 09:56:40 +00:00
reviews
rotating_collections
serials Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
services
skel
suggestion Bug 23594: Restore previous view after delete or update itemtype 2020-01-30 10:56:57 +00:00
svc Bug 22529: Use new C4::Auth::haspermission from svc/members/search 2020-03-04 16:14:32 +00:00
t Bug 24369: Add CORS support to the API 2020-03-05 12:59:50 +00:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
tools Bug 21746: Remove NO_LIBRARY_SET 2020-03-02 10:20:42 +00:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 24545: Fix newly added files 2020-02-24 13:31:27 +00:00
.editorconfig
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
.htaccess
.mailmap
.scss-lint.yml
about.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
changelanguage.pl
cpanfile Bug 24693: Move GD from recommends to requires in cpanfile 2020-02-24 13:18:08 +00:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 24369: DBRev 19.12.00.036 2020-03-05 13:01:54 +00:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 19735: Move Perl deps definitions into a cpanfile 2020-02-12 16:33:02 +00:00
MANIFEST.SKIP
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
README
README.md
README.robots
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo