Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/admin/branches.pl
Owen Leonard 6af71b5f8d Fix for Bug 3722 - Branch deletion results in incorrect message 
A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:46:31 -04:00

419 lines
14 KiB
Perl
Executable file
Raw Blame History

#!/usr/bin/perl
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
=head1 branches.pl
FIXME: individual fields in branch address need to be exported to templates,
in order to fix bug 180; need to notify translators
FIXME: looped html (e.g., list of checkboxes) need to be properly
TMPL_LOOP'ized; doing this properly will fix bug 130; need to
notify translators
FIXME: need to implement the branch categories stuff
FIXME: there are too many TMPL_IF's; the proper way to do it is to have
separate templates for each individual action; need to notify
translators
FIXME: there are lots of error messages exported to the template; a lot
of these should be converted into exported booleans / counters etc
so that the error messages can be localized; need to notify translators
Finlay working on this file from 26-03-2002
Reorganising this branches admin page.....
=cut
use strict;
use warnings;
use CGI;
use C4::Auth;
use C4::Context;
use C4::Output;
use C4::Koha;
use C4::Branch;
# Fixed variables
my $script_name = "/cgi-bin/koha/admin/branches.pl";
################################################################################
# Main loop....
my $input = new CGI;
my $branchcode = $input->param('branchcode');
my $branchname = $input->param('branchname');
my $categorycode = $input->param('categorycode');
my $op = $input->param('op') || '';
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
{
template_name => "admin/branches.tmpl",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => { parameters => 1},
debug => 1,
}
);
$template->param(
script_name => $script_name,
action => $script_name,
);
$template->param( ($op || 'else') => 1 );
if ( $op eq 'add' ) {
# If the user has pressed the "add new branch" button.
$template->param( 'heading-branches-add-branch-p' => 1 );
editbranchform($branchcode,$template);
}
elsif ( $op eq 'edit' ) {
# if the user has pressed the "edit branch settings" button.
$template->param( 'heading-branches-add-branch-p' => 0,
'add' => 1, );
editbranchform($branchcode,$template);
}
elsif ( $op eq 'add_validate' ) {
# confirm settings change...
my $params = $input->Vars;
unless ( $params->{'branchcode'} && $params->{'branchname'} ) {
$template->param( else => 1 );
default("MESSAGE1",$template);
}
else {
my $mod_branch = 1;
if ($params->{add}) {
my ($existing) =
C4::Context->dbh->selectrow_array("SELECT count(*) FROM branches WHERE branchcode = ?", {}, $branchcode);
if ($existing > 0) {
$mod_branch = 0;
_branch_to_template($params, $template); # preserve most (FIXME) of user's input
$template->param( 'heading-branches-add-branch-p' => 1, 'add' => 1, 'ERROR1' => 1 );
}
}
if ($mod_branch) {
my $error = ModBranch($params); # FIXME: causes warnings to log on duplicate branchcode
# if error saving, stay on edit and rise error
if ($error) {
# copy input parameters back to form
# FIXME - doing this doesn't preserve any branch group selections, but good enough for now
editbranchform($branchcode,$template);
$template->param( 'heading-branches-add-branch-p' => 1, 'add' => 1, "ERROR$error" => 1 );
} else {
$template->param( else => 1);
default("MESSAGE2",$template);
}
}
}
}
elsif ( $op eq 'delete' ) {
# if the user has pressed the "delete branch" button.
# check to see if the branchcode is being used in the database somewhere....
my $dbh = C4::Context->dbh;
my $sthitems = $dbh->prepare("select count(*) from items where holdingbranch=? or homebranch=?");
my $sthborrowers = $dbh->prepare("select count(*) from borrowers where branchcode=?");
$sthitems->execute( $branchcode, $branchcode );
$sthborrowers->execute( $branchcode );
my ($totalitems) = $sthitems->fetchrow_array;
my ($totalborrowers) = $sthborrowers->fetchrow_array;
if ($totalitems && !$totalborrowers) {
$template->param( else => 1 );
default("MESSAGE10", $template);
}
elsif (!$totalitems && $totalborrowers){
$template->param( else => 1 );
default("MESSAGE11", $template);
}
elsif ($totalitems && $totalborrowers){
$template->param( else => 1 );
default("MESSAGE7", $template);
}
else {
$template->param( delete_confirm => 1 );
$template->param( branchname => $branchname );
$template->param( branchcode => $branchcode );
}
}
elsif ( $op eq 'delete_confirmed' ) {
# actually delete branch and return to the main screen....
DelBranch($branchcode);
$template->param( else => 1 );
default("MESSAGE3",$template);
}
elsif ( $op eq 'editcategory' ) {
# If the user has pressed the "add new category" or "modify" buttons.
$template->param( 'heading-branches-edit-category-p' => 1 );
editcatform($categorycode,$template);
}
elsif ( $op eq 'addcategory_validate' ) {
$template->param( else => 1 );
# confirm settings change...
my $params = $input->Vars;
unless ( $params->{'categorycode'} && $params->{'categoryname'} ) {
default("MESSAGE4",$template);
}
elsif ($input->param('add')){
# doing an add must check the code is unique
if (CheckCategoryUnique($input->param('categorycode'))){
ModBranchCategoryInfo($params);
default("MESSAGE5",$template);
}
else {
default("MESSAGE9",$template);
}
}
else {
ModBranchCategoryInfo($params);
default("MESSAGE5",$template);
}
}
elsif ( $op eq 'delete_category' ) {
# if the user has pressed the "delete branch" button.
my $message = "MESSAGE8" if CheckBranchCategorycode($categorycode);
if ($message) {
$template->param( else => 1 );
default($message,$template);
}
else {
$template->param( delete_category => 1 );
$template->param( categorycode => $categorycode );
}
}
elsif ( $op eq 'categorydelete_confirmed' ) {
# actually delete branch and return to the main screen....
DelBranchCategory($categorycode);
$template->param( else => 1 );
default("MESSAGE6",$template);
}
else {
# if no operation has been set...
default("",$template);
}
################################################################################
#
# html output functions....
sub default {
my $message = shift || '';
my $innertemplate = shift or return;
$innertemplate->param($message => 1) if $message;
$innertemplate->param(
'heading-branches-p' => 1,
);
branchinfotable("",$innertemplate);
}
sub editbranchform {
my ($branchcode,$innertemplate) = @_;
# initiate the scrolling-list to select the printers
my $printers = GetPrinters();
my @printerloop;
my $data;
my $oldprinter = "";
if ($branchcode) {
$data = GetBranchInfo($branchcode);
$data = $data->[0];
# get the old printer of the branch
$oldprinter = $data->{'branchprinter'} || '';
_branch_to_template($data, $innertemplate);
}
foreach my $thisprinter ( keys %$printers ) {
push @printerloop, {
value => $thisprinter,
selected => ( $oldprinter eq $printers->{$thisprinter} ),
branchprinter => $printers->{$thisprinter}->{'printqueue'},
};
}
$innertemplate->param( printerloop => \@printerloop );
# make the checkboxes.....
#
# We export a "categoryloop" array to the template, each element of which
# contains separate 'categoryname', 'categorycode', 'codedescription', and
# 'checked' fields. The $checked field is either '' or 'checked="checked"'
my $catinfo = GetBranchCategory();
my @categoryloop = ();
foreach my $cat (@$catinfo) {
my $checked = "";
my $tmp = quotemeta( $cat->{'categorycode'} );
if ( grep { /^$tmp$/ } @{ $data->{'categories'} } ) {
$checked = "checked=\"checked\"";
}
push @categoryloop, {
categoryname => $cat->{'categoryname'},
categorycode => $cat->{'categorycode'},
categorytype => $cat->{'categorytype'},
codedescription => $cat->{'codedescription'},
checked => $checked,
};
}
$innertemplate->param( categoryloop => \@categoryloop );
for my $obsolete ( 'categoryname', 'categorycode', 'codedescription' ) {
$innertemplate->param(
$obsolete => 'Your template is out of date (bug 130)' );
}
}
sub editcatform {
# prepares the edit form...
my ($categorycode,$innertemplate) = @_;
# warn "cat : $categorycode";
my @cats;
my $data;
if ($categorycode) {
my $data = GetBranchCategory($categorycode);
$data = $data->[0];
$innertemplate->param(
categorycode => $data->{'categorycode'},
categoryname => $data->{'categoryname'},
codedescription => $data->{'codedescription'},
);
}
for my $ctype (GetCategoryTypes()) {
push @cats , { type => $ctype , selected => ($data->{'categorytype'} and $data->{'categorytype'} eq $ctype) };
}
$innertemplate->param(categorytype => \@cats);
}
sub branchinfotable {
# makes the html for a table of branch info from reference to an array of hashs.
my ($branchcode,$innertemplate) = @_;
my $branchinfo = $branchcode ? GetBranchInfo($branchcode) : GetBranchInfo();
my @loop_data = ();
foreach my $branch (@$branchinfo) {
#
# We export the following fields to the template. These are not
# pre-composed as a single "address" field because the template
# might (and should) escape what is exported here. (See bug 180)
#
# - branch_name (Note: not "branchname")
# - branch_code (Note: not "branchcode")
# - address (containing a static error message)
# - branchaddress1 \
# - branchaddress2 |
# - branchaddress3 | comprising the old "address" field
# - branchzip |
# - branchcity |
# - branchcountry |
# - branchphone |
# - branchfax |
# - branchemail /
# - branchurl /
# - address-empty-p (1 if no address information, 0 otherwise)
# - categories (containing a static error message)
# - category_list (loop containing "categoryname")
# - no-categories-p (1 if no categories set, 0 otherwise)
# - value
#
my %row = ();
# Handle address fields separately
my $address_empty_p = 1;
for my $field (
'branchaddress1', 'branchaddress2',
'branchaddress3', 'branchzip',
'branchcity', 'branchcountry',
'branchphone', 'branchfax',
'branchemail', 'branchurl',
'branchip', 'branchprinter', 'branchnotes'
)
{
$row{$field} = $branch->{$field};
$address_empty_p = 0 if ( $branch->{$field} );
}
$row{'address-empty-p'} = $address_empty_p;
# Handle categories
my $no_categories_p = 1;
my @categories;
foreach my $cat ( @{ $branch->{'categories'} } ) {
my ($catinfo) = @{ GetBranchCategory($cat) };
push @categories, { 'categoryname' => $catinfo->{'categoryname'} };
$no_categories_p = 0;
}
$row{'category_list'} = \@categories;
$row{'no-categories-p'} = $no_categories_p;
$row{'branch_name'} = $branch->{'branchname'};
$row{'branch_code'} = $branch->{'branchcode'};
$row{'value'} = $branch->{'branchcode'};
push @loop_data, \%row;
}
my @branchcategories = ();
for my $ctype ( GetCategoryTypes() ) {
my $catinfo = GetBranchCategories(undef,$ctype);
my @categories;
foreach my $cat (@$catinfo) {
push @categories, {
categoryname => $cat->{'categoryname'},
categorycode => $cat->{'categorycode'},
codedescription => $cat->{'codedescription'},
categorytype => $cat->{'categorytype'},
};
}
push @branchcategories, { categorytype => $ctype , $ctype => 1 , catloop => \@categories};
}
$innertemplate->param(
branches => \@loop_data,
branchcategories => \@branchcategories
);
}
sub _branch_to_template {
my ($data, $template) = @_;
$template->param(
branchcode => $data->{'branchcode'},
branch_name => $data->{'branchname'},
branchaddress1 => $data->{'branchaddress1'},
branchaddress2 => $data->{'branchaddress2'},
branchaddress3 => $data->{'branchaddress3'},
branchzip => $data->{'branchzip'},
branchcity => $data->{'branchcity'},
branchcountry => $data->{'branchcountry'},
branchphone => $data->{'branchphone'},
branchfax => $data->{'branchfax'},
branchemail => $data->{'branchemail'},
branchurl => $data->{'branchurl'},
branchip => $data->{'branchip'},
branchnotes => $data->{'branchnotes'},
);
}
output_html_with_http_headers $input, $cookie, $template->output;
# Local Variables:
# tab-width: 8
# End:
View git blame Copy permalink