Jonathan Druart
605f42a721
If a user modify the library when he's updating a notice, the notice will be duplicated, instead of modified. To reproduce: 1/ Go on the notice & slips tools (tools/letter.pl) 2/ Create a notice A for library L1 3/ Edit this notice and update the library with L2 4/ On the list view, you will observe that 2 notices A now exist, one for L1 and one for L2. The code in tools/letters.pl should be rebuilt completely, it becomes a house of cards. To prevent this bug, I suggest to not let the user modify the library value on editing a notice. It cans be done by copying the notice to another library and remove the original one. Counter patch welcomed. Test plan: 1/ Go on the notice & slips tools (tools/letter.pl). 2/ Create a notice A for library L1. 3/ Edit this notice: you are not able to modify the library anymore. 4/ Copy the notice to library L2. You are not able to modify the library neither. Works ok. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> |
||
---|---|---|
.. | ||
csv-profiles | ||
quotes | ||
ajax-inventory.pl | ||
background-job-progress.pl | ||
batch_delete_records.pl | ||
batch_record_modification.pl | ||
batch_records_ajax.pl | ||
batchMod.pl | ||
cleanborrowers.pl | ||
copy-holidays.pl | ||
csv-profiles.pl | ||
exceptionHolidays.pl | ||
export.pl | ||
holidays.pl | ||
import_borrowers.pl | ||
inventory.pl | ||
koha-news.pl | ||
letter.pl | ||
manage-marc-import.pl | ||
marc_modification_templates.pl | ||
modborrowers.pl | ||
newHolidays.pl | ||
overduerules.pl | ||
picture-upload.pl | ||
quotes-upload.pl | ||
quotes.pl | ||
scheduler.pl | ||
showdiffmarc.pl | ||
stage-marc-import.pl | ||
tools-home.pl | ||
upload-cover-image.pl | ||
upload-file.pl | ||
upload.pl | ||
viewlog.pl |