c5d1d9b623
Renewals were being rejected for incorrect reasons Checking was being done against the wrong object Add more informative messages on failure Correctly set due_date for renewal response Avoid crashing the SIPServer because it handles RenewAll incorrectly Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
60 lines
1.2 KiB
Perl
60 lines
1.2 KiB
Perl
#
|
|
# Status of a Renew Transaction
|
|
#
|
|
|
|
package ILS::Transaction::Renew;
|
|
|
|
use warnings;
|
|
use strict;
|
|
|
|
use ILS;
|
|
|
|
use C4::Circulation;
|
|
use C4::Members;
|
|
|
|
use base qw(ILS::Transaction);
|
|
|
|
my %fields = (
|
|
renewal_ok => 0,
|
|
);
|
|
|
|
sub new {
|
|
my $class = shift;
|
|
my $self = $class->SUPER::new();
|
|
|
|
foreach my $element (keys %fields) {
|
|
$self->{_permitted}->{$element} = $fields{$element};
|
|
}
|
|
|
|
@{$self}{keys %fields} = values %fields; # overkill?
|
|
return bless $self, $class;
|
|
}
|
|
|
|
sub do_renew_for {
|
|
my $self = shift;
|
|
my $borrower = shift;
|
|
my ($renewokay,$renewerror) = CanBookBeRenewed($borrower->{borrowernumber},$self->{item}->{itemnumber});
|
|
if ($renewokay){
|
|
$self->{due} = undef;
|
|
my $due_date = AddIssue( $borrower, $self->{item}->id, undef, 0 );
|
|
if ($due_date) {
|
|
$self->{due} = $due_date;
|
|
}
|
|
$self->renewal_ok(1);
|
|
} else {
|
|
$renewerror=~s/on_reserve/Item unavailable due to outstanding holds/;
|
|
$renewerror=~s/too_many/Item has reached maximum renewals/;
|
|
$self->screen_msg($renewerror);
|
|
$self->renewal_ok(0);
|
|
}
|
|
$self->ok(1);
|
|
return;
|
|
}
|
|
|
|
sub do_renew {
|
|
my $self = shift;
|
|
my $borrower = GetMember( cardnumber => $self->{patron}->id );
|
|
return $self->do_renew_for($borrower);
|
|
}
|
|
|
|
1;
|