Marcel de Rooy
eb8666357c
Moving timeout logic to one routine (with unit test).
This further implements two suggestions from Kyle and Larry:
[1] You could use a client_timeout of 0 to specify no timeout at all.
[2] Have the client_timeout default to the timeout if not defined.
Test plan:
[1] Run t/db_dependent/SIP/SIPServer.t.
[2] Test login timeout for raw and telnet.
[3] Check ACS status message for timeout value. Should match policy
timeout from institution.
[4] Test client timeout (zero and non-zero).
[5] Remove client timeout. Test fallback to service.
[6] Remove service timeout too. Test fallback to 30 at login.
Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended to incorporate Srdjan's suggestion to move get_timeout to
SIPServer.pm; this requires some additional mocking in the unit test.
And even makes the test db dependent, as documented.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
58 lines
1.9 KiB
Raku
Executable file
58 lines
1.9 KiB
Raku
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 9;
|
|
use Test::Warn;
|
|
|
|
BEGIN {
|
|
use_ok('C4::SIP::Sip');
|
|
}
|
|
|
|
my $date_time = C4::SIP::Sip::timestamp();
|
|
like( $date_time, qr/^\d{8} \d{6}$/, 'Timestamp format no param');
|
|
|
|
my $t = time();
|
|
|
|
$date_time = C4::SIP::Sip::timestamp($t);
|
|
like( $date_time, qr/^\d{8} \d{6}$/, 'Timestamp format secs');
|
|
|
|
$date_time = C4::SIP::Sip::timestamp('2011-01-12');
|
|
ok( $date_time eq '20110112 235900', 'Timestamp iso date string');
|
|
|
|
my $myChecksum = C4::SIP::Sip::Checksum::checksum("12345");
|
|
my $checker = 65281;
|
|
my $stringChecksum = C4::SIP::Sip::Checksum::checksum("teststring");
|
|
my $stringChecker = 64425;
|
|
|
|
is( $myChecksum, $checker, "Checksum: $myChecksum matches expected output");
|
|
is( $stringChecksum, $stringChecker, "Checksum: $stringChecksum matches expected output");
|
|
|
|
my $testdata = "abcdAZ";
|
|
my $something = C4::SIP::Sip::Checksum::checksum($testdata);
|
|
|
|
$something = sprintf("%4X", $something);
|
|
ok( C4::SIP::Sip::Checksum::verify_cksum($testdata.$something), "Checksum: $something is valid.");
|
|
|
|
my $invalidTest;
|
|
warning_is { $invalidTest = C4::SIP::Sip::Checksum::verify_cksum("1234567") }
|
|
'verify_cksum: no sum detected',
|
|
'verify_cksum prints the expected warning for an invalid checksum';
|
|
is($invalidTest, 0, "Checksum: 1234567 is invalid as expected");
|
|
|
|
1;
|