Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Jonathan Druart c6e0d42521 Bug 17962: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible 
To make ACQ_NOTIF_ON_RECEIV TT compatible, we need to expose data from
the aqorders table. We already have a package for it in the Koha
namespace but it is based on Koha::Object[s].
The other path creates dummy Koha::Tmp::Order[s] packages to make it
usable. Of course we should use a valid Koha::Acquisition::Order[s]
based on Koha::Object, but it's outside the scope of this bug report.

This notice template is quite simple, and it's a good one to start.
From C4::Acq::NotifyOrderUsers, GetPreparedLetter is called with 4
elements: the library, the patron to notify, the biblio and the order
information.
Note that prior to this patch aqorders was filled from GetOrder, which
retrieved a lot of information from the acquisition table (aqbasket,
aqbookseller). The idea with the TT syntax is to access the data from
where it really exists. So if a user wants to display the basket name,
[% order.basket.basketname %] should be used instead.
Note that this will not work at the moment, the basket method is not
defined in the order package.

However the basic template should work as before.
The test added to TemplateToolkit proves that.

Test plan:
Use the default ACQ_NOTIF_ON_RECEIV to notify a patron that an order has
been received.
That generated template should be exactly the same as prior to this
patch.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-02-17 11:43:46 +00:00
..
Acquisition Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
api/v1 Bug 17654: Add tests to enforce swagger definition files integrity 2016-11-18 14:04:22 +00:00
Auth
Authorities Bug 17950: Merge.t: Improve variable handling at top level 2017-02-17 11:41:48 +00:00
Biblio
Circulation Bug 8361: Do not allow checkouts if no rules are defined 2017-01-20 13:41:59 +00:00
Creators Bug 18044: Add a test 2017-02-07 17:46:00 +00:00
data
Exporter Bug 17196: [QA Follow-up] Wrong module in Record.t 2017-01-13 13:49:29 +00:00
Holds Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
Items Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping 2016-10-21 15:23:06 +00:00
Koha Bug 17933: Add test and return unless defined dob 2017-02-17 11:22:09 +00:00
Labels
LDAP
Letters Bug 17962: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible 2017-02-17 11:43:46 +00:00
Members Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59 2017-02-14 13:59:23 +00:00
OAI
Patron Bug 17486: [QA Follow-up] Changes as to set_userenv 2017-01-13 12:32:20 +00:00
Record Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests 2016-10-21 15:13:55 +00:00
Reports
Reserves Bug 17766 - Patron notification does not work with multi item holds 2017-01-13 11:29:28 +00:00
Search Bug 17323: Column search_history.time cannot be null 2016-11-18 13:51:37 +00:00
selenium
Serials Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
SIP Bug 15006: Centralize timeout logic and allow zero client timeout 2016-07-15 14:11:05 +00:00
Template/Plugin Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] 2016-12-20 15:13:28 +00:00
Utils Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches 2016-10-27 13:21:13 +00:00
www Bug 17540: (Bug 7216 followup) Fix tests for auth_values_input_www.t 2016-11-04 11:08:41 +00:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
00-strict.t
Accounts.t Bug 17894 - Remove and replace WriteOffFee 2017-01-19 11:15:26 +00:00
Acquisition.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
AdditionalField.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
ArticleRequests.t Bug 14610 - Add unit tests 2016-10-26 12:15:15 +00:00
AudioAlerts.t
Auth.t
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 17615 - Fix unit tests 2017-01-20 13:37:34 +00:00
AuthorisedValues.t Bug 17642: Do not explode if no authorised value exist 2016-11-18 15:52:01 +00:00
AuthoritiesMarc.t Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison 2017-02-14 14:01:11 +00:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t Bug 17196: Fix - Update metadata on update 2017-01-13 13:49:27 +00:00
Bookseller.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Breeding.t
Budgets.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Charset.t
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
Circulation.t Bug 17678: Typo iss in Circulation.t 2016-12-23 11:46:21 +00:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
db_structure.t
DecreaseLoanHighHolds.t Bug 16387: Fix default shortened loan period time 2017-02-07 17:54:21 +00:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 11592: Add should_hide_marc method to filter 2016-09-08 11:54:16 +00:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t
Holds.t Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
HoldsQueue.t Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
Holidays.t Bug 16376: (regression tests) 2016-12-09 15:25:01 +00:00
ILSDI_Services.t Bug 17836: (ILSDI) Regression test 2017-01-20 13:44:57 +00:00
ImportBatch.t
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 17512: Improve handling dates in C4::Items 2017-02-14 13:57:49 +00:00
Items_DelItemCheck.t Bug 14504: Changes missed while fixing patches 2016-08-26 12:07:27 +00:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 14629 - Fix # of unit tests 2016-10-28 12:11:17 +00:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 17255 - Upgrade Elastic Search code to work with version 5.1 2017-02-07 17:17:54 +00:00
Koha_Elasticsearch_Indexer.t Bug 17372: Standardize Elasticsearch paths 2016-10-11 01:07:03 +00:00
Koha_Misc_Files.t
Koha_SearchEngine_Elasticsearch_Search.t Bug 18068: ES - Fix location and (home|holding)branch facets 2017-02-17 11:34:41 +00:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Linker_FirstMatch.t
Log.t Bug 16829: Unit tests for logaction's 'interface parameter' 2016-08-17 18:01:50 +00:00
MarcModificationTemplates.t
Members.t Bug 17578 [QA Followup] - Update number of tests 2016-12-16 13:14:50 +00:00
MungeMarcPrice.t
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 18025: Fix test 2017-02-17 11:24:39 +00:00
PatronLists.t Bug 17486: [QA Follow-up] Changes as to set_userenv 2017-01-13 12:32:20 +00:00
Patrons.t Bug 17742: Use TestBuilder to create the library and patron category 2016-12-28 13:34:21 +00:00
Plugins.t Bug 15879: Add Tests 2017-01-11 14:03:00 +00:00
QueryParser.t
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t
Reports.t
Reserves.t Bug 18045: Fix Reserves.t tests - caching issues 2017-02-17 11:33:37 +00:00
rollingloans.t Bug 17578: GetMemberDetails - Remove GetMemberDetails 2016-12-16 13:12:44 +00:00
RotatingCollections.t
Search.t Bug 17917: [QA Follow-up] Reprove Search.t 2017-01-20 13:39:36 +00:00
Serials.t Bug 15030: Add tests 2017-02-07 17:43:49 +00:00
Serials_2.t Bug 7677: UT: Remove $dbh->rollback 2016-09-12 09:13:58 +00:00
Service.t
ShelfBrowser.t
Sitemapper.t Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions 2017-01-20 14:04:21 +00:00
Stats.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t Bug 17099: C4::Koha - Remove GetSupportName and GetSupportList 2016-09-09 13:30:45 +00:00
sysprefs.t
Tags.t
Templates.t Bug 17982: Expose wrong use of uniq 2017-02-14 14:09:52 +00:00
TestBuilder.t Bug 17726: [QA Follow-up] Add test descriptions 2017-01-20 13:43:18 +00:00
Upload.t Bug 17501: [Follow-up] QA Requests 2017-01-20 14:20:07 +00:00
UsageStats.t Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
Virtualshelves.t Bug 16551: Display the name of lists to the search results at the OPAC 2016-09-25 15:43:07 +00:00
XISBN.t
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
zebra_config.pl