Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Kyle M Hall c7e48b0a1a Bug 22076: SIP checkin for withdrawn item returns ok in checkin response 
If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message.

To recreate:
 1 - Mark an item withdrawn
 2 - Set up sip server:
     https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
 3 - Set 'BlockReturnOfWithdrawnItems' to block
 4 - Use the sip_cli_emulator to checkin the withdrawn item
 5 - There is no error in the checkin

Test Plan:
1) Mark an item withdrawn
2) Set BlockReturnOfWithdrawnItems to block
3) Use the sip cli emulator to checkin the withdrawn item
4) Note the response begins with 101
5) Apply this patch
6) Restart all the things ( including SIP server )
7) Repeat checkin with sip cli emulator
8) Note the checkin now beings with 100

Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov>
Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-28 12:08:18 +00:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
ClassSplitRoutine Bug 15836: Add the ability to defined custom methods to split call number in labels 2018-11-13 15:18:22 +00:00
Creators Bug 15766: Fix incorrect GROUP BY 2018-10-24 17:15:36 +00:00
External Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting 2018-10-02 00:03:03 +00:00
Form
Heading Bug 21826: (QA follow-up) Add UNIMARC support 2019-01-25 20:13:39 +00:00
ILSDI Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs 2019-03-21 16:22:56 +00:00
Installer Bug 21955: Remove Cache::Memory as fallback for L2 cache 2018-12-11 19:10:46 +00:00
Labels Bug 15836: Add the ability to defined custom methods to split call number in labels 2018-11-13 15:18:22 +00:00
Linker
Members Bug 20444: Remove sub GetAttributes 2018-05-03 13:26:49 -03:00
OAI Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios 2017-06-13 16:18:59 -03:00
Output Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Patroncards Bug 22429: Infinite loop in patron card printing 2019-03-15 11:59:28 +00:00
Reports Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Search
Serials Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:53 -03:00
SIP Bug 22076: SIP checkin for withdrawn item returns ok in checkin response 2019-03-28 12:08:18 +00:00
Utils Bug 17353: Add phone number column to checkout search 2019-01-28 13:06:35 +00:00
Accounts.pm Bug 21683: Remove accountlines.accountno 2019-03-21 18:19:22 +00:00
Acquisition.pm Bug 22565: Do NOT replace all internalnote's on receive 2019-03-25 12:12:53 +00:00
Auth.pm Bug 22483: Restore exact behaviour of undef 2019-03-09 05:16:40 -03:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm Bug 19160: Add POD 2018-03-23 11:45:38 -03:00
Auth_with_ldap.pm Bug 22048: Use set_password in Auth_with_ldap.pm 2019-01-25 20:15:31 +00:00
Auth_with_shibboleth.pm Bug 18507: Shibboleth auto-provisioning - Sync 2018-11-08 20:43:32 +00:00
AuthoritiesMarc.pm Bug 21962: Fix authority search using 'all' 2018-12-11 19:15:39 +00:00
BackgroundJob.pm
Barcodes.pm Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
Biblio.pm Bug 18736: (QA follow-up) Resolve uninitialized warn from Biblio.pm L3334 2019-03-21 16:29:06 +00:00
Bookseller.pm Bug 14535: Update the supplier filter too 2017-03-31 12:38:44 +00:00
Boolean.pm
Breeding.pm Bug 12747: (QA follow-up) Treat 010 according to marcflavour 2018-10-01 13:56:26 +00:00
Budgets.pm Bug 18736: (follow-up) Remove duplicate code and adjust tests 2019-03-21 16:29:06 +00:00
Calendar.pm Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT 2017-07-06 14:29:04 -03:00
Charset.pm Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag" 2017-07-26 14:01:51 -03:00
Circulation.pm Bug 21683: (follow-up) Polish the change - based on feedback 2019-03-21 18:19:22 +00:00
ClassSortRoutine.pm
ClassSource.pm Bug 15836: Remove deprecated subroutines 2018-11-13 18:56:18 +00:00
ClassSplitRoutine.pm Bug 15836: Add the ability to defined custom methods to split call number in labels 2018-11-13 15:18:22 +00:00
Context.pm Bug 14302: (follow-up) Remove traces in C4::Search and C4::Context 2018-08-31 11:24:22 +00:00
Contract.pm
CourseReserves.pm Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
Creators.pm
Debug.pm Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
Heading.pm Bug 21826: Remove strict and warning from Heading.pm 2019-01-25 20:13:41 +00:00
HoldsQueue.pm Bug 22330: Cache item and library objects when building the holds queue 2019-03-21 16:22:56 +00:00
HTML5Media.pm Bug 21742: Fix YouTube variable propagation 2018-11-01 18:59:33 +00:00
Images.pm Bug 21987: Do not generate true color thumbnails if not needed 2019-03-15 12:19:56 +00:00
ImportBatch.pm Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls 2018-08-30 13:40:35 +00:00
ImportExportFramework.pm Bug 18143: Silence ods MARC framework export flood 2019-02-19 13:52:15 +00:00
InstallAuth.pm Bug 21137: Replace USER_INFO with logged_in_user 2018-08-14 12:43:10 +00:00
Installer.pm Bug 21654: Remove refund_lost_item_fee_rules.sql from the installer process 2018-10-26 17:09:59 +00:00
ItemCirculationAlertPreference.pm
Items.pm Bug 13735: Update PrepareItemrecordDisplay to use maxlength 2019-03-22 19:10:47 +00:00
Koha.pm Bug 18322: Add a facet for ccode fields to Zebra 2018-07-18 17:42:48 +00:00
Labels.pm
Languages.pm Bug 20115: Set the languages order with the pref values 2018-04-04 15:45:43 -03:00
Letters.pm Bug 21875: Handling subject line in Letters.pm 2019-02-27 09:14:21 -05:00
Linker.pm
Log.pm Bug 22003: Remove unused subroutines displaylog and GetLogStatus from C4::Log 2019-01-11 12:20:49 +00:00
MarcModificationTemplates.pm Bug 13560: Add an 'Add' option for marc modification templates 2018-07-19 17:22:18 +00:00
Matcher.pm Bug 19365: Fix several issues with the Elasticsearch code 2018-11-26 16:11:01 +00:00
Members.pm Bug 19920: Removed unnecessary code from C4/Members.pm 2019-01-25 16:11:48 +00:00
Message.pm Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
NewsChannels.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Output.pm Bug 20661: (QA follow-up) Add POD for output_and_exit 2018-08-10 12:23:03 +00:00
Overdues.pm Bug 21747: (follow-up) Intelligent rename of offsets 2019-02-27 09:14:21 -05:00
Patroncards.pm
Print.pm
Record.pm Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Reports.pm
Reserves.pm Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines 2019-03-21 16:22:56 +00:00
Ris.pm Bug 10306: Core module changes for multiple mappings 2017-12-07 14:44:15 -03:00
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm Bug 22140: Use of EasyAnalyticalRecords pref in search 2019-02-15 13:34:57 +00:00
Serials.pm Bug 22237: Subscriptions are not linked to Mana upon edit 2019-03-15 11:34:03 +00:00
Service.pm Bug 7550: [QA Follow-up] Resolve param warning from sco-patron-image 2017-05-08 09:00:26 -04:00
ShelfBrowser.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
SMS.pm Bug 19134: C4::SMS falils on long driver name 2017-08-25 10:51:24 -03:00
SocialData.pm
Stats.pm Bug 21683: Remove accountlines.accountno 2019-03-21 18:19:22 +00:00
Suggestions.pm Bug 21241: (follow-up) Made SQL change idempotent 2019-01-28 11:42:32 +00:00
Tags.pm
Templates.pm Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm Bug 21226: Remove xISBN services 2018-08-16 13:20:22 +00:00
XISBN.pm Bug 21235: Remove table services_throttle 2018-09-07 15:09:39 +00:00
XSLT.pm Bug 18584: remove trailing space from C4/XSLT.pm 2019-03-04 18:43:05 +00:00