Koha/C4/SIP/ILS
Matthias Meusburger 72fae3a9c9
Bug 25813: Enhance patron expiration in SIP display
Currently, the patron information returned by SIP only shows
 "PATRON EXPIRED" when the patron card has expired.

 This patch makes the display more consistant with the Opac display
 and also complies with the NotifyBorrowerDeparture system preference.

 Test plan:

  - apply the patch

  - set NotifyBorrowerDeparture to 0

  - check that nothing is ever displayed about the card expiration

  - set NotifyBorrowerDeparture to a value greater than 0

  - check that the following message will be displayed for a card that will
    expire within NotifyBorrowerDeparture days:
    "Your card will expire on {correctly formatted date}"

  - check that the following message will be displayed for a card that has
    expired:
    "Your account has expired as of {correctly formatted date}"

 You can use src/C4/SIP/interactive_patron_dump.pl for easier testing.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-22 15:07:31 +01:00
..
Transaction Bug 35944: (QA follow-up) Tidy 2024-03-15 15:39:14 +01:00
Item.pm Bug 34868: (QA follow-up) Tidy sip_circulation_status 2023-11-10 10:59:39 -03:00
Item.pod
Patron.pm Bug 25813: Enhance patron expiration in SIP display 2024-03-22 15:07:31 +01:00
Patron.pod Bug 32684: (QA follow-up) Move too_many_lost to Patron 2023-03-14 08:49:29 -03:00
Transaction.pm Bug 28931: Use EXPORT_OK from Koha::DateUtils 2021-10-07 11:01:05 +02:00