Koha/tools
David Cook 30be338c24
Bug 33989: Only look up authorized value descriptions for items in results
This patch changes the inventory tool so that it only populates the
authorized value descriptions for items that show up in the results.
That is, items that will be viewed by a human.

This change saves a lot of time by not performing unnecessary
database lookups.

Test plan:

0. Apply patch and koha-plack --restart kohadev
1. Go to create a SQL report from SQL
/cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL
2. Save a report with the following SQL:
SELECT barcode FROM items where barcode <> '';
3. Run the report
4. Download as CSV
5. Edit the CSV and remove the "barcode" heading

6. Go to edit item for barcode 3999900000001
/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=1&itemnumber=1
7. Add "Damaged status" of "Damaged"
8. Click "Save changes"

9. koha-mysql kohadev
10. update items set notforloan = 9 where barcode = 3999900000001;

11. Go to inventory tool
http://localhost:8081/cgi-bin/koha/tools/inventory.pl
12. Upload barcode file via "Choose file"
13. Uncheck "Compare barcodes list to results"
14. Open F12 tools
15. Click "Submit"
16. Click "OK" on confirm box

17. Note that the inventory job takes around 30 seconds to run
instead of 60 seconds
17b. The exact figures may vary. If you compare with before patch
inventory runs, you'll be saving roughly 18 seconds.
18. Note that "Damaged" appears in the "Damaged" column, which
demonstrates that the authorized value lookup was completed for
the item in the result list

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-06-26 11:39:58 -03:00
..
csv-profiles
access_files.pl Bug 33341: Address some perlcritic errors in 5.36 2023-03-28 14:50:33 +02:00
additional-contents.pl
ajax-inventory.pl
automatic_item_modification_by_age.pl
batch_delete_records.pl
batch_extend_due_dates.pl
batch_record_modification.pl Bug 29771: Scalar context for split 2022-03-08 23:03:34 -10:00
batch_records_ajax.pl
batchMod.pl Bug 32019: Add option to mark items returned via batch modification 2023-02-20 09:54:20 -03:00
cleanborrowers.pl
copy-holidays.pl
csv-profiles.pl
exceptionHolidays.pl
export.pl Bug 25503: Add option to export items bundle contents in checkouts table 2023-05-10 15:26:20 -03:00
holidays.pl
import_borrowers.pl Bug 27920: (QA follow-up) Change radios to a single select pulldown 2022-11-09 14:37:24 -03:00
inventory.pl Bug 33989: Only look up authorized value descriptions for items in results 2023-06-26 11:39:58 -03:00
letter.pl Bug 32221: Borrowers.password should no longer be an option 2023-01-20 13:55:17 +00:00
manage-marc-import.pl Bug 33412: Fix comparison when checking for overlay framework 2023-05-09 10:58:04 -03:00
marc_modification_templates.pl
modborrowers.pl Bug 31095: (follow-up) Iterate debarments in batch mod 2023-01-31 10:19:42 -03:00
newHolidays.pl
overduerules.pl
page.pl Bug 31385: (follow-up) Same change at intranet side 2022-08-19 11:43:56 -03:00
picture-upload.pl Bug 33341: Address some perlcritic errors in 5.36 2023-03-28 14:50:33 +02:00
problem-reports.pl
quotes-upload.pl
quotes.pl
scheduler.pl
showdiffmarc.pl Bug 31526: Follow-up for bug 29697 2022-09-16 10:25:48 -03:00
stage-marc-import.pl Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file 2022-11-15 18:44:30 -03:00
stockrotation.pl Bug 30869: Add the ability to delete stock rotation rotas 2023-02-24 17:52:23 -03:00
tools-home.pl Bug 33595: (bug 26628 follow-up) Fix authorization for tools-home.pl 2023-05-16 11:47:15 +02:00
upload-cover-image.pl
upload-file.pl
upload.pl
viewlog.pl