Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Colin Campbell cd40febe67 Bug 28052: Do not check SYSENV values only keys in loop 
Loop is only interested in key values, because 'keys' is omitted
it is checking values as well. This can lead to misleading errors
being logged (e.g. key is undefined)
Extract keys only to loop array as in the other loops below this

Testing:
1 - tail /var/lib/koha/kohadev/sip-output.log
2 - in another tab use the sip cli tester:
   perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m checkin --item CHESS1
3 - Note errors:
Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 1.
Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 2.
4 - Apply patch and restart all the things
5 - Repeat 2
6 - Errors mentioned are gone

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-01 18:51:37 +02:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
ClassSplitRoutine
Creators
External
Form
Heading Bug 21958: Fix bibliographic record field comparison with authority 2021-04-01 17:13:56 +02:00
ILSDI Bug 17229: Check if patron is expired in CanItemBeReserved 2021-01-19 15:45:11 +01:00
Installer
Labels
Linker
Members Bug 24447: Changing 'DUE' to example in database that exists. 2021-01-22 13:46:41 +01:00
OAI
Output
Patroncards Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Reports Bug 27380: Move get_prepped_report to object and use for svc/reports 2021-02-12 12:29:56 +01:00
Search
Serials
SIP Bug 28052: Do not check SYSENV values only keys in loop 2021-04-01 18:51:37 +02:00
Utils Bug 27715: (QA follow-up) Remove conditional declaration 2021-02-24 00:12:59 +01:00
Accounts.pm Bug 22394: Remove C4::Accounts::manualinvoice 2020-11-04 12:59:33 +01:00
Acquisition.pm Bug 26584: Remove unused C4::Acquisition::CloseBasket function 2020-11-05 15:24:20 +01:00
Auth.pm Bug 22824: Remove C4::Boolean, true_p, boolean_preference, etc. 2021-03-04 16:18:42 +01:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
Auth_with_ldap.pm
Auth_with_shibboleth.pm
AuthoritiesMarc.pm Bug 21958: Fix bibliographic record field comparison with authority 2021-04-01 17:13:56 +02:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 21958: Fix bibliographic record field comparison with authority 2021-04-01 17:13:56 +02:00
Breeding.pm
Budgets.pm Bug 24361: (bug 24217 follow-up) Fix several warnings in C4 modules 2020-01-07 13:59:51 +00:00
Calendar.pm
Charset.pm
Circulation.pm Bug 25690: (QA follow-up) PROCESSED -> PROCESSING for consistency 2021-03-04 16:18:42 +01:00
ClassSortRoutine.pm
ClassSource.pm
ClassSplitRoutine.pm
Context.pm Bug 22824: Remove C4::Boolean, true_p, boolean_preference, etc. 2021-03-04 16:18:42 +01:00
Contract.pm
CourseReserves.pm
Creators.pm
Debug.pm Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
Heading.pm Bug 21958: Fix bibliographic record field comparison with authority 2021-04-01 17:13:56 +02:00
HoldsQueue.pm Bug 27068: Perltidy _checkHoldPolicy 2021-02-12 13:08:56 +01:00
HTML5Media.pm Bug 27422: YouTube videos are HTTPS only 2021-02-08 17:09:34 +01:00
ImportBatch.pm Bug 24469: Move the new queries to a dedicated ImportBatch subroutine 2021-02-18 11:52:59 +01:00
ImportExportFramework.pm Bug 27569: Fix ODS export - take empty string into account 2021-02-16 10:22:13 +01:00
InstallAuth.pm
Installer.pm Bug 22824: Replace YAML::Syck with YAML::XS 2021-03-04 16:18:42 +01:00
ItemCirculationAlertPreference.pm
Items.pm Bug 27545: Use NewItemsDefaultLocation from places where an item is created 2021-03-09 17:20:47 +01:00
Koha.pm
Labels.pm
Languages.pm Bug 27491: Rename system preference opaclanguages to OPACLanguages 2021-01-22 14:59:27 +01:00
Letters.pm Bug 27860: Add message_id param to SendQueuedMessages 2021-03-16 12:04:05 +01:00
Linker.pm
Log.pm
MarcModificationTemplates.pm Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Matcher.pm Bug 26199: Include LDR for match check/match point 2021-03-09 17:20:47 +01:00
Members.pm Bug 28053: Squash warning in C4::Members 2021-04-01 18:51:37 +02:00
Message.pm Bug 22824: Replace YAML::Syck with YAML::XS 2021-03-04 16:18:42 +01:00
NewsChannels.pm Bug 21066: Rename publicationdate with published_on 2020-09-02 15:35:08 +02:00
Output.pm
Overdues.pm Bug 27079: Floating point comparison correction 2020-11-27 09:37:40 +01:00
Patroncards.pm
Record.pm Bug 27673: Fix encoding issues 2021-02-16 14:54:50 +01:00
Reports.pm Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
Reserves.pm Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting 2021-04-01 18:51:37 +02:00
Ris.pm Bug 27673: Fix encoding issues 2021-02-16 14:54:50 +01:00
RotatingCollections.pm Bug 26618: Improve Exception Class Names 2021-03-03 15:36:13 +01:00
Scheduler.pm
Scrubber.pm
Search.pm Bug 27928: FindDuplicate should use simple_search_compat 2021-04-01 18:03:23 +02:00
Serials.pm Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
Service.pm
ShelfBrowser.pm
SMS.pm Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
SocialData.pm Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
Stats.pm
Suggestions.pm Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
Tags.pm
Templates.pm
TmplToken.pm
TmplTokenType.pm Bug 24217: use Modern::Perl for modules when strict is missing 2020-01-03 10:45:46 +00:00
TTParser.pm
UsageStats.pm Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
XISBN.pm Bug 26364: Don't discard the passed isbn 2021-01-07 15:37:15 +01:00
XSLT.pm Bug 21260: Introduce local pref to affect status grouping 2021-04-01 17:58:49 +02:00