Koha/t/SocialData.t
Jonathan Druart b1ba7fac2c Bug 18292: Remove return 1 statements in tests
The test files do not need to return 1

Patch generated with:
perl -p -i -e "s/^1;\n//xsm" t/**/*.t

Test plan:
  git grep '^1;$' t/**/*.t
should not return any results

NOTE: does not fix C4/SIP/t, nor xt tests.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-08-15 12:17:42 -03:00

74 lines
2 KiB
Perl

#!/usr/bin/perl
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More;
use Test::MockModule;
use Module::Load::Conditional qw/check_install/;
BEGIN {
if ( check_install( module => 'Test::DBIx::Class' ) ) {
plan tests => 6;
} else {
plan skip_all => "Need Test::DBIx::Class"
}
}
BEGIN {
use_ok('C4::SocialData');
}
use Test::DBIx::Class;
fixtures_ok [
Biblioitem => [
['biblionumber', 'isbn'],
[1, '0-596-52674-1'],
[2, '0-596-00289-0'],
],
SocialData => [
[
'isbn', 'num_critics',
'num_critics_pro', 'num_quotations',
'num_videos', 'score_avg',
'num_scores'
],
[ '0-596-52674-1', 1, 2, 3, 4, 5.2, 6 ],
[ '0-596-00289-0', 2, 3, 4, 5, 6.2, 7 ]
],
], 'add fixtures';
my $db = Test::MockModule->new('Koha::Database');
$db->mock( _new_schema => sub { return Schema(); } );
Koha::Database::flush_schema_cache();
my $data = C4::SocialData::get_data();
is( $data, undef, 'get_data should return undef if no param given');
$data = C4::SocialData::get_data('0-596-52674-1');
is( $data->{isbn}, '0-596-52674-1', 'get_data should return the matching row');
my $report = C4::SocialData::get_report('0-596-52674-1');
is( $report->{'without'}->[0]->{'original'},
'0-596-52674-1', 'testing get_report gives isbn' );
is( $report->{'without'}->[0]->{'isbn'}, '9780596526740',
'testing get_report' );