Koha/opac
David Cook e6a1d65c9a
Bug 37741: Do not send cookie back from error pages
This change stops the cookie from being sent back from error pages,
so that backcalls that cause errors don't overwrite the existing cookie
used by the foreground request page.

Test plan:
0. Apply the patch and koha-plack --reload kohadev
1. Set syspref IntranetFavicon to http://localhost:8081/cgi-bin/koha/bad.jpg
2. Open browser developer tools
3. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl
4. Open the Network tab, disable the cache, and shift refresh
5. Notice that bad.jpg fails to load with a 404
6. Try to login to Koha
7. Confirm login works

*. Extra points if you note that the cookie returned by the first
mainpage.pl request is used for the bad.jpg lookup and the second
mainpage.pl request.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-08-30 12:45:45 +02:00
..
clubs
errors Bug 37741: Do not send cookie back from error pages 2024-08-30 12:45:45 +02:00
external/overdrive
sci Bug 34478: Changes for opac/sci/sci-main 2024-03-01 10:57:38 +01:00
sco Bug 36679: Prevent SCO login for the AnonymousPatron 2024-06-10 16:20:58 +01:00
svc Bug 35942: OPAC user can enroll several times to the same club 2024-07-01 18:55:39 +02:00
ilsdi.pl Bug 36367: Remove _new_userenv 2024-06-14 11:17:17 +01:00
maintenance.pl
oai.pl
opac-account-pay-return.pl
opac-account-pay.pl Bug 36088: Remove useless code form opac-account-pay.pl 2024-03-07 15:02:43 +01:00
opac-account.pl
opac-addbybiblionumber.pl Bug 34478: Changes for opac-addbybiblionumber 2024-03-01 10:57:37 +01:00
opac-alert-subscribe.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-alert-subscriptions.pl Bug 34478: Remove generate_csrf from pl 2024-03-01 10:55:56 +01:00
opac-article-request-cancel.pl
opac-authorities-home.pl Bug 37057: Restore filtering of unused authorities 2024-07-01 18:55:53 +02:00
opac-authoritiesdetail.pl Bug 29948: OPACAuthorIdentifiersAndInformation 2024-05-13 14:00:10 +02:00
opac-basket.pl
opac-blocked.pl Bug 35952: Remove unnecessary line for OpacSuppressionMessage 2024-03-07 15:02:50 +01:00
opac-browse.pl
opac-browser.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-changelanguage.pl
opac-course-details.pl
opac-course-reserves.pl
opac-curbside-pickups.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-detail.pl Bug 34486: (QA follow-up) Tidy changes to opac/opac-detail.pl 2024-08-29 18:16:21 +02:00
opac-discharge.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-dismiss-message.pl Bug 36532: Protect opac-dismiss-message.pl from malicious usages 2024-05-14 15:04:34 -03:00
opac-downloadcart.pl
opac-downloadshelf.pl
opac-export.pl Bug 37679: Add DC subtypes to allow-list in opac-export.pl 2024-08-21 19:13:58 +02:00
opac-holdshistory.pl
opac-ics.pl
opac-idref.pl
opac-illrequests.pl Bug 34597: Implementation 2024-06-11 10:43:56 +01:00
opac-image.pl
opac-imageviewer.pl
opac-ISBDdetail.pl Bug 35961: (follow-up) Pass along the borrowernumber 2024-05-17 10:36:32 +02:00
opac-issue-note.pl Bug 34478: op =~ ^cud- in pl/pm - Manual cud-email => email 2024-03-01 10:57:14 +01:00
opac-library.pl Bug 30873: Add system preference to hide libraries link in the OPAC 2024-07-02 17:20:39 +02:00
opac-main.pl
opac-MARCdetail.pl Bug 35961: (follow-up) Pass along the borrowernumber 2024-05-17 10:36:32 +02:00
opac-memberentry.pl Bug 37339: Set messaging preferences from default on self registration 2024-07-18 17:53:11 +02:00
opac-messaging.pl Bug 34478: Add 'op' to opac-messaging 2024-03-01 10:57:07 +01:00
opac-modrequest-suspend.pl Bug 34478: Manual fix - add ops - hold-table.inc opac-user.tt 2024-03-01 10:57:21 +01:00
opac-modrequest.pl Bug 34478: Manual fix - add ops - hold-table.inc opac-user.tt 2024-03-01 10:57:21 +01:00
opac-mymessages.pl
opac-news-rss.pl
opac-overdrive-search.pl
opac-page.pl Bug 36875: Do not pass unsanitized language to $page->translated_content 2024-06-20 17:55:37 +02:00
opac-passwd.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-password-recovery.pl Bug 34478: Changes for opac-password-recovery 2024-03-01 10:57:35 +01:00
opac-patron-consent.pl
opac-patron-image.pl
opac-privacy.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-ratings.pl Bug 34478: Add 'op' to opac-ratings 2024-03-01 10:57:09 +01:00
opac-readingrecord.pl
opac-recall.pl Bug 36142: recallsview template param for opac-recall.tt 2024-04-05 11:51:23 +02:00
opac-recalls.pl
opac-registration-verify.pl Bug 37339: Set messaging preferences from default on self registration 2024-07-18 17:53:11 +02:00
opac-renew.pl Bug 36453: Update old occurrences of effective_BlockExpiredPatronOpacActions 2024-06-11 09:17:18 +01:00
opac-reportproblem.pl Bug 34478: Manual fix - problem_reports 2024-03-01 10:56:59 +01:00
opac-request-article.pl Bug 34478: Add 'op' to opac-request-article 2024-03-01 10:57:08 +01:00
opac-reserve.pl Bug 36453: Update old occurrences of effective_BlockExpiredPatronOpacActions 2024-06-11 09:17:18 +01:00
opac-reset-password.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-restrictedpage.pl
opac-retrieve-file.pl
opac-review.pl Bug 34478: Changes for opac-review 2024-03-01 10:57:20 +01:00
opac-routing-lists.pl
opac-search-history.pl Bug 34478: Manual fix - action to op / add cud- - opac-search-history 2024-03-01 10:57:13 +01:00
opac-search.pl Bug 36557: Convert Cart and Lists controls to buttons and rework logic 2024-07-01 18:55:43 +02:00
opac-sendbasket.pl Bug 36520: Sanitize input in opac-sendbasket.pl 2024-06-20 17:55:36 +02:00
opac-sendshelf.pl Bug 34478: Changes for opac-sendshelf 2024-03-01 10:57:25 +01:00
opac-serial-issues.pl
opac-shareshelf.pl Bug 34478: Changes for opac-shareshelf 2024-03-01 10:59:26 +01:00
opac-shelves.pl Bug 36557: Convert Cart and Lists controls to buttons and rework logic 2024-07-01 18:55:43 +02:00
opac-showmarc.pl
opac-showreviews.pl
opac-suggestions.pl Bug 37152: Aquisitions basket and OPAC suggestion deletion should use the op cud-delete 2024-06-27 11:49:57 +02:00
opac-tags.pl Bug 36785: Typo unreconized and bilbio in tags code 2024-05-17 10:36:35 +02:00
opac-tags_subject.pl
opac-topissues.pl Bug 34478: op =~ ^cud- - Manual - cud-do_it => do_it 2024-03-01 10:58:32 +01:00
opac-user.pl Bug 34478: Remove check_csrf from pl files 2024-03-01 10:56:01 +01:00
opac-virtual-card.pl Bug 26777: Allow ability to select diffferent barcode types 2024-08-26 17:39:36 +02:00
tracklinks.pl
unapi