dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
242 lines
13 KiB
Text
242 lines
13 KiB
Text
[% USE Branches %]
|
|
[% USE AuthorisedValues %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Tools › Patron clubs ›
|
|
[% IF club_template %]
|
|
Modify club template [% club_template.name | html %]
|
|
[% ELSE %]
|
|
Create a new club template
|
|
[% END %]
|
|
</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
<style type="text/css">
|
|
.club-field,
|
|
.enrollment-field {
|
|
border-top: 1px solid #DDD;
|
|
}
|
|
</style>
|
|
</head>
|
|
|
|
<body id="clubs_templates_add_modify" class="clubs">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> › <a href="clubs.pl">Patron clubs</a> ›
|
|
[% IF club_template %]
|
|
Modify club template <i>[% club_template.name | html %]</i>
|
|
[% ELSE %]
|
|
Create a new club template
|
|
[% END %]
|
|
</div>
|
|
|
|
<div class="main container-fluid">
|
|
<div class="row">
|
|
<div class="col-md-8 col-md-offset-2">
|
|
|
|
<form method="post" class="validated">
|
|
<input type="hidden" name="id" value="[% club_template.id | html %]" />
|
|
|
|
<h2>
|
|
[% IF club_template %]
|
|
Modify club template <i>[% club_template.name | html %]</i>
|
|
[% ELSE %]
|
|
Create a new club template
|
|
[% END %]
|
|
</h2>
|
|
|
|
|
|
<fieldset class="rows">
|
|
<ol>
|
|
<li>
|
|
<label class="required" for="name">Name:</label>
|
|
<input id="club-template-name" name="name" type="text" value="[% club_template.name | html %]" required="required"/>
|
|
<span class="required">Required</span>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club-template-description">Description:</label>
|
|
<input id="club-template-description" name="description" type="text" value="[% club_template.description | html %]" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club-template-is-enrollable-from-opac">Allow public enrollment:</label>
|
|
[% IF club_template.is_enrollable_from_opac %]
|
|
<input type="checkbox" id="club-template-is-enrollable-from-opac" name="is_enrollable_from_opac" checked="checked" />
|
|
[% ELSE %]
|
|
<input type="checkbox" id="club-template-is-enrollable-from-opac" name="is_enrollable_from_opac" />
|
|
[% END %]
|
|
<span class="hint">If a template allows public enrollment, patrons can enroll in a club based on this template from the public catalog.</span>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club-template-is-email-required">Require valid email address:</label>
|
|
[% IF club_template.is_email_required %]
|
|
<input type="checkbox" id="club-template-is-email-required" name="is_email_required" checked="checked" />
|
|
[% ELSE %]
|
|
<input type="checkbox" id="club-template-is-email-required" name="is_email_required" />
|
|
[% END %]
|
|
<span class="hint">If set, a club based on this template can only be enrolled in by patrons with a valid email address.</span>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club-template-branchcode">Library:</label>
|
|
<select name="branchcode" id="club-template-branchcode">
|
|
<option value=""></option>
|
|
[% PROCESS options_for_libraries libraries => Branches.all( selected => club_template.branchcode ) %]
|
|
</select>
|
|
<div class="hint">If set, only librarians logged in with this branch will be able to modify this club template.</div>
|
|
</li>
|
|
|
|
</ol>
|
|
</fieldset>
|
|
|
|
<fieldset class="rows">
|
|
<legend>Club fields:</legend>
|
|
<p><span class="hint">These fields will be used in the creation of clubs based on this template</span></p>
|
|
<div id="club-template-fields">
|
|
[% FOREACH f IN club_template.club_template_fields %]
|
|
<div class="club-field">
|
|
<ol class="clearfix">
|
|
<input type="hidden" name="club_template_field_id" value="[% f.id | html %]" />
|
|
<li>
|
|
<label for="field-name-[% f.id | html %]">Name:</label>
|
|
<input name="club_template_field_name" id="field-name-[% f.id | html %]" value="[% f.name | html %]" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="field-description-[% f.id | html %]">Description:</label>
|
|
<input name="club_template_field_description" id="field-description-[% f.id | html %]" value="[% f.description | html %]" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="field-authorised-value-category-[% f.id | html %]">Authorised value category:</label>
|
|
<select name="club_template_field_authorised_value_category" id="field-authorised-value-category-[% f.id | html %]">
|
|
<option value=""></option>
|
|
[% PROCESS options_for_authorised_value_categories authorised_value_categories => AuthorisedValues.GetCategories( selected => f.authorised_value_category) %]
|
|
</select>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="field-delete-[% f.id | html %]">Delete field:</label>
|
|
<input type="checkbox" name="club_template_field_delete" id="field-delete-[% f.id | html %]" value="[% f.id | html %]" />
|
|
</li>
|
|
</ol>
|
|
</div>
|
|
[% END %]
|
|
</div>
|
|
<fieldset class="action">
|
|
<a href="#" onclick="$('#new-field-template').clone().attr('id','').show().appendTo('#club-template-fields'); return false;">
|
|
<i class="fa fa-plus"></i> Add new field
|
|
</a>
|
|
</fieldset>
|
|
</fieldset>
|
|
|
|
<fieldset class="rows">
|
|
<legend>Enrollment fields</legend>
|
|
<p><span class="hint">These fields will be used when enrolling a patron in a club based on this template</span></p>
|
|
<div id="club-template-enrollment-fields">
|
|
[% FOREACH f IN club_template.club_template_enrollment_fields %]
|
|
<div class="enrollment-field">
|
|
<ol class="clearfix">
|
|
<li>
|
|
<span class="label"> </span>
|
|
<strong>Enrollment field</strong>
|
|
</li>
|
|
<li>
|
|
<input type="hidden" name="club_template_enrollment_field_id" value="[% f.id | html %]" />
|
|
<label for="enrollment-field-name-[% f.id | html %]">Name:</label>
|
|
<input name="club_template_enrollment_field_name" id="enrollment-field-name-[% f.id | html %]" value="[% f.name | html %]" size="40" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="enrollment-field-description-[% f.id | html %]">Description:</label>
|
|
<input name="club_template_enrollment_field_description" id="enrollment-field-description-[% f.id | html %]" value="[% f.description | html %]" size="40" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="enrollment-field-authorised-value-category-[% f.id | html %]">Authorised value category:</label>
|
|
<select name="club_template_enrollment_field_authorised_value_category" id="enrollment-field-authorised-value-category-[% f.id | html %]">
|
|
<option value=""></option>
|
|
[% PROCESS options_for_authorised_value_categories authorised_value_categories => AuthorisedValues.GetCategories( selected => f.authorised_value_category) %]
|
|
</select>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="enrollment-field-delete-[% f.id | html %]">Delete field:</label>
|
|
<input type="checkbox" name="club_template_enrollment_field_delete" id="enrollment-field-delete-[% f.id | html %]" value="[% f.id | html %]" />
|
|
</li>
|
|
</ol>
|
|
</div>
|
|
[% END %]
|
|
</div>
|
|
<fieldset class="action">
|
|
<a href="#" onclick="$('#new-enrollment-field-template').clone().attr('id','').show().appendTo('#club-template-enrollment-fields'); return false;">
|
|
<i class="fa fa-plus"></i> Add new field
|
|
</a>
|
|
</fieldset>
|
|
</fieldset>
|
|
|
|
<fieldset class="action">
|
|
<input type="hidden" name="id" value="[% club_template.id | html %]" />
|
|
<input type="submit" value="Save" />
|
|
<a href="clubs.pl" class="cancel">Cancel</a>
|
|
</fieldset>
|
|
</form>
|
|
|
|
</div> <!-- /.col-md-8 .col-md-offset-2 -->
|
|
</div> <!-- /.row -->
|
|
|
|
|
|
<div id="new-field-template" class="club-field" style="display:none">
|
|
<h4 style="margin-left:1em;">New club field</h4>
|
|
<input type="hidden" name="club_template_field_id" value="" />
|
|
<ol class="clearfix">
|
|
|
|
<li>
|
|
<label for="club_template_field_name">Name:</label>
|
|
<input name="club_template_field_name" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club_template_field_description">Description:</label>
|
|
<input name="club_template_field_description" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club_template_field_authorised_value_category">Authorised value category:</label>
|
|
<select name="club_template_field_authorised_value_category">
|
|
<option value=""></option>
|
|
[% PROCESS options_for_authorised_value_categories authorised_value_categories => AuthorisedValues.GetCategories() %]
|
|
</select>
|
|
</li>
|
|
</ol>
|
|
<fieldset class="action"><a href="#" onclick="$(this).parent().parent().remove(); return false;"><i class="fa fa-trash"></i> Delete field</a></fieldset>
|
|
<hr/>
|
|
</div>
|
|
|
|
<div id="new-enrollment-field-template" class="enrollment-field" style="display:none">
|
|
<h4 style="margin-left:1em;">New enrollment field</h4>
|
|
<input type="hidden" name="club_template_enrollment_field_id" value="" />
|
|
<ol class="clearfix">
|
|
|
|
<li>
|
|
<label for="club_template_enrollment_field_name">Name:</label>
|
|
<input name="club_template_enrollment_field_name" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club_template_enrollment_field_description">Description:</label>
|
|
<input name="club_template_enrollment_field_description" />
|
|
</li>
|
|
|
|
<li>
|
|
<label for="club_template_enrollment_field_authorised_value_category">Authorised value category:</label>
|
|
<select name="club_template_enrollment_field_authorised_value_category">
|
|
<option value=""></option>
|
|
[% PROCESS options_for_authorised_value_categories authorised_value_categories => AuthorisedValues.GetCategories() %]
|
|
</select>
|
|
</li>
|
|
</ol>
|
|
<fieldset class="action"><a href="#" onclick="$(this).parent().parent().remove(); return false;"><i class="fa fa-trash"></i> Delete field</a></fieldset>
|
|
</div>
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|