Koha/misc/cronjobs
Nick Clemens 02a404ef42 Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl
The job reports errors when deleting items.

The issue seems to be that Koha::Object->delete claims in the POD to
return -1, 0, or 1 as a result, but it in fact returns the Object
itself on a successful deletion

The errors are reported as:
ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78)

To recreate:
 1 - Find or create a record with some items
 2 - Ensure those  items can be deleted (not on loan, etc.)
 3 - Edit the record leader and set position 5 to 'd'
 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm
 5 - Deletion succeeds, but reports failure on items
 6 - Apply patch
 7 - Find or create a new record as above, but this time add an
     additional item and check it out to a patron
 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v
 9 - Test mode should report 1 item to be deleted, one with error
10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm
11 - One item should be deleted, one item not, record not deleted
12 - check the item in
13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm
14 - Successful deletion with no error reported

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-28 11:16:14 +02:00
..
holds Bug 15986: move holds_reminder.pl to misc/cronjobs/holds/ 2021-04-16 14:34:51 +02:00
rss
social_data
thirdparty
advance_notices.pl Bug 11344: (QA follow-up) Fix empty section warning 2021-01-27 10:45:54 +01:00
archive_purchase_suggestions.pl
automatic_checkin.pl Bug 23207: Add automatic checkin feature 2021-04-22 11:11:05 +02:00
automatic_item_modification_by_age.pl
automatic_renewals.pl Bug 18532: (follow-up) fix messages and bug in automatic_renewals script 2021-03-16 16:08:31 +01:00
backup.sh
batch_anonymise.pl
build_browser_and_cloud.pl Bug 27491: Rename system preference opaclanguages to OPACLanguages 2021-01-22 14:59:27 +01:00
cart_to_shelf.pl
check-url-quick.pl
cleanup_database.pl Bug 15563: (follow-up) Combine methods, add count, obey confirm 2021-04-27 16:23:49 +02:00
cloud-kw.pl Bug 22824: Replace YAML::Syck with YAML::XS 2021-03-04 16:18:42 +01:00
cloud-sample.conf
CONFIGURE.gmail
create_koc_db.pl
crontab.example Bug 23207: (QA follow-up) Add to cron files 2021-04-22 11:11:05 +02:00
delete_items.pl
delete_patrons.pl Bug 28001: (QA follow-up) Clarify messages and indicate test mode 2021-04-16 12:28:17 +02:00
delete_records_via_leader.pl Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl 2021-04-28 11:16:14 +02:00
edi_cron.pl
fines.pl Bug 27835: (follow-up) Update language, remove warn, add feedback 2021-03-18 15:03:23 +01:00
gather_print_notices.pl
import_webservice_batch.pl
longoverdue.pl Bug 27656: misc/cronjobs/longoverdue.pl better error message 2021-04-16 16:20:47 +02:00
membership_expiry.pl
merge_authorities.pl
notice_unprocessed_suggestions.pl
overdue_notices.pl Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
patron_emailer.pl
plugins_nightly.pl Bug 27820: add all missing use in misc/cronjobs/plugins_nightly.pl 2021-03-11 16:38:04 +01:00
printoverdues.sh
process_message_queue.pl Bug 28221: Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it 2021-04-27 16:23:49 +02:00
purge_suggestions.pl
reconcile_balances.pl
remove_temporary_edifiles.pl
runreport.pl
serialsUpdate.pl Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
share_usage_with_koha_community.pl
sitemap.pl
staticfines.pl
stockrotation.pl Bug 28047: (QA follow-up) Fix a few more Callnumber entries 2021-04-06 15:56:31 +02:00
update_patrons_category.pl
update_totalissues.pl
writeoff_debts.pl Bug 27049: (QA follow-up) Add short params, replace warn with say 2021-04-12 15:27:50 +02:00