Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Galen Charlton cc2a62bdee Bug 10577: Improve semantics of GetBudgetPeriod() 
Remove the option to pass zero to this function in
order to get "the" active budget.  This was a problem
in three ways:

- Koha doesn't require that there be only one active
  budget at a time, so the concept of "the" active
  budget doesn't make sense.
- Having the single parameter be either an ID or a flag
  based on its value is poor function design.
- No callers of GetBudgetPeriod() were actually using this
  modality.

This patch also improves the DB-dependent tests for budgets by

- wrapping the test in a transaction
- counting budgets correctly

To test:

[1] Apply the patch.
[2] Verify that prove -v t/db_dependent/Budgets.t passes
[3] Verify in the staff interface that:
    - the budget hierarchy displays correctly
    - you can add and modify a budget

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-28 12:46:14 +00:00
..
Acquisition Bug 18736: Calculate tax depending on rounding 2019-03-21 16:29:06 +00:00
api/v1 Bug 18589: (follow-up) Add borrowernumber test 2019-03-22 20:21:49 +00:00
Auth Bug 22483: Restore undef behaviour 2019-03-08 15:53:10 -03:00
Authority
Biblio
Circulation Bug 22008: (follow-up) Additional fix for bad test 2019-03-27 15:04:59 +00:00
CourseReserves Bug 10382: Course reserves: handle empty values 2018-10-15 12:44:50 +00:00
Creators Bug 21281: (QA follow-up) Introduce _add_backtics 2018-09-26 15:22:57 +00:00
cronjobs Bug 20478: (QA follow-up) Make test more standard 2019-03-22 19:46:31 +00:00
data Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Exporter Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Holds Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs 2019-03-21 16:22:56 +00:00
Illrequest Bug 20750: Add unit tests 2019-03-15 19:07:08 +00:00
Items Bug 22219: Add tests 2019-03-15 12:36:11 +00:00
Koha Bug 22008: (follow-up) Additional test fix and fix typo 2019-03-27 13:13:48 +00:00
Labels Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
LDAP
Letters Bug 21999: Update Tests to reflect new return value of AddIssue 2019-01-11 13:05:52 +00:00
Members Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
OAI Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Patron Bug 13515: Add unit tests 2019-02-15 13:12:22 +00:00
Record Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Reports
Reserves Bug 21765: Regression tests 2019-02-27 09:14:21 -05:00
Search Bug 22048: Use set_password in tests 2019-01-25 20:15:31 +00:00
selenium Bug 18925: (QA follow-up) Fix basic_workflow.t 2019-03-05 20:42:22 +00:00
Serials Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
SIP Bug 22043: (QA follow-up) Add parameter to control behavior 2019-03-15 12:10:46 +00:00
Template/Plugin Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Utils Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
www Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests 2018-11-08 02:18:45 +00:00
XSLT_Handler
00-strict.t Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
01-test_dbic.t
Accounts.t Bug 22008: Fix failing tests 2019-03-27 12:34:38 +00:00
Acquisition.t Bug 22565: (QA follow-up) Fix test Acquisition.t 2019-03-25 12:12:53 +00:00
Amazon.t
ArticleRequests.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
AudioAlerts.t
Auth.t Bug 22048: Use set_password in tests 2019-01-25 20:15:31 +00:00
Auth_with_cas.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Auth_with_ldap.t Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-20 14:40:13 +00:00
AuthorisedValues.t
AuthoritiesMarc.t
BackgroundJob.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t Bug 21826: Add tests 2019-01-25 20:13:39 +00:00
Bookseller.t Bug 21817: Fix 2 failing tests 2019-01-02 20:18:30 +00:00
Breeding.t Bug 12747: Add extra column in Z3950 search 2018-10-01 13:56:26 +00:00
Budgets.t Bug 10577: Improve semantics of GetBudgetPeriod() 2019-03-28 12:46:14 +00:00
Calendar.t
Charset.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
check_kohastructure.t
check_sysprefs.t
Circulation.t Bug 22008: (follow-up) Additional test fix and fix typo 2019-03-27 13:13:48 +00:00
Clubs.t
ColumnsSettings.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Context.t
Contract.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
CourseReserves.t Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
db_structure.t
DecreaseLoanHighHolds.t Bug 22493: Clean up DecreaseLoanHighHolds.t 2019-03-15 12:17:59 +00:00
default_search_class.pl
Filter_MARC_ViewPolicy.t
Fines.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
FrameworkPlugin.t
Heading.t Bug 21826: Move Heading tests to db_dependent since they require database connection 2019-01-25 20:13:39 +00:00
Heading_MARC21.t
Hold.t Bug 21478: (QA follow-up) Make sure tests don't fail randomly 2019-01-28 16:06:26 +00:00
Holds.t Bug 22330: Fix tests 2019-03-22 13:06:49 +00:00
HoldsQueue.t Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs 2019-03-21 16:22:56 +00:00
Holidays.t
Illcomments.t Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
Illrequestattributes.t
Illrequests.t Bug 18837: (follow-up) Add additional tests 2019-03-15 19:33:36 +00:00
ILSDI_Services.t Bug 21683: Remove accountlines.accountno 2019-03-21 18:19:22 +00:00
Images.t Bug 21987: (RM follow-up) Add text for simple tests 2019-03-15 12:22:32 +00:00
ImportBatch.t
ImportExportFramework.t Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Installer.t
Items.t Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
Items_DelItemCheck.t Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
KitchenSinkPlugin.kpz
Koha.t
Koha_Authority.t
Koha_Database.t
Koha_ExternalContent_OverDrive.t Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent 2018-11-16 13:04:57 +00:00
Koha_ExternalContent_RecordedBooks.t Bug 17602: RecordedBooks Integration to Koha 2018-10-01 13:56:38 +00:00
Koha_Misc_Files.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Languages.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Letters.t Bug 21829: (QA follow-up) - Update the number of unit tests 2019-02-11 18:32:40 +00:00
LibraryGroups.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Members.t Bug 22052: Unit tests 2019-01-08 14:02:42 +00:00
MungeMarcPrice.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
NewsChannels.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Overdues.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Passwordrecovery.t
PatronLists.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Patrons.t
Plugins.t Bug 22084: Regression tests 2019-02-27 09:14:21 -05:00
QueryParser.t
Record.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t
Reports.t
Reserves.t Bug 22330: (QA follow-up) Fix number of tests in Reserves.t 2019-03-21 16:22:56 +00:00
rollingloans.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
RotatingCollections.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Search.t Bug 22416: (bug 22140 follow-up) Remove warnings in Search.t 2019-03-07 20:53:44 +00:00
Serials.t Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
Serials_2.t
Service.t
ShelfBrowser.t Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Sitemapper.t Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ 2018-11-08 02:18:48 +00:00
Stats.t Bug 21683: (follow-up) Remove last occurences of statistics.proccode 2019-03-21 18:19:23 +00:00
StockRotationItems.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
SuggestionEngine_ExplodedTerms.t
Suggestions.t Bug 21241: (follow-up) Syspref to control fallback to SMS when no email is defined 2019-01-28 11:42:31 +00:00
sysprefs.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Tags.t Bug 21846: Simplify ugly double for loops 2019-03-15 12:27:44 +00:00
Templates.t
TestBuilder.t Bug 15774: (follow-up) Fix TestBuilder.t so it doesn't catch wrong classes 2019-03-09 05:41:45 -03:00
Upload.t Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
UsageStats.t Bug 21226: Remove xISBN services 2018-08-16 13:20:22 +00:00
Virtualshelves.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
XISBN.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
XSLT_Handler.t
zebra_config.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00