Koha/opac/opac-request-article.pl
Marcel de Rooy cc316db0b1 Bug 20310: (follow-up) Check if biblio exists; 755 host_record.t
In order to prevent an error like:
Can't call method "host_record" on an undefined value at opac/opac-request-article.pl

Also chmod's host_record.t to 755 (File must have the exec flag)

Test plan:
Change the URL so that the biblionumber does not exist.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-12 15:47:34 +02:00

98 lines
3 KiB
Perl

#!/usr/bin/perl
# Copyright ByWater Solutions 2015
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Auth;
use C4::Output;
use Koha::Biblios;
use Koha::Patrons;
my $cgi = CGI->new;
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
{
template_name => "opac-request-article.tt",
query => $cgi,
type => "opac",
}
);
my $action = $cgi->param('action') || q{};
my $biblionumber = $cgi->param('biblionumber');
my $biblio = Koha::Biblios->find($biblionumber);
if( !$biblio ) {
print $cgi->redirect("/cgi-bin/koha/errors/404.pl");
exit;
}
if ( $action eq 'create' ) {
my $branchcode = $cgi->param('branchcode');
my $itemnumber = $cgi->param('itemnumber') || undef;
my $title = $cgi->param('title') || undef;
my $author = $cgi->param('author') || undef;
my $volume = $cgi->param('volume') || undef;
my $issue = $cgi->param('issue') || undef;
my $date = $cgi->param('date') || undef;
my $pages = $cgi->param('pages') || undef;
my $chapters = $cgi->param('chapters') || undef;
my $patron_notes = $cgi->param('patron_notes') || undef;
my $ar = Koha::ArticleRequest->new(
{
borrowernumber => $borrowernumber,
biblionumber => $biblionumber,
branchcode => $branchcode,
itemnumber => $itemnumber,
title => $title,
author => $author,
volume => $volume,
issue => $issue,
date => $date,
pages => $pages,
chapters => $chapters,
patron_notes => $patron_notes,
}
)->store();
print $cgi->redirect("/cgi-bin/koha/opac-user.pl#opac-user-article-requests");
exit;
} elsif ( !$action ) {
# Should we redirect?
# Conditions: no items, host item entry (MARC21 773)
my ( $host, $pageinfo ) = $biblio->host_record({ no_items => 1 });
if( $host ) {
$template->param( pageinfo => $pageinfo, title => $biblio->title, author => $biblio->author );
$biblio = $host;
}
}
my $patron = Koha::Patrons->find($borrowernumber);
$template->param(
biblio => $biblio,
patron => $patron,
action => $action
);
output_html_with_http_headers $cgi, $cookie, $template->output, undef, { force_no_caching => 1 };