df87f507d9
This patch adds information about cron jobs performed and make it viewable under Home > Tools > Logs ("Browse system logs") To test: Apply patch - Got to system preferences and set 'CronjobLog' to: [Log] information from cron jobs. - Run some cron jobs - Go to Home > Tools > Logs - Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it with Action "All" and Submit. - Output should show Date/time and info about Cron jobs Rebased to work on top of Bug 6911 (conflict in viewlog.tt) /MV Rebased after applying patch for Bug 6911 /MV Conflicts resolved: misc/cronjobs/overdue_notices.pl misc/cronjobs/cleanup_database.pl Signed-off-by: Frederic Demians <f.demians@tamil.fr> - Merge both patches, and fix updatedatabase.pl - Works as described. Provide intersting feedback from cronjob scripts. -- Modified version taking in account syspref CronJobLog. Handling simplified by introducing a convenience sub cronlogaction in C4/Log.pm /MV Amended to take in account comments #11, #12, #13 /MV http://bugs.koha-community.org/show_bug.cgi?id=13899 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
176 lines
4.4 KiB
Perl
Executable file
176 lines
4.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
|
|
use Pod::Usage;
|
|
use Getopt::Long;
|
|
|
|
use C4::Members;
|
|
use C4::VirtualShelves;
|
|
use Koha::DateUtils;
|
|
use C4::Log;
|
|
|
|
my ( $help, $verbose, $not_borrowed_since, $expired_before, $category_code,
|
|
$branchcode, $confirm );
|
|
GetOptions(
|
|
'h|help' => \$help,
|
|
'v|verbose' => \$verbose,
|
|
'not_borrowed_since:s' => \$not_borrowed_since,
|
|
'expired_before:s' => \$expired_before,
|
|
'category_code:s' => \$category_code,
|
|
'library:s' => \$branchcode,
|
|
'c|confirm' => \$confirm,
|
|
) || pod2usage(1);
|
|
|
|
if ($help) {
|
|
pod2usage(1);
|
|
}
|
|
|
|
$not_borrowed_since = dt_from_string( $not_borrowed_since, 'iso' )
|
|
if $not_borrowed_since;
|
|
|
|
$expired_before = dt_from_string( $expired_before, 'iso' )
|
|
if $expired_before;
|
|
|
|
unless ( $not_borrowed_since or $expired_before or $category_code or $branchcode ) {
|
|
pod2usage(q{At least one filter is mandatory});
|
|
exit;
|
|
}
|
|
|
|
cronlogaction();
|
|
|
|
my $members = GetBorrowersToExpunge(
|
|
{
|
|
not_borrowered_since => $not_borrowed_since,
|
|
expired_before => $expired_before,
|
|
category_code => $category_code,
|
|
branchcode => $branchcode,
|
|
}
|
|
);
|
|
|
|
unless ($confirm) {
|
|
say "Doing a dry run; no patron records will actually be deleted.";
|
|
say "Run again with --confirm to delete the records.";
|
|
}
|
|
|
|
say scalar(@$members) . " patrons to delete";
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
$dbh->{RaiseError} = 1;
|
|
$dbh->{PrintError} = 0;
|
|
|
|
$dbh->{AutoCommit} = 0; # use transactions to avoid partial deletes
|
|
my $deleted = 0;
|
|
for my $member (@$members) {
|
|
print "Trying to delete patron $member->{borrowernumber}... "
|
|
if $verbose;
|
|
|
|
my $borrowernumber = $member->{borrowernumber};
|
|
my $flags = C4::Members::patronflags( $member );
|
|
if ( my $charges = $flags->{CHARGES}{amount} ) {
|
|
say "Failed to delete patron $borrowernumber: patron has $charges in fines";
|
|
next;
|
|
}
|
|
|
|
eval {
|
|
C4::Members::MoveMemberToDeleted( $borrowernumber )
|
|
if $confirm;
|
|
};
|
|
if ($@) {
|
|
say "Failed to delete patron $borrowernumber, cannot move it: ($@)";
|
|
$dbh->rollback;
|
|
next;
|
|
}
|
|
eval {
|
|
C4::VirtualShelves::HandleDelBorrower( $borrowernumber )
|
|
if $confirm;
|
|
};
|
|
if ($@) {
|
|
say "Failed to delete patron $borrowernumber, error handling its lists: ($@)";
|
|
$dbh->rollback;
|
|
next;
|
|
}
|
|
eval { C4::Members::DelMember( $borrowernumber ) if $confirm; };
|
|
if ($@) {
|
|
say "Failed to delete patron $borrowernumber: $@)";
|
|
$dbh->rollback;
|
|
next;
|
|
}
|
|
$dbh->commit;
|
|
$deleted++;
|
|
say "OK" if $verbose;
|
|
}
|
|
|
|
say "$deleted patrons deleted";
|
|
|
|
=head1 NAME
|
|
|
|
delete_patrons - This script deletes patrons
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
delete_patrons.pl [-h|--help] [-v|--verbose] [-c|--confirm] [--not_borrowed_since=DATE] [--expired_before=DATE] [--category_code=CAT] [--library=LIBRARY]
|
|
|
|
Dates should be in ISO format, e.g., 2013-07-19, and can be generated
|
|
with `date -d '-3 month' "+%Y-%m-%d"`.
|
|
|
|
The options to select the patron records to delete are cumulative. For
|
|
example, supplying both --expired_before and --library specifies that
|
|
that patron records must meet both conditions to be selected for deletion.
|
|
|
|
=head1 OPTIONS
|
|
|
|
=over
|
|
|
|
=item B<-h|--help>
|
|
|
|
Print a brief help message
|
|
|
|
=item B<--not_borrowed_since>
|
|
|
|
Delete patrons who have not borrowed since this date.
|
|
|
|
=item B<--expired_before>
|
|
|
|
Delete patrons with an account expired before this date.
|
|
|
|
=item B<--category_code>
|
|
|
|
Delete patrons who have this category code.
|
|
|
|
=item B<--library>
|
|
|
|
Delete patrons in this library.
|
|
|
|
=item B<-c|--confirm>
|
|
|
|
This flag must be provided in order for the script to actually
|
|
delete patron records. If it is not supplied, the script will
|
|
only report on the patron records it would have deleted.
|
|
|
|
=item B<-v|--verbose>
|
|
|
|
Verbose mode.
|
|
|
|
=back
|
|
|
|
=head1 AUTHOR
|
|
|
|
Jonathan Druart <jonathan.druart@biblibre.com>
|
|
|
|
=head1 COPYRIGHT
|
|
|
|
Copyright 2013 BibLibre
|
|
|
|
=head1 LICENSE
|
|
|
|
This file is part of Koha.
|
|
|
|
Koha is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software
|
|
Foundation; either version 3 of the License, or (at your option) any later version.
|
|
|
|
You should have received a copy of the GNU General Public License along
|
|
with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
=cut
|