Main Koha release repository https://koha-community.org
Find a file
Lucas Gass cca2fa2396 Bug 35535: Allow for cancellation of holds with or without a reason
TO TEST:
1. Have a waiting hold on a particular barcode
2. Have at least 1 HOLD_CANCELLATION auth value
3. Check in the barcode and try to cancel the hold on the modal while
   selecting a reason.
=> SUCCESS: You can cancel a hold when selecting a reason.
4. Repeat 1-3 but not selecting any reason.
=> SUCCESS: Hold cancelled correctly.
5. Delete all HOLD_CANCELLATION auth values.
6. Repeat Try 1-3
=> SUCCESS: No reason displayed
=> FAIL: Cancelling does nothing. There's an error in the browser
   inspector
7. Apply this patch
8. Repeat 1-3
=> SUCCESS: No reason displayed
=> SUCCESS: Cancelling works
9. Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: amended the test plan to make it clearer
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit c1bf46d1e7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2024-02-01 16:20:45 +01:00
acqui Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage 2024-01-15 15:22:24 +01:00
admin Bug 35460: Fix add and edit of hold rules in circulation rules table 2023-12-11 21:44:27 -10:00
api Bug 35744: Implement +strings for GET /patrons/:patron_id 2024-02-01 15:41:21 +01:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-15 15:50:43 -03:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2024-01-03 15:48:28 +01:00
C4 Bug 35833: Silence few warnings from searching 2024-02-01 15:06:57 +01:00
catalogue Bug 34913: Adjust item search 2024-01-29 10:15:54 +01:00
cataloguing Bug 35774: Use itemnumber instead of biblioitemnumber 2024-02-01 16:08:27 +01:00
circ Bug 25835: Include overdues with fines in overdues_report permission 2024-01-15 15:17:43 +01:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves
debian Bug 30627: Verify --days parameter and use find command to select old backups for deletion 2024-01-31 14:04:52 +01:00
docs Bug 35504: Split list of ERM Topic experts 2024-01-15 15:23:22 +01:00
erm
errors
etc Bug 35086: (follow-up) Use 5000 as example in conf file 2024-01-17 10:22:47 +01:00
ill Bug 30719: ILL Batches 2023-10-17 14:45:15 -03:00
installer Bug 34979: DBRev 23.11.02.002 2024-01-31 14:11:16 +01:00
Koha Bug 35744: Implement +strings for GET /patrons/:patron_id 2024-02-01 15:41:21 +01:00
koha-tmpl Bug 35535: Allow for cancellation of holds with or without a reason 2024-02-01 16:20:45 +01:00
labels Bug 10762: (QA follow-up) Perltidy 2023-10-25 10:35:31 -03:00
lib/CGI/Session/Serialize
members Bug 30287: Conditionally render notice preview 2024-01-03 16:03:42 +01:00
misc Bug 35596: Error in writeoff_debts documentation 2024-02-01 14:48:07 +01:00
offline_circ Bug 34529: Offline circulation should be able to accept userid as well as cardnumber 2023-11-06 11:34:44 -03:00
opac Bug 35445: Require OPAC user to confirm self-registration with button push 2024-02-01 15:54:02 +01:00
patron_lists Bug 34977: (QA follow-up) Tidy code 2023-11-08 11:41:33 -03:00
patroncards
plugins Bug 25672: Fix double output_html_with_http_headers 2023-10-31 11:02:45 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 34456: (QA follow-up) perltidy code 2023-11-01 17:23:18 -03:00
reserve Bug 34519: Add a template plugin for fetch searchable patron attributes 2023-11-08 17:52:37 -03:00
reviews
rotating_collections
serials Bug 28012: Use definedness test instead of bool when checking whether to null fields 2024-01-03 17:27:11 +01:00
services
skel
suggestion Bug 35276: Remove authentication params from suggestion hash 2023-11-14 10:32:38 -03:00
svc Bug 34913: Adjust C4::Utils::DataTables::VirtualShelves 2024-01-29 10:15:53 +01:00
t Bug 35744: Implement +strings for GET /patrons/:patron_id 2024-02-01 15:41:21 +01:00
tags
tools Bug 35817: Fix hint on patron's category when batch update patron 2024-01-31 14:38:01 +01:00
virtualshelves Bug 35547: Show public "staff only" lists in addbybiblionumber.pl 2024-01-03 16:36:51 +01:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-04 09:15:35 -04:00
.editorconfig
.eslintrc.json
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
.stylelintrc.json
about.pl Bug 35504: Distinguish different RMaint and Topic Expert roles 2024-01-15 15:23:22 +01:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 34064: Add SQL::Translator dependency to cpanfile 2023-10-10 10:54:04 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2024-01-03 14:16:31 +01:00
help.pl
INSTALL
Koha.pm Bug 34979: DBRev 23.11.02.002 2024-01-31 14:11:16 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-20 17:22:02 -03:00
Makefile.PL Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module 2024-01-17 10:06:28 +01:00
MANIFEST.SKIP
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js Bug 30708: Vue app 2023-10-18 15:41:40 -03:00
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo