Tomas Cohen Arazi
253dbb758a
This patch moves the Koha::Patrons->merge method into Koha::Patron->merge_with in the line of the discussed implementation for bug 15336. I agree with that implementation so I provide this follow-up. Tests are adjusted, the controller script is adapted too. The behaviour remains. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
108 lines
3.5 KiB
Perl
Executable file
108 lines
3.5 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 17;
|
|
use Test::Warn;
|
|
|
|
use C4::Context;
|
|
use Koha::Database;
|
|
use Koha::DateUtils;
|
|
|
|
use t::lib::Dates;
|
|
use t::lib::TestBuilder;
|
|
|
|
BEGIN {
|
|
use_ok('Koha::Objects');
|
|
use_ok('Koha::Patrons');
|
|
}
|
|
|
|
# Start transaction
|
|
my $database = Koha::Database->new();
|
|
my $schema = $database->schema();
|
|
$schema->storage->txn_begin();
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
my $categorycode = $builder->build({ source => 'Category' })->{categorycode};
|
|
my $branchcode = $builder->build({ source => 'Branch' })->{branchcode};
|
|
|
|
my $b1 = Koha::Patron->new(
|
|
{
|
|
surname => 'Test 1',
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode
|
|
}
|
|
);
|
|
$b1->store();
|
|
my $now = dt_from_string;
|
|
my $b2 = Koha::Patron->new(
|
|
{
|
|
surname => 'Test 2',
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode
|
|
}
|
|
);
|
|
$b2->store();
|
|
my $three_days_ago = dt_from_string->add( days => -3 );
|
|
my $b3 = Koha::Patron->new(
|
|
{
|
|
surname => 'Test 3',
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
updated_on => $three_days_ago,
|
|
}
|
|
);
|
|
$b3->store();
|
|
|
|
my $b1_new = Koha::Patrons->find( $b1->borrowernumber() );
|
|
is( $b1->surname(), $b1_new->surname(), "Found matching patron" );
|
|
isnt( $b1_new->updated_on, undef, "borrowers.updated_on should be set" );
|
|
is( t::lib::Dates::compare( $b1_new->updated_on, $now), 0, "borrowers.updated_on should have been set to now on creating" );
|
|
|
|
my $b3_new = Koha::Patrons->find( $b3->borrowernumber() );
|
|
is( t::lib::Dates::compare( $b3_new->updated_on, $three_days_ago), 0, "borrowers.updated_on should have been kept to what we set on creating" );
|
|
$b3_new->set({ firstname => 'Some first name for Test 3' })->store();
|
|
$b3_new = Koha::Patrons->find( $b3->borrowernumber() );
|
|
is( t::lib::Dates::compare( $b3_new->updated_on, $now), 0, "borrowers.updated_on should have been set to now on updating" );
|
|
|
|
my @patrons = Koha::Patrons->search( { branchcode => $branchcode } );
|
|
is( @patrons, 3, "Found 3 patrons with Search" );
|
|
|
|
my $unexistent = Koha::Patrons->find( '1234567890' );
|
|
is( $unexistent, undef, 'Koha::Objects->Find should return undef if the record does not exist' );
|
|
|
|
my $patrons = Koha::Patrons->search( { branchcode => $branchcode } );
|
|
is( $patrons->count( { branchcode => $branchcode } ), 3, "Counted 3 patrons with Count" );
|
|
|
|
my $b = $patrons->next();
|
|
is( $b->surname(), 'Test 1', "Next returns first patron" );
|
|
$b = $patrons->next();
|
|
is( $b->surname(), 'Test 2', "Next returns second patron" );
|
|
$b = $patrons->next();
|
|
is( $b->surname(), 'Test 3', "Next returns third patron" );
|
|
$b = $patrons->next();
|
|
is( $b, undef, "Next returns undef" );
|
|
|
|
# Test Reset and iteration in concert
|
|
$patrons->reset();
|
|
foreach my $b ( $patrons->as_list() ) {
|
|
is( $b->categorycode(), $categorycode, "Iteration returns a patron object" );
|
|
}
|
|
|
|
$schema->storage->txn_rollback();
|
|
|