Kyle M Hall b59f8701af Bug 35322: Fix the logic for checking for holds in CanBookBeIssued ... We are having reports that AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued, the ignore reserves check was changed from "check reserves unless the ignore reserves flag was passed" to "check reserves unless the ignore reserves flag was passed *and* we have a recall". I think this was a logic mistake and we want to check reserves unless we have an ignore flag *or* there is a recall. Test Plan: 1) Enable AllowItemsOnHoldCheckoutSCO 2) Place a hold on an item 3) Attempt to check that item out to another patron 4) Note the checkout is blocked 5) Apply this patch 6) Restart all the things! 7) Attempt the checkout again 8) The checkout now succeeds! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> (cherry picked from commit 9b10f69ee3) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commit c279c31daf) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>		2024-02-02 17:56:31 +00:00
..
AuthoritiesMarc
Barcodes	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
ClassSortRoutine
ClassSplitRoutine
Creators	Bug 32222: Fix capitalization in various "id is invalid"	2023-02-07 10:29:35 -03:00
External
Form
Heading	Bug 21828: build $bib_heading_fields only once per invocation	2023-09-22 10:36:33 -10:00
ILSDI	Bug 34950: Add availability statuses for in transit and on hold items.	2024-02-02 17:54:40 +00:00
Installer	Bug 30731: Remove Readonly::XS::MAGIC_COOKIE	2022-06-01 16:15:26 -03:00
Labels	Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record	2022-07-22 15:24:11 -03:00
Linker	Bug 30280: Add support for subject headings from different thesaurus when using Elasticsearch	2022-10-03 10:00:04 -03:00
Members
OAI	Bug 30308: Fix bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)	2022-07-29 15:43:39 -03:00
Output
Patroncards	Bug 34532: Silence warns in Patroncard.pm	2023-09-17 21:35:44 -10:00
Reports	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
Search	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
Serials
SIP	Bug 22873: Add comment to explain what disallow_overpayment is for	2023-10-05 10:21:54 -10:00
Utils
Accounts.pm	Bug 29184: Fix warn about undefined replacecost	2022-09-08 10:50:30 -07:00
Acquisition.pm	Bug 11844: Use additional fields for order lines	2023-05-16 12:58:38 +02:00
Auth.pm	Bug 34893: Unit tests for C4::Auth::checkpw	2024-01-24 17:33:44 +00:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm	Bug 34893: (QA follow-up) Tidy code for qa script	2024-01-24 17:33:44 +00:00
Auth_with_ldap.pm	Bug 34893: ILS-DI can return the wrong patron for AuthenticatePatron	2024-01-24 17:33:44 +00:00
Auth_with_shibboleth.pm	Bug 34893: ILS-DI can return the wrong patron for AuthenticatePatron	2024-01-24 17:33:44 +00:00
AuthoritiesMarc.pm	Bug 35702: Fetch biblios at once and loop	2024-02-02 16:31:03 +00:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm	Bug 34014: (follow-up) Tidy	2023-10-25 11:58:37 -10:00
Breeding.pm	Bug 33404: Fix serverhost and init $page	2023-07-17 16:33:29 +01:00
Budgets.pm	Bug 27550: "Duplicate budget" does not keep users associated with that budget	2022-09-22 08:18:33 -03:00
Calendar.pm	Bug 32048: Added clear cache routine to delete_holiday_range_repeatable	2023-09-18 11:45:38 -10:00
Charset.pm
Circulation.pm	Bug 35322: Fix the logic for checking for holds in CanBookBeIssued	2024-02-02 17:56:31 +00:00
ClassSortRoutine.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
ClassSource.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
ClassSplitRoutine.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
Context.pm	Bug 32478: (QA follow-up) Keep current hashref behavior	2023-06-09 16:05:07 -03:00
Contract.pm
CourseReserves.pm	Bug 30016: Remove GetOpenIssue subroutine	2022-08-31 08:50:37 -03:00
Creators.pm
Heading.pm	Bug 33557: Add LinkerConsiderThesaurus system preference	2023-05-10 15:26:26 -03:00
HoldsQueue.pm	Bug 34678: Allow new entries to overwrite hold_fill_targets	2023-11-07 21:37:08 -10:00
HTML5Media.pm
ImportBatch.pm	Bug 35438: Remove skip_intermediate_commit parameter	2024-02-02 17:47:39 +00:00
ImportExportFramework.pm
InstallAuth.pm
Installer.pm	Bug 34174: (bug 33341 follow-up) Fix Ris export	2023-07-17 16:43:20 +01:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf	2023-09-17 22:03:55 -10:00
Koha.pm	Bug 33341: Address some perlcritic errors in 5.36	2023-03-28 14:50:33 +02:00
Labels.pm
Languages.pm	Bug 32775: (QA follow-up) Fix tab and indenting issues	2023-05-15 18:23:54 -03:00
Letters.pm	Bug 34731: Use Koha::Notice::Message in EnqueueLetter	2023-09-14 07:54:48 -10:00
Linker.pm
Log.pm	Bug 32057: (QA follow-up) Remove pretty flag	2023-03-14 08:49:34 -03:00
MarcModificationTemplates.pm
Matcher.pm	Bug 26611: Make authority record matching use required match checks	2023-05-24 11:21:31 -03:00
Members.pm	Bug 33937: Remove incorrect export in C4::Members	2023-07-12 08:07:53 +01:00
Message.pm	Bug 18398: (follow-up) Update POD & Unit tests	2023-03-31 13:13:35 +02:00
Output.pm	Bug 30524: Core CSRF checking code	2023-07-28 09:12:39 -10:00
Overdues.pm	Bug 34279: Don't enforce overduefinescap unless it is greater than 0	2023-08-07 20:05:46 -10:00
Patroncards.pm
Record.pm	Bug 35588: Scope authorised value desc lookup according to field/subfield	2024-01-12 22:05:02 +00:00
Reports.pm
Reserves.pm	Bug 35491: Add logging to RevertWaitingStatus	2024-01-04 20:48:14 +00:00
Ris.pm	Bug 34174: (bug 33341 follow-up) Fix Ris export	2023-07-17 16:43:20 +01:00
RotatingCollections.pm	Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines	2023-05-12 12:40:21 -03:00
Scheduler.pm
Scrubber.pm
Search.pm	Bug 33725: (follow-up) Add ccode to grouping logic	2023-06-09 16:05:10 -03:00
Serials.pm	Bug 23775: Claiming a serial issue doesn't create the next one	2023-07-17 15:55:19 +01:00
Service.pm
ShelfBrowser.pm	Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record	2022-07-22 15:24:11 -03:00
SMS.pm
SocialData.pm
Stats.pm	Bug 30928: Add interface to statistics	2023-05-10 14:19:22 -03:00
Suggestions.pm	Bug 33236: (follow-up) Remove export of NewSuggestion	2023-06-09 12:04:47 -03:00
Tags.pm	Bug 31517: (QA follow-up) Fix indentation	2022-11-04 19:30:56 -03:00
Templates.pm	Bug 35070: Tidy	2024-01-12 22:16:25 +00:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm	Bug 33961: Remove built-in offline circ tool	2023-07-17 08:18:59 +01:00
XISBN.pm	Bug 30813: (QA follow-up) Adjust three use statements	2022-06-08 11:40:32 -03:00
XSLT.pm	Bug 33567: Remove hardcoded fallback in module	2023-05-12 11:22:42 -03:00