Kyle M Hall 8b04a3f642 Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used ... Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules. Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value. Test Plan: 1) Check out Koha 22.05.05 2) Create a default all/all/all rule, 3 other rules. Ensure they all have Loan period set to 7, with one of the non-default rules having a Loan period of 14. 3) Delete all but one of the non-default rules with the following query: Delete from circulation_rules where rule_name = 'issuelength' and ( rule_value != 14 and not ( branchcode is null and categorycode is null and itemtype is null ) ) limit 2; 4) Check out 254f721320 5) Run updatedatabase.pl and restart 6) Note the rules were recreated with the value 0 7) Repeat steps 1-4 8) Apply this patch 9) If you're using the same database, set the version to 22.0600023 and restart 10) Run updatedatabase.pl 11) Note the rules were recreated, but the value is the derived value from the all/all/all rule! Signed-off-by: Kevin Carnes <kevin.carnes@ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Bug 33847: Rewrite to use SQL Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Squashed, and added reference to new bug too Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> (cherry picked from commit f6f2d1ae41) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>		2024-01-03 16:07:41 +01:00
..
data/mysql	Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used	2024-01-03 16:07:41 +01:00
externalmodules.pl
install.pl	Bug 33720: Also flush in install	2023-07-03 10:35:04 -03:00
onboarding.pl	Bug 8367: Add holds_pickup_period circulation rule	2023-11-01 18:01:30 -03:00