Jonathan Druart
5c7ff786d5
This patch removes 3 subroutines from C4::Letters: - getalert - addalert - delalert And add 3 methods to Koha::Subscription: - subscribers - add_subscriber - remove_subscriber It makes the code cleaner for future cleanup. TODO - we should remove alert.alertid and alert.type, and rename alert.externalid with alert.subscriptionid That way alert will be renamed borrowers_subscriptions (or similar) and will become a simple join table between borrowers and subscriptions. We will need to deal with FK that could not be satisfied. Let's do that after this patch is pushed. Test plan: Subscribe and unsubscribe to email notifications sent when a new issues is available. Make sure everything works as before and you receive the emails. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
121 lines
4 KiB
Perl
Executable file
121 lines
4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Koha;
|
|
use C4::Serials;
|
|
use C4::Letters;
|
|
use C4::Output;
|
|
use C4::Context;
|
|
|
|
my $query = new CGI;
|
|
my $op = $query->param('op');
|
|
my $dbh = C4::Context->dbh;
|
|
my $selectview = $query->param('selectview');
|
|
$selectview = C4::Context->preference("SubscriptionHistory") unless $selectview;
|
|
|
|
my $sth;
|
|
|
|
# my $id;
|
|
my ( $template, $loggedinuser, $cookie );
|
|
my $biblionumber = $query->param('biblionumber');
|
|
if ( $selectview eq "full" ) {
|
|
( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-full-serial-issues.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => 1,
|
|
debug => 1,
|
|
}
|
|
);
|
|
my $subscriptions = GetFullSubscriptionsFromBiblionumber($biblionumber);
|
|
my $subscriptioninformation=PrepareSerialsData($subscriptions);
|
|
# PrepareSerialsData does some bogus stuff that the template could handle
|
|
# But at least it sorts the array by the year field so we dont have to
|
|
# find 'manage' if its there
|
|
if ($subscriptioninformation->[0]->{year} eq 'manage') {
|
|
shift @{$subscriptioninformation};
|
|
}
|
|
|
|
# now, check is there is an alert subscription for one of the subscriptions
|
|
if ($loggedinuser) {
|
|
foreach (@$subscriptions) {
|
|
my $subscription = Koha::Subscriptions->find( $_->{subscriptionid} );
|
|
my $subscriber = $subscription->subscribers->find( $loggedinuser );
|
|
$_->{hasalert} = 1 if $subscriber;
|
|
}
|
|
}
|
|
|
|
my $title = $subscriptions->[0]->{bibliotitle};
|
|
my $yearmin = $subscriptions->[0]->{year};
|
|
my $yearmax = $subscriptions->[ -1 ]->{year};
|
|
|
|
# replace CR by <br> in librarian note
|
|
# $subscription->{opacnote} =~ s/\n/\<br\/\>/g;
|
|
|
|
$template->param(
|
|
biblionumber => scalar $query->param('biblionumber'),
|
|
years => $subscriptioninformation,
|
|
yearmin => $yearmin,
|
|
yearmax => $yearmax,
|
|
bibliotitle => $title,
|
|
suggestion => C4::Context->preference("suggestion"),
|
|
virtualshelves => C4::Context->preference("virtualshelves"),
|
|
);
|
|
|
|
}
|
|
else {
|
|
( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-serial-issues.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => 1,
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $subscriptions = GetSubscriptionsFromBiblionumber($biblionumber);
|
|
# now, check is there is an alert subscription for one of the subscriptions
|
|
if ($loggedinuser) {
|
|
foreach (@$subscriptions) {
|
|
my $subscription = Koha::Subscriptions->find( $_->{subscriptionid} );
|
|
my $subscriber = $subscription->subscribers->find( $loggedinuser );
|
|
$_->{hasalert} = 1 if $subscriber;
|
|
}
|
|
}
|
|
|
|
# replace CR by <br> in librarian note
|
|
# $subscription->{opacnote} =~ s/\n/\<br\/\>/g;
|
|
|
|
my $title = $subscriptions->[0]->{bibliotitle};
|
|
|
|
$template->param(
|
|
biblionumber => scalar $query->param('biblionumber'),
|
|
subscription_LOOP => $subscriptions,
|
|
bibliotitle => $title,
|
|
);
|
|
}
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|