252f4674a5
So far the administration module only allowed for 2 permissions:
- circulation conditions (manage_circ_rules)
- everything else (parameters_remaining_permissions)
With this patch almost every section of the administration page
will have its own granular permission.
To test:
- Create different staff users:
1) One with parameters_remaining_permissions
2) One with parameters
3) One with catalogue and no parameters
4) One superlibrarian
- Apply the patch
- Run the database update
- Check the staff users:
1) All subpermissions, but manage_circ_rules
should be checked
2) Nothing should have changed
3) manage_item_serach_fields shoudl be checked
(page had catalogue permission before)
4) Nothing should have changed
- Try different settings of the permissions and
verify that
- Administration page behaves correctly
- Administration menu behaves correctly
! You shoudl only see what you have permission for
https://bugs.koha-community.org/show_bug.cgi?id=14391
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
62 lines
1.7 KiB
Perl
Executable file
62 lines
1.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
use CGI;
|
|
use YAML qw( LoadFile );
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
use C4::Output;
|
|
use C4::Utils::DataTables::ColumnsSettings qw( get_modules );
|
|
my $input = new CGI;
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "admin/columns_settings.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { parameters => 'manage_column_config' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $action = $input->param('action') // 'list';
|
|
|
|
if ( $action eq 'save' ) {
|
|
my $module = $input->param('module');
|
|
my @columnids = $input->multi_param("columnid");
|
|
my @columns;
|
|
for my $columnid (@columnids) {
|
|
next unless $columnid =~ m|^([^#]*)#([^#]*)#(.*)$|;
|
|
my $is_hidden = $input->param( $columnid . '_hidden' ) // 0;
|
|
my $cannot_be_toggled =
|
|
$input->param( $columnid . '_cannot_be_toggled' ) // 0;
|
|
push @columns,
|
|
{
|
|
module => $module,
|
|
page => $1,
|
|
tablename => $2,
|
|
columnname => $3,
|
|
is_hidden => $is_hidden,
|
|
cannot_be_toggled => $cannot_be_toggled,
|
|
};
|
|
}
|
|
|
|
C4::Utils::DataTables::ColumnsSettings::update_columns(
|
|
{
|
|
columns => \@columns,
|
|
}
|
|
);
|
|
|
|
$action = 'list';
|
|
}
|
|
|
|
if ( $action eq 'list' ) {
|
|
my $modules = C4::Utils::DataTables::ColumnsSettings::get_modules;
|
|
$template->param(
|
|
panel => ( $input->param('panel') || 0 ),
|
|
modules => $modules,
|
|
);
|
|
}
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|