ed7543287b
Having to write [% KOHA_VERSION %] for each url is bad because: - It's easily forgettable when adding new <script> or <link> - It prevents grep'ing for the full filename - It violates the DRY principle - If at some point we want to change the "force js and css reload" mechanism, it will be tedious This patch: - adds a Template::Toolkit plugin that generates <script> and <link> tags for JS and CSS files, and inserts automatically the Koha version in the filename - use the new plugin to remove all occurences of [% KOHA_VERSION %] - remove the code that was adding KOHA_VERSION as a template variable Test plan: 1. Apply patch 2. Go to several different pages in Koha (opac and intranet) while checking your browser's dev tools (there should be no 404 for JS and CSS files, and the Koha version should appear in filenames) and the server logs (there should be no "File not found") 3. `git grep KOHA_VERSION` should return nothing 4. prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
120 lines
4.6 KiB
Text
120 lines
4.6 KiB
Text
[% USE Asset %]
|
|
[% SET footerjs = 1 %]
|
|
[% USE AuthorisedValues %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › Item search fields</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="admin_itemssearchfields" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
<div id="breadcrumbs">
|
|
<a href="/cgi-bin/koha/mainpage.pl">Home</a> ›
|
|
<a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> ›
|
|
Item search fields
|
|
</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
<div id="toolbar" class="btn-toolbar">
|
|
<a class="btn btn-default btn-sm" id="new_search_field" href="/cgi-bin/koha/admin/items_search_fields.pl"><i class="fa fa-plus"></i> New search field</a>
|
|
</div>
|
|
|
|
[% IF field_added %]
|
|
<div class="dialog message">
|
|
Field successfully added: [% field_added.label |html %]
|
|
</div>
|
|
[% ELSIF field_not_added %]
|
|
<div class="dialog alert">
|
|
<p>Failed to add field. Please make sure the field name doesn't already exist.</p>
|
|
<p>Check logs for more details.</p>
|
|
</div>
|
|
[% ELSIF field_deleted %]
|
|
<div class="dialog message">
|
|
Field successfully deleted.
|
|
</div>
|
|
[% ELSIF field_not_deleted %]
|
|
<div class="dialog alert">
|
|
<p>Failed to delete field.</p>
|
|
<p>Check logs for more details.</p>
|
|
</div>
|
|
[% ELSIF field_updated %]
|
|
<div class="dialog message">
|
|
Field successfully updated: [% field_updated.label %]
|
|
</div>
|
|
[% ELSIF field_not_updated %]
|
|
<div class="dialog alert">
|
|
<p>Failed to update field.</p>
|
|
<p>Check logs for more details.</p>
|
|
</div>
|
|
[% END %]
|
|
[% IF fields.size %]
|
|
<div id="search_fields_list">
|
|
<h2>Item search fields</h2>
|
|
|
|
<table id="search_fields_table">
|
|
<thead>
|
|
<tr>
|
|
<th>Name</th>
|
|
<th>Label</th>
|
|
<th>MARC field</th>
|
|
<th>MARC subfield</th>
|
|
<th>Authorised values category</th>
|
|
<th>Actions</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
[% FOREACH field IN fields %]
|
|
<tr>
|
|
<td>[% field.name |html %]</td>
|
|
<td>[% field.label |html %]</td>
|
|
<td>[% field.tagfield %]</td>
|
|
<td>[% field.tagsubfield %]</td>
|
|
<td>[% field.authorised_values_category %]</td>
|
|
<td>
|
|
<a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/items_search_field.pl?name=[% field.name |html %]" title="Edit [% field.name |html %] field"><i class="fa fa-pencil"></i> Edit</a>
|
|
<a class="field-delete btn btn-default btn-xs" href="/cgi-bin/koha/admin/items_search_fields.pl?op=del&name=[% field.name |html %]"><i class="fa fa-trash"></i> Delete</a>
|
|
</td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
[% ELSE %]
|
|
<div class="dialog message">
|
|
There are no item search fields defined.
|
|
</div>
|
|
[% END %]
|
|
|
|
<form id="add_field_form" action="/cgi-bin/koha/admin/items_search_fields.pl" method="POST" class="validated">
|
|
<fieldset class="rows">
|
|
<legend>Add a new field</legend>
|
|
[% INCLUDE 'admin-items-search-field-form.inc' field=undef %]
|
|
<input type="hidden" name="op" value="add" />
|
|
</fieldset>
|
|
<fieldset class="action">
|
|
<input type="submit" value="Submit" />
|
|
<a href="#" class="cancel">Cancel</a>
|
|
</fieldset>
|
|
</form>
|
|
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/admin-menu.js") %]
|
|
<script type="text/javascript">
|
|
var MSG_ITEM_SEARCH_DELETE_CONFIRM = _("Are you sure you want to delete this field?");
|
|
</script>
|
|
[% Asset.js("js/item_search_fields.js") %]
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|