dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
131 lines
8.1 KiB
Text
131 lines
8.1 KiB
Text
[% USE Koha %]
|
|
[% USE KohaDates %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Web installer › Add a patron category</title>
|
|
[%# The following if statement checks if the categories variable handed to this template %]
|
|
[%# by onboarding.pl has data in it. If the categories variable does have data %]
|
|
[%# in it this means that the user has previously imported sample patron category %]
|
|
[%# data and so we do not need to show them the create patron category screen 1, %]
|
|
[%#instead we can display a screen with ubtton redirecting the user to step 3 %]
|
|
[% IF (categories && categories.count > 1 ) %]
|
|
<meta http-equiv="refresh" content="0; url=/cgi-bin/koha/installer/onboarding.pl?step=3">
|
|
[% END %]
|
|
[% INCLUDE 'installer-doc-head-close.inc' %]
|
|
[% INCLUDE 'validator-strings.inc' %]
|
|
[% INCLUDE 'installer-strings.inc' %]
|
|
<script type="text/javascript" src="[% interface | html %]/[% theme | html %]/js/onboarding.js"></script>
|
|
</head>
|
|
|
|
<body id="installer" class="installer">
|
|
<div class="container-fluid">
|
|
<div class="row">
|
|
<div id="onboarding-step2" class="installer-main col-sm-8 col-sm-offset-2 col-md-8 col-md-offset-2">
|
|
<h1 id="logo"><a href="#">Koha</a></h1>
|
|
|
|
<h2>Web installer › Create a patron category</h2>
|
|
|
|
[% INCLUDE 'onboarding_messages.inc' %]
|
|
|
|
<p> The patron category you create will be used by the <span class="bg-info">administrator account</span>.</p>
|
|
|
|
<form id="category_form" method="post" action="onboarding.pl">
|
|
<fieldset class="rows">
|
|
<input type="hidden" name="step" value="2" />
|
|
<input type="hidden" name="op" value="add_validate_category" />
|
|
<ol>
|
|
<li>
|
|
<label for="categorycode" class="required">Category code: </label>
|
|
<input type="text" pattern="[0-9A-Za-z]{1,10}" id="categorycode" name="categorycode" value="[% category.categorycode | html %]" size="10" maxlength="10" class="required" required="required" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="description" class="required">Description: </label>
|
|
<input type="text" id="description" name="description" size="40" maxlength="80" class="required" required="required" value="[% category.description | html %]" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="overduenoticerequired">Overdue notice required: </label>
|
|
<select name="overduenoticerequired" id="overduenoticerequired">
|
|
[% IF category.overduenoticerequired %]
|
|
<option value="0">No</option>
|
|
<option value="1" selected="selected">Yes</option>
|
|
[% ELSE %]
|
|
<option value="0" selected="selected">No</option>
|
|
<option value="1">Yes</option>
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
|
|
<li>
|
|
<span class="label">Category type: </span>
|
|
<input type="hidden" name="category_type" value="S" />
|
|
Staff
|
|
</li>
|
|
|
|
<li>
|
|
<label for="default_privacy">Default privacy: </label>
|
|
<select id="default_privacy" name="default_privacy" required="required">
|
|
[% SET default_privacy = 'default' %]
|
|
|
|
[% IF category %]
|
|
[% SET default_privacy = category.default_privacy %]
|
|
[% END %]
|
|
|
|
[% SWITCH default_privacy %]
|
|
[% CASE 'forever' %]
|
|
<option value="default">Default</option>
|
|
<option value="never">Never</option>
|
|
<option value="forever" selected="selected">Forever</option>
|
|
[% CASE 'never' %]
|
|
<option value="default">Default</option>
|
|
<option value="never" selected="selected">Never</option>
|
|
<option value="forever">Forever</option>
|
|
[% CASE %]
|
|
<option value="default" selected="selected">Default</option>
|
|
<option value="never">Never</option>
|
|
<option value="forever">Forever</option>
|
|
[% END %]
|
|
</select>
|
|
<div class="hint">
|
|
Controls how long a patrons checkout history is kept for new patrons of this category. "Never" anonymizes checkouts on return, and "Forever" keeps a patron's checkout history indefinitely. When set to "Default", the amount of history kept is controlled by the cronjob <code>batch_anonymise.pl</code> which should be set up by your system administrator.
|
|
</div>
|
|
</li>
|
|
<li>
|
|
<span class="label">Enrolment period: </span>
|
|
<fieldset class="rows">
|
|
<ol>
|
|
<li>
|
|
<span class="label"></span><strong>Choose one</strong>
|
|
</li>
|
|
<li>
|
|
<label for="enrolmentperiod">In months: </label>
|
|
[% IF category.enrolmentperiod %]
|
|
<input type="number" class="enrolmentperiod" name="enrolmentperiod" id="enrolmentperiod" min="0" size="3" value="[% category.enrolmentperiod | html %]" />
|
|
[% ELSE %]
|
|
<input type="number" class="enrolmentperiod" name="enrolmentperiod" id="enrolmentperiod" min="0" size="3" value="" />
|
|
[% END %]
|
|
</li>
|
|
<li>
|
|
<label for="enrolmentperioddate">Until date: </label>
|
|
<input type="text" class="enrolmentperioddate datepicker" name="enrolmentperioddate" id="enrolmentperioddate" value="[% category.enrolmentperioddate | $KohaDates %]" />
|
|
<div class="hint">[% INCLUDE 'date-format.inc' dateformat = Koha.Preference('dateformat') %]</div>
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
</li>
|
|
</ol>
|
|
|
|
<p>
|
|
To add another patron category and for more settings go to:
|
|
<span class="breadcrumbs"> Administration <b>›</b> Patron categories</span>
|
|
</p>
|
|
|
|
<input type="submit" class="btn btn-primary" value="Submit" />
|
|
</fieldset>
|
|
</form>
|
|
</div> <!-- / #onboarding-step2 -->
|
|
</div> <!-- / .row -->
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|