Jonathan Druart
0ab22e1c7c
In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
90 lines
2.7 KiB
Perl
Executable file
90 lines
2.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Context;
|
|
use C4::Biblio;
|
|
use Koha::Biblios;
|
|
use Koha::Patrons;
|
|
use Koha::Reviews;
|
|
|
|
my $query = new CGI;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "reviews/reviewswaiting.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { tools => 'moderate_comments' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $op = $query->param('op') || '';
|
|
my $status = $query->param('status') || 0;
|
|
my $reviewid = $query->param('reviewid');
|
|
my $page = $query->param('page') || 1;
|
|
my $count = C4::Context->preference('numSearchResults') || 20;
|
|
my $total = Koha::Reviews->search_limited({ approved => $status })->count;
|
|
|
|
if ( $op eq 'approve' ) {
|
|
my $review = Koha::Reviews->find( $reviewid );
|
|
$review->approve if $review;
|
|
}
|
|
elsif ( $op eq 'unapprove' ) {
|
|
my $review = Koha::Reviews->find( $reviewid );
|
|
$review->unapprove if $review;
|
|
}
|
|
elsif ( $op eq 'delete' ) {
|
|
my $review = Koha::Reviews->find( $reviewid );
|
|
$review->delete if $review;
|
|
}
|
|
|
|
my $reviews = Koha::Reviews->search_limited(
|
|
{ approved => $status },
|
|
{
|
|
rows => $count,
|
|
page => $page,
|
|
order_by => { -desc => 'datereviewed' },
|
|
}
|
|
)->unblessed;
|
|
|
|
for my $review ( @$reviews ) {
|
|
my $biblio = Koha::Biblios->find( $review->{biblionumber} );
|
|
# setting some borrower info into this hash
|
|
$review->{bibliotitle} = $biblio->title;
|
|
|
|
my $borrowernumber = $review->{borrowernumber};
|
|
my $patron = Koha::Patrons->find( $borrowernumber);
|
|
if ( $patron ) {
|
|
$review->{patron} = $patron;
|
|
}
|
|
}
|
|
|
|
my $url = "/cgi-bin/koha/reviews/reviewswaiting.pl?status=$status";
|
|
|
|
$template->param(
|
|
status => $status,
|
|
reviews => $reviews,
|
|
pagination_bar => pagination_bar( $url, ( int( $total / $count ) ) + ( ( $total % $count ) > 0 ? 1 : 0 ), $page, "page" )
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|