dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
158 lines
7.7 KiB
HTML
158 lines
7.7 KiB
HTML
[% USE Koha %]
|
|
[% USE Branches %]
|
|
[% USE Categories %]
|
|
<div class="gradient">
|
|
<h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName | html %]</a></h1><!-- Begin Patrons Resident Search Box -->
|
|
<div id="header_search">
|
|
<div id="patron_search" class="residentsearch">
|
|
<p class="tip">Enter patron card number or partial name:</p>
|
|
<form action="/cgi-bin/koha/members/member.pl" method="post">
|
|
<input id="searchmember" data-toggle="tooltip" size="25" class="head-searchbox focus" name="searchmember" type="text" value="[% searchmember | html %]"/>
|
|
<input type="hidden" name="quicksearch" value="1" />
|
|
<span class="filteraction" id="filteraction_off"> <a href="#">[-]</a></span>
|
|
<span class="filteraction" id="filteraction_on"> <a href="#">[+]</a></span>
|
|
|
|
<input value="Search" class="submit" type="submit" />
|
|
|
|
<div id="filters">
|
|
<p><label for="searchfieldstype">Search fields:</label>
|
|
<select name="searchfieldstype" id="searchfieldstype">
|
|
[% IF searchfieldstype == "standard" %]
|
|
<option selected="selected" value='standard'>Standard</option>
|
|
[% ELSE %]
|
|
<option value='standard'>Standard</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "surname" %]
|
|
<option selected="selected" value='surname'>Surname</option>
|
|
[% ELSE %]
|
|
<option value='surname'>Surname</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "email" %]
|
|
<option selected="selected" value='email'>Email</option>
|
|
[% ELSE %]
|
|
<option value='email'>Email</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "borrowernumber" %]
|
|
<option selected="selected" value='borrowernumber'>Borrower number</option>
|
|
[% ELSE %]
|
|
<option value='borrowernumber'>Borrower number</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "userid" %]
|
|
<option selected="selected" value='userid'>Username</option>
|
|
[% ELSE %]
|
|
<option value='userid'>Username</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "phone" %]
|
|
<option selected="selected" value='phone'>Phone number</option>
|
|
[% ELSE %]
|
|
<option value='phone'>Phone number</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "address" %]
|
|
<option selected="selected" value='address'>Street Address</option>
|
|
[% ELSE %]
|
|
<option value='address'>Street Address</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "dateofbirth" %]
|
|
<option selected="selected" value='dateofbirth'>Date of birth</option>
|
|
[% ELSE %]
|
|
<option value='dateofbirth'>Date of birth</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "sort1" %]
|
|
<option selected="selected" value='sort1'>Sort field 1</option>
|
|
[% ELSE %]
|
|
<option value='sort1'>Sort field 1</option>
|
|
[% END %]
|
|
[% IF searchfieldstype == "sort2" %]
|
|
<option selected="selected" value='sort2'>Sort field 2</option>
|
|
[% ELSE %]
|
|
<option value='sort2'>Sort field 2</option>
|
|
[% END %]
|
|
</select>
|
|
</p>
|
|
|
|
<p>
|
|
<label for="searchtype">Search type:</label>
|
|
<select name="searchtype" id="searchtype">
|
|
[% IF searchtype == 'start_with' %]
|
|
<option selected="selected" value='start_with'>Starts with</option>
|
|
<option value='contain'>Contains</option>
|
|
[% ELSE %]
|
|
<option value='start_with'>Starts with</option>
|
|
<option selected="selected" value='contain'>Contains</option>
|
|
[% END %]
|
|
</select>
|
|
</p>
|
|
|
|
<p>
|
|
<label for="branchcode">Library: </label>
|
|
[% SET branches = Branches.all( selected => branchcode_filter, only_my_group => 1 ) %]
|
|
<select name="branchcode_filter" id="branchcode">
|
|
[% IF branches.size != 1 %]
|
|
<option value="">Any</option>
|
|
[% END %]
|
|
[% FOREACH b IN branches %]
|
|
[% IF b.selected %]
|
|
<option value="[% b.branchcode | html %]" selected="selected">[% b.branchname | html %]</option>
|
|
[% ELSE %]
|
|
<option value="[% b.branchcode | html %]">[% b.branchname | html %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</p>
|
|
|
|
<p>
|
|
<label for="categorycode">Category: </label>
|
|
[% SET categories = Categories.all() %]
|
|
<select name="categorycode_filter" id="categorycode">
|
|
<option value="">Any</option>
|
|
[% FOREACH category IN categories %]
|
|
[% IF category.categorycode == categorycode_filter %]
|
|
<option value="[% category.categorycode | html %]" selected="selected">[% category.description | html %]</option>
|
|
[% ELSE %]
|
|
<option value="[% category.categorycode | html %]">[% category.description | html %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</p>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
[% INCLUDE 'patron-search-box.inc' %]
|
|
|
|
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
|
|
<div id="checkin_search" class="residentsearch">
|
|
<p class="tip">Scan a barcode to check in:</p>
|
|
<form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off">
|
|
<input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" />
|
|
<input value="Submit" class="submit" type="submit" />
|
|
</form>
|
|
</div>
|
|
<div id="renew_search" class="residentsearch">
|
|
<p class="tip">Scan a barcode to renew:</p>
|
|
<form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off">
|
|
<input class="head-searchbox" name="barcode" id="ren_barcode" size="40" />
|
|
<input value="Submit" class="submit" type="submit" />
|
|
</form>
|
|
</div>
|
|
[% END %]
|
|
|
|
[% IF ( CAN_user_catalogue ) %]
|
|
<div id="catalog_search" class="residentsearch">
|
|
<p class="tip">Enter search keywords:</p>
|
|
<form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block">
|
|
[% IF ( Koha.Preference('IntranetCatalogSearchPulldown') ) %][% INCLUDE 'search_indexes.inc' %][% END %]
|
|
<input type="text" name="q" id="search-form" size="40" value="" title="Enter the terms you wish to search for." class="head-searchbox form-text" />
|
|
<input type="submit" name="op" id="opac-submit" value="Submit" class="submit" />
|
|
</form>
|
|
</div>[% END %]
|
|
|
|
<ul>
|
|
<li><a class="keep_text" href="#patron_search">Search patrons</a></li>
|
|
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]<li><a class="keep_text" href="#circ_search">Check out</a></li>[% END %]
|
|
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]<li><a class="keep_text" href="#checkin_search">Check in</a></li>[% END %]
|
|
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]<li><a class="keep_text" href="#renew_search">Renew</a></li>[% END %]
|
|
[% IF ( CAN_user_catalogue ) %]<li><a class="keep_text" href="#catalog_search">Search the catalog</a></li>[% END %]
|
|
</ul>
|
|
</div><!-- /header_search -->
|
|
</div><!-- /gradient -->
|
|
<!-- End Patrons Resident Search Box -->
|