Koha/svc/new_bib
Colin Campbell 263dded818 Bug 6752: Be stricter with utf-8 encoding of output
use encoding(UTF-8) rather than utf-8 for stricter
encoding
Marking output as ':utf8' only flags the data as utf8
using :encoding(UTF-8) also checks it as valid utf-8
see binmode in perlfunc for more details
In accordance with the robustness principle input
filehandles have not been changed as code may make
the undocumented assumption that invalid utf-8 is present
in the imput
Fixes errors reported by t/00-testcritic.t
Where feasable some filehandles have been made lexical rather than
reusing global filehandle vars

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-01-27 12:11:06 +01:00

84 lines
2.7 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2007 LibLime
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
use strict;
use warnings;
use CGI;
use C4::Auth qw/check_api_auth/;
use C4::Biblio;
use XML::Simple;
use C4::Charset;
my $query = new CGI;
binmode STDOUT, ':encoding(UTF-8)';
my ($status, $cookie, $sessionID) = check_api_auth($query, { editcatalogue => 'edit_catalogue'} );
unless ($status eq "ok") {
print $query->header(-type => 'text/xml', -status => '403 Forbidden');
print XMLout({ auth_status => $status }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
exit 0;
}
if ($query->request_method eq "POST") {
add_bib($query);
} else {
print $query->header(-type => 'text/xml', -status => '400 Bad Request');
}
exit 0;
sub add_bib {
my $query = shift;
my $result = {};
my $inxml = $query->param('POSTDATA');
print $query->header(-type => 'text/xml');
my $marcflavour = C4::Context->preference('marcflavour') || 'MARC21';
my $record = eval {MARC::Record::new_from_xml( $inxml, "utf8", $marcflavour)};
my $do_not_escape = 0;
if ($@) {
$result->{'status'} = "failed";
$result->{'error'} = $@;
} else {
# fix character set
if ($record->encoding() eq 'MARC-8') {
my ($guessed_charset, $charset_errors);
($record, $guessed_charset, $charset_errors) = MarcToUTF8Record($record, $marcflavour);
}
# delete any item tags
my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField("items.itemnumber", '');
foreach my $field ($record->field($itemtag)) {
$record->delete_field($field);
}
my ($biblionumber, $biblioitemnumber) = AddBiblio($record, '');
my $new_record = GetMarcBiblio($biblionumber);
$result->{'status'} = "ok";
$result->{'biblionumber'} = $biblionumber;
my $xml = $new_record->as_xml_record();
$xml =~ s/<\?xml.*?\?>//i;
$result->{'marcxml'} = $xml;
$do_not_escape = 1;
}
print XMLout($result, NoAttr => 1, RootName => 'response', XMLDecl => 1, NoEscape => $do_not_escape);
}