Jonathan Druart
e1e38896bb
In order to move IsMemberBlocked to Koha::Patron it makes sense to move the code from Koha::Patron::Debarments::IsDebarred to Koha::Patron->is_debarred. Test plan: 1/ Add a restriction to a patron 2/ make sure he is not able to checkout items any more 3/ Make sure he cannot get a discharge 4/ Put a hold and make sure you get "Patron has restrictions" Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
133 lines
6.3 KiB
Perl
133 lines
6.3 KiB
Perl
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 3 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use Test::More tests => 17;
|
|
use Test::Warn;
|
|
use MARC::Record;
|
|
|
|
use C4::Biblio qw( AddBiblio );
|
|
use C4::Circulation qw( AddIssue AddReturn );
|
|
use C4::Context;
|
|
use C4::Items qw( AddItem );
|
|
use C4::Members qw( AddMember GetMember );
|
|
|
|
use Koha::Patron::Discharge;
|
|
use Koha::Database;
|
|
|
|
use t::lib::TestBuilder;
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
$dbh->do(q|DELETE FROM discharges|);
|
|
|
|
my $library = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
my $another_library = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
|
|
C4::Context->_new_userenv('xxx');
|
|
C4::Context->set_userenv(0, 0, 0, 'firstname', 'surname', $library->{branchcode}, $library->{branchcode}, '', '', '', '', '');
|
|
my $patron = $builder->build({
|
|
source => 'Borrower',
|
|
value => {
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
});
|
|
my $patron2 = $builder->build({
|
|
source => 'Borrower',
|
|
value => {
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
});
|
|
my $patron3 = $builder->build({
|
|
source => 'Borrower',
|
|
value => {
|
|
branchcode => $another_library->{branchcode},
|
|
}
|
|
});
|
|
|
|
# Discharge not possible with issues
|
|
my ( $biblionumber ) = AddBiblio( MARC::Record->new, '');
|
|
my $barcode = 'BARCODE42';
|
|
my ( undef, undef, $itemnumber ) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, barcode => $barcode }, $biblionumber);
|
|
AddIssue( $patron, $barcode );
|
|
is( Koha::Patron::Discharge::can_be_discharged({ borrowernumber => $patron->{borrowernumber} }), 0, 'A patron with issues cannot be discharged' );
|
|
|
|
is( Koha::Patron::Discharge::request({ borrowernumber => $patron->{borrowernumber} }), undef, 'No request done if patron has issues' );
|
|
is( Koha::Patron::Discharge::discharge({ borrowernumber => $patron->{borrowernumber} }), undef, 'No discharge done if patron has issues' );
|
|
is_deeply( Koha::Patron::Discharge::get_pendings(), [], 'There is no pending discharge request' );
|
|
is_deeply( Koha::Patron::Discharge::get_validated(), [], 'There is no validated discharge' );
|
|
|
|
AddReturn( $barcode );
|
|
|
|
# Discharge possible without issue
|
|
is( Koha::Patron::Discharge::can_be_discharged({ borrowernumber => $patron->{borrowernumber} }), 1, 'A patron without issues can be discharged' );
|
|
|
|
is(Koha::Patron::Discharge::generate_as_pdf,undef,"Confirm failure when lacking borrower number");
|
|
|
|
# Verify that the user is not discharged anymore if the restriction has been lifted
|
|
Koha::Patron::Discharge::discharge( { borrowernumber => $patron->{borrowernumber} } );
|
|
Koha::Patron::Discharge::discharge( { borrowernumber => $patron2->{borrowernumber} } );
|
|
Koha::Patron::Discharge::discharge( { borrowernumber => $patron3->{borrowernumber} } );
|
|
is( Koha::Patron::Discharge::is_discharged( { borrowernumber => $patron->{borrowernumber} } ), 1, 'The patron has been discharged' );
|
|
is( Koha::Patrons->find( $patron->{borrowernumber} )->is_debarred, '9999-12-31', 'The patron has been debarred after discharge' );
|
|
is( scalar( @{ Koha::Patron::Discharge::get_validated() } ), 3, 'There are 3 validated discharges' );
|
|
is( scalar( @{ Koha::Patron::Discharge::get_validated( { borrowernumber => $patron->{borrowernumber} } ) } ), 1, 'There is 1 validated discharge for a given patron' );
|
|
is( scalar( @{ Koha::Patron::Discharge::get_validated( { branchcode => $library->{branchcode} } ) } ), 2, 'There is 2 validated discharges for a given branchcode' ); # This is not used in the code yet
|
|
Koha::Patron::Debarments::DelUniqueDebarment( { 'borrowernumber' => $patron->{borrowernumber}, 'type' => 'DISCHARGE' } );
|
|
ok( !Koha::Patrons->find( $patron->{borrowernumber} )->is_debarred, 'The debarment has been lifted' );
|
|
ok( !Koha::Patron::Discharge::is_discharged( { borrowernumber => $patron->{borrowernumber} } ), 'The patron is not discharged after the restriction has been lifted' );
|
|
|
|
# Verify that the discharge works multiple times
|
|
Koha::Patron::Discharge::request({ borrowernumber => $patron->{borrowernumber} });
|
|
is(scalar( @{ Koha::Patron::Discharge::get_pendings() }), 1, 'There is a pending discharge request (second time)');
|
|
Koha::Patron::Discharge::discharge( { borrowernumber => $patron->{borrowernumber} } );
|
|
is_deeply( Koha::Patron::Discharge::get_pendings(), [], 'There is no pending discharge request (second time)');
|
|
|
|
# Check if PDF::FromHTML is installed.
|
|
my $check = eval { require PDF::FromHTML; };
|
|
|
|
# Tests for if PDF::FromHTML is installed
|
|
if ($check) {
|
|
isnt( Koha::Patron::Discharge::generate_as_pdf({ borrowernumber => $patron->{borrowernumber} }), undef, "Temporary PDF generated." );
|
|
}
|
|
# Tests for if PDF::FromHTML is not installed
|
|
else {
|
|
warning_like { Koha::Patron::Discharge::generate_as_pdf({ borrowernumber => $patron->{borrowernumber}, testing => 1 }) }
|
|
[ qr/Can't locate PDF\/FromHTML.pm in \@INC/ ],
|
|
"Expected failure because of missing PDF::FromHTML.";
|
|
}
|
|
|
|
# FIXME
|
|
# At this point, there is a problem with the AutoCommit off
|
|
# The transaction is bloked into DBIx::Class::Storage::DBI::_dbh_execute
|
|
# line my $rv = $sth->execute();
|
|
# We are using 2 connections and the one used by Koha::Schema has the AutoCommit set to 1
|
|
# Even if we switch off this flag, the connection will be blocked.
|
|
# The error is:
|
|
# DBIx::Class::ResultSet::create(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction [for Statement "INSERT INTO discharges ( borrower, needed, validated) VALUES ( ?, ?, ? )" with ParamValues: 0='121', 1='2014-01-08T16:38:29', 2=undef] at /home/koha/src/Koha/DataObject/Discharge.pm line 33
|
|
#is( Koha::Service::Borrower::Discharge::request({ borrowernumber => $patron->{borrowernumber} }), 1, 'Discharge request sent' );
|
|
|
|
$schema->storage->txn_rollback;
|
|
|
|
1;
|