Kyle M Hall
50bb8e96f1
The system preference AllowItemsOnHoldCheckout only affects SIP based checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it matches AllowItemsOnHoldCheckoutSCO. We should also update the description as well. As far as I know AllowItemsOnHoldCheckout has never affected anything except SIP traffic. That does not preclude the addition of another AllowItemsOnHoldCheckout syspref that would affect the staff interface, but that would be an enhancement and is outside the scope of this bug report. Test Plan: 1) Test AllowItemsOnHoldCheckout via SIP 2) Apply this patch 3) Test AllowItemsOnHoldCheckoutSIP via SIP 4) Note there is no difference! 5) Note the syspref description has been update to mention SIP Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
||
---|---|---|
.. | ||
ILS | ||
Sip | ||
t | ||
acstest.py | ||
example_institution_dump.sh | ||
ILS.pm | ||
ILS.pod | ||
interactive_item_dump.pl | ||
interactive_patron_check_password.pl | ||
interactive_patron_dump.pl | ||
interactive_renew_all_dump.pl | ||
Makefile | ||
README | ||
Sip.pm | ||
SIPServer.pm | ||
test.txt | ||
xmlparse.pl |
README for Open NSIP 3M-SIP Server DEPENDENCIES SIPServer is written entirely in Perl, but it require these CPAN perl modules to run: Net::Server - The SIP server is a Net::Server::Prefork server XML::LibXML XML::Parser XML::Simple - for parsing the config file UNIVERSAL::require - for loading the correct ILS interface module Clone - for running the test cases LOGGING SIPServer uses syslog() for status and debugging messages. All syslog messages are logged using the syslog facility 'local6'. If you need to change this, because something else on your system is already using that facililty, just change the definition of 'LOG_SIP' at the top of the file SIPServer.pm Make sure to update your syslog configuration to capture facility 'local6' and record it.