Koha/misc/maintenance/borrowers-force-messaging-defaults.pl
Jonathan Druart 9d6d641d1f Bug 17600: Standardize our EXPORT_OK
On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.

That way we will need to explicitely define the subroutine we want to
use from a module.

This patch is a squashed version of:
Bug 17600: After export.pl
Bug 17600: After perlimport
Bug 17600: Manual changes
Bug 17600: Other manual changes after second perlimports run
Bug 17600: Fix tests

And a lot of other manual changes.

export.pl is a dirty script that can be found on bug 17600.

"perlimport" is:
git clone https://github.com/oalders/App-perlimports.git
cd App-perlimports/
cpanm --installdeps .
export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib"
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \;

The ideas of this patch are to:
* use EXPORT_OK instead of EXPORT
* perltidy the EXPORT_OK list
* remove '&' before the subroutine names
* remove some uneeded use statements
* explicitely import the subroutines we need within the controllers or
modules

Note that the private subroutines (starting with _) should not be
exported (and not used from outside of the module except from tests).

EXPORT vs EXPORT_OK (from
https://www.thegeekstuff.com/2010/06/perl-exporter-examples/)
"""
Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members.

@EXPORT and @EXPORT_OK are the two main variables used during export operation.

@EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace.

@EXPORT_OK does export of symbols on demand basis.
"""

If this patch caused a conflict with a patch you wrote prior to its
push:
* Make sure you are not reintroducing a "use" statement that has been
removed
* "$subroutine" is not exported by the C4::$MODULE module
means that you need to add the subroutine to the @EXPORT_OK list
* Bareword "$subroutine" not allowed while "strict subs"
means that you didn't imported the subroutine from the module:
  - use $MODULE qw( $subroutine list );
You can also use the fully qualified namespace: C4::$MODULE::$subroutine

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-16 08:58:47 +02:00

145 lines
3.9 KiB
Perl
Executable file

#!/usr/bin/perl
#
# Copyright (C) 2011 Tamil s.a.r.l.
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
use warnings;
BEGIN {
# find Koha's Perl modules
# test carefully before changing this
use FindBin ();
eval { require "$FindBin::Bin/../kohalib.pl" };
}
use Koha::Script;
use C4::Context;
use C4::Members::Messaging;
use Getopt::Long qw( GetOptions );
use Pod::Usage qw( pod2usage );
sub usage {
pod2usage( -verbose => 2 );
exit;
}
sub force_borrower_messaging_defaults {
my ($doit, $since, $not_expired, $no_overwrite, $category ) = @_;
print "Since: $since\n" if $since;
my $dbh = C4::Context->dbh;
$dbh->{AutoCommit} = 0;
my $sql =
q|SELECT DISTINCT bo.borrowernumber, bo.categorycode FROM borrowers bo
LEFT JOIN borrower_message_preferences mp USING (borrowernumber)
WHERE 1|;
if ( $since ) {
$sql .= " AND bo.dateenrolled >= ?";
}
if ($not_expired) {
$sql .= " AND bo.dateexpiry >= NOW()"
}
if( $no_overwrite ) {
$sql .= " AND mp.borrowernumber IS NULL";
}
$sql .= " AND bo.categorycode = ?" if $category;
my $sth = $dbh->prepare($sql);
$sth->execute($since || (), $category || () );
my $cnt = 0;
while ( my ($borrowernumber, $categorycode) = $sth->fetchrow ) {
print "$borrowernumber: $categorycode\n";
next unless $doit;
C4::Members::Messaging::SetMessagingPreferencesFromDefaults( {
borrowernumber => $borrowernumber,
categorycode => $categorycode,
} );
$cnt++;
}
$dbh->commit();
print "Total borrowers updated: $cnt\n" if $doit;
}
my ( $doit, $since, $help, $not_expired, $no_overwrite, $category );
my $result = GetOptions(
'doit' => \$doit,
'since:s' => \$since,
'not-expired' => \$not_expired,
'no-overwrite' => \$no_overwrite,
'category:s' => \$category,
'help|h' => \$help,
);
usage() if $help;
force_borrower_messaging_defaults( $doit, $since, $not_expired, $no_overwrite, $category );
=head1 NAME
borrowers-force-messaging-defaults.pl
=head1 SYNOPSIS
borrowers-force-messaging-defaults.pl
borrowers-force-messaging-defaults.pl --help
borrowers-force-messaging-defaults.pl --doit
borrowers-force-messaging-defaults.pl --doit --not-expired
borrowers-force-messaging-defaults.pl --doit --category PT
=head1 DESCRIPTION
If the EnhancedMessagingPreferences syspref is enabled after borrowers have
been created in the DB, those borrowers won't have messaging transport
preferences default values as defined for their borrower category. So you would
have to modify each borrower one by one if you would like to send them 'Hold
Filled' notice for example.
This script creates/overwrites messaging preferences for all borrowers and sets
them to default values defined for the category they belong to (unless you
use the options -not-expired or -no-overwrite to update a subset).
=over 8
=item B<--help>
Prints this help
=item B<--doit>
Actually update the borrowers.
=item B<--not-expired>
Will only update active borrowers (borrowers who didn't pass their expiration date).
=item B<--no-overwrite>
Will only update patrons without messaging preferences and skip patrons that
already set their preferences.
=item B<--category>
Will only update patrons in the category specified.
=back
=cut