d8c0b836d6
The issue is that CircAutocompl loads a script element under #header_search element. When this element is missing, it also messes up the indexing, because we were calculating the indexing of the found element by subtracting one from the found element's index (to eliminate the <script> element). Thats why the shortcut key problem in this bug takes you one too to the left, because we are still subtracting one from the index even though there is no <script> element anymore. This patches selects only the div elements and gets the index from them. No subtractions needed. To test keys: 1. Set CircAutocompl system preference to Don't try. 2. Try the shortcut keys. They will work incorrectly like this: Alt+U = Search catalogue Alt+R = Check out Alt+Q = Check in 3. Set CircAutocompl system preference to Try. 4. Try the shortcut keys. They will work correctly like this: Alt+U = Check out Alt+R = Check in ALt+Q = Search catalogue 5. Apply patch 6. Repeat step 1 and 4. 7. Repeat step 3 and 4. 8. Observe that regardless of CircAutocompl, shortcut keys worked correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
||
|---|---|---|
| .. | ||
| en | ||
| img | ||
| sound | ||